This is an automated email from the ASF dual-hosted git repository.
lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new f8d3b10b4b GH-41590: [Java] Improve BaseRepeatedValueVector function
on isEmpty and isNull operations (#41601)
f8d3b10b4b is described below
commit f8d3b10b4b89b47f6e7a594b95c82e2ff161f1a5
Author: Tai Le Manh <[email protected]>
AuthorDate: Fri May 10 12:42:25 2024 +0700
GH-41590: [Java] Improve BaseRepeatedValueVector function on isEmpty and
isNull operations (#41601)
### Rationale for this change
Resolves #41590 .
### What changes are included in this PR?
Make `abstract` on `isNull` and `isEmpty` of `BaseRepeatedValueVector`.
### Are these changes tested?
Existing tests pass.
### Are there any user-facing changes?
No.
* GitHub Issue: #41590
Authored-by: Tai Le Manh <[email protected]>
Signed-off-by: David Li <[email protected]>
---
.../apache/arrow/vector/complex/BaseRepeatedValueVector.java | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git
a/java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueVector.java
b/java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueVector.java
index 7906d90c2f..7c4015299a 100644
---
a/java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueVector.java
+++
b/java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueVector.java
@@ -355,16 +355,8 @@ public abstract class BaseRepeatedValueVector extends
BaseValueVector implements
offsetBuffer.getInt(index * OFFSET_WIDTH);
}
- /** Return if value at index is null (this implementation is always false).
*/
- @Override
- public boolean isNull(int index) {
- return false;
- }
-
- /** Return if value at index is empty (this implementation is always false).
*/
- public boolean isEmpty(int index) {
- return false;
- }
+ /** Return if value at index is empty. */
+ public abstract boolean isEmpty(int index);
/** Starts a new repeated value. */
public int startNewValue(int index) {