This is an automated email from the ASF dual-hosted git repository.
paleolimbot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-nanoarrow.git
The following commit(s) were added to refs/heads/main by this push:
new c413d69f chore(python): Skip buffer write lock test on PyPy (#480)
c413d69f is described below
commit c413d69f78eedefac378a318390e808b5a16e6b9
Author: Dewey Dunnington <[email protected]>
AuthorDate: Sun May 19 21:03:57 2024 -0300
chore(python): Skip buffer write lock test on PyPy (#480)
...apparently my local PyPy test was not sufficient to ensure that all
the tests pass on PyPy. This seems to be specific to the `memoryview()`
(not C extensions that properly release the buffer).
---
python/tests/test_c_buffer.py | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/python/tests/test_c_buffer.py b/python/tests/test_c_buffer.py
index b3282aa4..6a38d127 100644
--- a/python/tests/test_c_buffer.py
+++ b/python/tests/test_c_buffer.py
@@ -238,10 +238,8 @@ def test_c_buffer_builder_buffer_protocol():
mv[builder.size_bytes] = ord("k")
- if platform.python_implementation() == "PyPy" and
platform.python_version_tuple()[
- :2
- ] == ("3", "8"):
- pytest.skip("memoryview() release is not guaranteed on PyPy 3.8")
+ if platform.python_implementation() == "PyPy":
+ pytest.skip("memoryview() release is not guaranteed on PyPy")
builder.advance(1)
assert bytes(builder.finish()) == b"k"
