(arrow) branch main updated: GH-41720: [C++][Acero] Remove an useless parameter for QueryContext::Init called in hash_join_benchmark (#41716)

[apitrou]

This is an automated email from the ASF dual-hosted git repository.

apitrou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new c8f89d06bb GH-41720: [C++][Acero] Remove an useless parameter for 
QueryContext::Init called in hash_join_benchmark  (#41716)
c8f89d06bb is described below

commit c8f89d06bb79909dbd52d7d1504bdcadb220fadd
Author: ZhangHuiGui <106943008+zhanghui...@users.noreply.github.com>
AuthorDate: Thu May 23 11:37:31 2024 -0400

    GH-41720: [C++][Acero] Remove an useless parameter for QueryContext::Init 
called in hash_join_benchmark  (#41716)
    
    
    
    ### Rationale for this change
    My local compilation parameters will include the compilation of some basic 
benchmarks. I discovered this compilation problem today. It seems that #41334 
of `QueryContext::Init` is not synchronized to `hash_join_benchmark.cc`, and CI 
has not found this problem. .
    
    ### What changes are included in this PR?
    Remove the first arg .
    
    ### Are these changes tested?
    Needn't
    
    ### Are there any user-facing changes?
    No
    
    * GitHub Issue: #41720
    
    Lead-authored-by: ZhangHuiGui <2689496...@qq.com>
    Co-authored-by: ZhangHuiGui <hugo.zh...@openpie.com>
    Signed-off-by: Antoine Pitrou <anto...@python.org>
---
 ci/scripts/cpp_build.sh                    | 1 +
 cpp/src/arrow/acero/hash_join_benchmark.cc | 2 +-
 docker-compose.yml                         | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/ci/scripts/cpp_build.sh b/ci/scripts/cpp_build.sh
index a1f40fc360..6a3a53f253 100755
--- a/ci/scripts/cpp_build.sh
+++ b/ci/scripts/cpp_build.sh
@@ -120,6 +120,7 @@ else
     -DARROW_BUILD_BENCHMARKS=${ARROW_BUILD_BENCHMARKS:-OFF} \
     -DARROW_BUILD_EXAMPLES=${ARROW_BUILD_EXAMPLES:-OFF} \
     -DARROW_BUILD_INTEGRATION=${ARROW_BUILD_INTEGRATION:-OFF} \
+    -DARROW_BUILD_OPENMP_BENCHMARKS=${ARROW_BUILD_OPENMP_BENCHMARKS:-OFF} \
     -DARROW_BUILD_SHARED=${ARROW_BUILD_SHARED:-ON} \
     -DARROW_BUILD_STATIC=${ARROW_BUILD_STATIC:-ON} \
     -DARROW_BUILD_TESTS=${ARROW_BUILD_TESTS:-OFF} \
diff --git a/cpp/src/arrow/acero/hash_join_benchmark.cc 
b/cpp/src/arrow/acero/hash_join_benchmark.cc
index ad1bd67cc8..1f8e02e9f0 100644
--- a/cpp/src/arrow/acero/hash_join_benchmark.cc
+++ b/cpp/src/arrow/acero/hash_join_benchmark.cc
@@ -148,7 +148,7 @@ class JoinBenchmark {
     };
 
     scheduler_ = TaskScheduler::Make();
-    DCHECK_OK(ctx_.Init(settings.num_threads, nullptr));
+    DCHECK_OK(ctx_.Init(nullptr));
 
     auto register_task_group_callback = [&](std::function<Status(size_t, 
int64_t)> task,
                                             std::function<Status(size_t)> 
cont) {
diff --git a/docker-compose.yml b/docker-compose.yml
index a1d8f60a26..9f575e2030 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -286,6 +286,7 @@ services:
       <<: [*common, *ccache, *sccache, *cpp]
       ARROW_BUILD_BENCHMARKS: "ON"
       ARROW_BUILD_EXAMPLES: "ON"
+      ARROW_BUILD_OPENMP_BENCHMARKS: "ON"
       ARROW_ENABLE_TIMING_TESTS:  # inherit
       ARROW_EXTRA_ERROR_CONTEXT: "ON"
       ARROW_MIMALLOC: "ON"