This is an automated email from the ASF dual-hosted git repository.
lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git
The following commit(s) were added to refs/heads/main by this push:
new 0543d371a fix(c/vendor/nanoarrow): Fix -Wreorder warning (#1966)
0543d371a is described below
commit 0543d371aae5ba7a7689bbf1c6edeec1f400ef33
Author: Dewey Dunnington <[email protected]>
AuthorDate: Thu Jul 4 08:46:38 2024 +0000
fix(c/vendor/nanoarrow): Fix -Wreorder warning (#1966)
In some of the R packages we get:
```
* checking whether package 'adbcsqlite' can be installed ... [35s] WARNING
Found the following significant warnings:
../src/c/vendor/nanoarrow/nanoarrow.hpp:868:19: warning:
'nanoarrow::ViewArrayStream::code_' will be initialized after [-Wreorder]
../src/c/vendor/nanoarrow/nanoarrow.hpp:867:15: warning: 'ArrowError*
nanoarrow::ViewArrayStream::error_' [-Wreorder]
../src/c/vendor/nanoarrow/nanoarrow.hpp:828:3: warning: when
initialized here [-Wreorder]
See
'D:/a/arrow-adbc/arrow-adbc/r/adbcsqlite/check/adbcsqlite.Rcheck/00install.out'
for details.
```
https://github.com/apache/arrow-adbc/actions/runs/9788345921/job/27026279250?pr=1965#step:10:166
This has already been fixed upstream:
https://github.com/apache/arrow-nanoarrow/blob/c74bb37b990541c82305b000b516f922db74d1f9/src/nanoarrow/nanoarrow.hpp#L846
---
.github/workflows/r-standard.yml | 3 +--
c/vendor/nanoarrow/nanoarrow.hpp | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/.github/workflows/r-standard.yml b/.github/workflows/r-standard.yml
index 09cd1f100..9a5a49682 100644
--- a/.github/workflows/r-standard.yml
+++ b/.github/workflows/r-standard.yml
@@ -17,8 +17,7 @@
name: R (standard)
-# Runs on PRs that touch the R packages and when pushing files the R
-# package uses to main.
+# Runs on PRs that touch the R packages directly
on:
pull_request:
branches:
diff --git a/c/vendor/nanoarrow/nanoarrow.hpp b/c/vendor/nanoarrow/nanoarrow.hpp
index 0de2371b4..5f8aabbac 100644
--- a/c/vendor/nanoarrow/nanoarrow.hpp
+++ b/c/vendor/nanoarrow/nanoarrow.hpp
@@ -864,8 +864,8 @@ class ViewArrayStream {
};
internal::InputRange<Next> range_;
- ArrowError* error_;
ArrowErrorCode* code_;
+ ArrowError* error_;
ArrowError internal_error_ = {};
ArrowErrorCode internal_code_;
bool code_was_accessed_ = false;
