This is an automated email from the ASF dual-hosted git repository.
raulcd pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 5b5c164a6a GH-43116: [C++][Compute] Mark
KeyCompare.CompareColumnsToRowsLarge as large memory test (#43128)
5b5c164a6a is described below
commit 5b5c164a6a467af2803e927b2de1b9b6ee5de895
Author: Rossi Sun <[email protected]>
AuthorDate: Fri Jul 5 16:59:58 2024 +0800
GH-43116: [C++][Compute] Mark KeyCompare.CompareColumnsToRowsLarge as large
memory test (#43128)
### Rationale for this change
This test consumes more than 4GB memory and causes oom-kill when running
with TSAN as reported in #43116 .
### What changes are included in this PR?
Limit its running by marking it as large memory test.
### Are these changes tested?
Change is test.
### Are there any user-facing changes?
None.
* GitHub Issue: #43116
Authored-by: Ruoxi Sun <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
---
cpp/src/arrow/compute/row/compare_test.cc | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/cpp/src/arrow/compute/row/compare_test.cc
b/cpp/src/arrow/compute/row/compare_test.cc
index 662862075c..22af7e067d 100644
--- a/cpp/src/arrow/compute/row/compare_test.cc
+++ b/cpp/src/arrow/compute/row/compare_test.cc
@@ -166,10 +166,9 @@ TEST(KeyCompare, CompareColumnsToRowsTempStackUsage) {
}
}
-#ifndef ARROW_VALGRIND
// Compare columns to rows at offsets over 2GB within a row table.
// Certain AVX2 instructions may behave unexpectedly causing troubles like
GH-41813.
-TEST(KeyCompare, CompareColumnsToRowsLarge) {
+TEST(KeyCompare, LARGE_MEMORY_TEST(CompareColumnsToRowsLarge)) {
if constexpr (sizeof(void*) == 4) {
GTEST_SKIP() << "Test only works on 64-bit platforms";
}
@@ -300,7 +299,6 @@ TEST(KeyCompare, CompareColumnsToRowsLarge) {
num_rows);
}
}
-#endif // ARROW_VALGRIND
} // namespace compute
} // namespace arrow