This is an automated email from the ASF dual-hosted git repository.
lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 2a793d6410 GH-43962: [Java] Consider warnings as errors for Adapter
Module (#43963)
2a793d6410 is described below
commit 2a793d6410539cf72f49f0bd06e1087d56c99d9f
Author: Vibhatha Lakmal Abeykoon <[email protected]>
AuthorDate: Wed Sep 11 06:49:33 2024 +0530
GH-43962: [Java] Consider warnings as errors for Adapter Module (#43963)
### Rationale for this change
This PR configs the build such that warnings are considered as errors in
the Adapter module. And corresponding code changes have also been made.
### What changes are included in this PR?
Adding flags to consider warnings as errors in javac and fixing the
corresponding errors.
### Are these changes tested?
Tested by existing test cases.
### Are there any user-facing changes?
N/A
* GitHub Issue: #43962
Authored-by: Vibhatha Lakmal Abeykoon <[email protected]>
Signed-off-by: David Li <[email protected]>
---
java/adapter/avro/pom.xml | 14 ++++++++++++++
.../apache/arrow/adapter/avro/AvroToArrowIteratorTest.java | 1 +
java/adapter/jdbc/pom.xml | 9 +++++++++
.../arrow/adapter/jdbc/h2/JdbcToArrowCharSetTest.java | 1 +
.../arrow/adapter/jdbc/h2/JdbcToArrowDataTypesTest.java | 1 +
.../arrow/adapter/jdbc/h2/JdbcToArrowMapDataTypeTest.java | 1 +
.../apache/arrow/adapter/jdbc/h2/JdbcToArrowNullTest.java | 1 +
.../adapter/jdbc/h2/JdbcToArrowOptionalColumnsTest.java | 1 +
.../org/apache/arrow/adapter/jdbc/h2/JdbcToArrowTest.java | 1 +
.../arrow/adapter/jdbc/h2/JdbcToArrowTimeZoneTest.java | 1 +
.../adapter/jdbc/h2/JdbcToArrowVectorIteratorTest.java | 1 +
java/adapter/orc/pom.xml | 9 +++++++++
12 files changed, 41 insertions(+)
diff --git a/java/adapter/avro/pom.xml b/java/adapter/avro/pom.xml
index cb4adccb76..2c02e72e9c 100644
--- a/java/adapter/avro/pom.xml
+++ b/java/adapter/avro/pom.xml
@@ -56,4 +56,18 @@ under the License.
<version>${dep.avro.version}</version>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration combine.children="append">
+ <compilerArgs>
+ <arg>-Werror</arg>
+ </compilerArgs>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
</project>
diff --git
a/java/adapter/avro/src/test/java/org/apache/arrow/adapter/avro/AvroToArrowIteratorTest.java
b/java/adapter/avro/src/test/java/org/apache/arrow/adapter/avro/AvroToArrowIteratorTest.java
index f8022a9385..44ccbc7451 100644
---
a/java/adapter/avro/src/test/java/org/apache/arrow/adapter/avro/AvroToArrowIteratorTest.java
+++
b/java/adapter/avro/src/test/java/org/apache/arrow/adapter/avro/AvroToArrowIteratorTest.java
@@ -50,6 +50,7 @@ import org.junit.jupiter.api.Test;
public class AvroToArrowIteratorTest extends AvroTestBase {
@BeforeEach
+ @Override
public void init() {
final BufferAllocator allocator = new RootAllocator(Long.MAX_VALUE);
this.config = new
AvroToArrowConfigBuilder(allocator).setTargetBatchSize(3).build();
diff --git a/java/adapter/jdbc/pom.xml b/java/adapter/jdbc/pom.xml
index 099798a95c..5ebb4089cf 100644
--- a/java/adapter/jdbc/pom.xml
+++ b/java/adapter/jdbc/pom.xml
@@ -116,6 +116,15 @@ under the License.
<argLine>--add-reads=org.apache.arrow.adapter.jdbc=com.fasterxml.jackson.dataformat.yaml
--add-opens=java.base/java.nio=org.apache.arrow.memory.core,ALL-UNNAMED
-Duser.timezone=UTC</argLine>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration combine.children="append">
+ <compilerArgs>
+ <arg>-Werror</arg>
+ </compilerArgs>
+ </configuration>
+ </plugin>
</plugins>
</build>
</project>
diff --git
a/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowCharSetTest.java
b/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowCharSetTest.java
index 726e1905c4..39c0085603 100644
---
a/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowCharSetTest.java
+++
b/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowCharSetTest.java
@@ -91,6 +91,7 @@ public class JdbcToArrowCharSetTest extends
AbstractJdbcToArrowTest {
*/
@ParameterizedTest
@MethodSource("getTestData")
+ @Override
public void testJdbcToArrowValues(Table table)
throws SQLException, IOException, ClassNotFoundException {
this.initializeDatabase(table);
diff --git
a/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowDataTypesTest.java
b/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowDataTypesTest.java
index c246bb2bec..2274f51745 100644
---
a/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowDataTypesTest.java
+++
b/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowDataTypesTest.java
@@ -145,6 +145,7 @@ public class JdbcToArrowDataTypesTest extends
AbstractJdbcToArrowTest {
/** Test Method to test JdbcToArrow Functionality for various H2 DB based
datatypes. */
@ParameterizedTest
@MethodSource("getTestData")
+ @Override
public void testJdbcToArrowValues(Table table)
throws SQLException, IOException, ClassNotFoundException {
this.initializeDatabase(table);
diff --git
a/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowMapDataTypeTest.java
b/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowMapDataTypeTest.java
index 1daeda6772..456d338f6b 100644
---
a/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowMapDataTypeTest.java
+++
b/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowMapDataTypeTest.java
@@ -45,6 +45,7 @@ public class JdbcToArrowMapDataTypeTest extends
AbstractJdbcToArrowTest {
/** Test Method to test JdbcToArrow Functionality for Map form Types.OTHER
column. */
@ParameterizedTest
@MethodSource("getTestData")
+ @Override
public void testJdbcToArrowValues(Table table)
throws SQLException, IOException, ClassNotFoundException {
this.initializeDatabase(table);
diff --git
a/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowNullTest.java
b/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowNullTest.java
index 205b7e16f2..2009268980 100644
---
a/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowNullTest.java
+++
b/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowNullTest.java
@@ -113,6 +113,7 @@ public class JdbcToArrowNullTest extends
AbstractJdbcToArrowTest {
*/
@ParameterizedTest
@MethodSource("getTestData")
+ @Override
public void testJdbcToArrowValues(Table table)
throws SQLException, IOException, ClassNotFoundException {
this.initializeDatabase(table);
diff --git
a/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowOptionalColumnsTest.java
b/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowOptionalColumnsTest.java
index 382d20f45d..2108afec4c 100644
---
a/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowOptionalColumnsTest.java
+++
b/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowOptionalColumnsTest.java
@@ -59,6 +59,7 @@ public class JdbcToArrowOptionalColumnsTest extends
AbstractJdbcToArrowTest {
*/
@ParameterizedTest
@MethodSource("getTestData")
+ @Override
public void testJdbcToArrowValues(Table table)
throws SQLException, IOException, ClassNotFoundException {
this.initializeDatabase(table);
diff --git
a/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowTest.java
b/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowTest.java
index 7966f62e17..bea7d4d37c 100644
---
a/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowTest.java
+++
b/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowTest.java
@@ -87,6 +87,7 @@ public class JdbcToArrowTest extends AbstractJdbcToArrowTest {
*/
@ParameterizedTest
@MethodSource("getTestData")
+ @Override
public void testJdbcToArrowValues(Table table)
throws SQLException, IOException, ClassNotFoundException {
this.initializeDatabase(table);
diff --git
a/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowTimeZoneTest.java
b/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowTimeZoneTest.java
index 0f60c89d1c..14396997d2 100644
---
a/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowTimeZoneTest.java
+++
b/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowTimeZoneTest.java
@@ -91,6 +91,7 @@ public class JdbcToArrowTimeZoneTest extends
AbstractJdbcToArrowTest {
*/
@ParameterizedTest
@MethodSource("getTestData")
+ @Override
public void testJdbcToArrowValues(Table table)
throws SQLException, IOException, ClassNotFoundException {
this.initializeDatabase(table);
diff --git
a/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowVectorIteratorTest.java
b/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowVectorIteratorTest.java
index 40fd39ac0c..de9eff327e 100644
---
a/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowVectorIteratorTest.java
+++
b/java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/h2/JdbcToArrowVectorIteratorTest.java
@@ -76,6 +76,7 @@ public class JdbcToArrowVectorIteratorTest extends
JdbcToArrowTest {
@ParameterizedTest
@MethodSource("getTestData")
+ @Override
public void testJdbcToArrowValues(Table table)
throws SQLException, IOException, ClassNotFoundException {
this.initializeDatabase(table);
diff --git a/java/adapter/orc/pom.xml b/java/adapter/orc/pom.xml
index d9cd2bb21a..cf35397c99 100644
--- a/java/adapter/orc/pom.xml
+++ b/java/adapter/orc/pom.xml
@@ -160,6 +160,15 @@ under the License.
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration combine.children="append">
+ <compilerArgs>
+ <arg>-Werror</arg>
+ </compilerArgs>
+ </configuration>
+ </plugin>
</plugins>
</build>
</project>
