This is an automated email from the ASF dual-hosted git repository.
apitrou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new a828bd2abc GH-44095: [CI][Python] Enable S3 testing on Windows wheel
builds (#44093)
a828bd2abc is described below
commit a828bd2abcdb4bf55511d57ccc4ec58cdc2f28b0
Author: Antoine Pitrou <[email protected]>
AuthorDate: Fri Sep 13 16:13:40 2024 +0200
GH-44095: [CI][Python] Enable S3 testing on Windows wheel builds (#44093)
### Rationale for this change
We currently build Windows wheels with S3 enabled, but we disable it for
testing.
### What changes are included in this PR?
Ensure Minio is installed and re-enable S3 for testing.
### Are these changes tested?
Yes, by construction (on CI).
### Are there any user-facing changes?
No.
* GitHub Issue: #44095
Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
---
ci/docker/python-wheel-windows-test-vs2019.dockerfile | 7 +++++--
ci/scripts/python_wheel_windows_test.bat | 2 +-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/ci/docker/python-wheel-windows-test-vs2019.dockerfile
b/ci/docker/python-wheel-windows-test-vs2019.dockerfile
index 625ab25f84..bffc1bd13d 100644
--- a/ci/docker/python-wheel-windows-test-vs2019.dockerfile
+++ b/ci/docker/python-wheel-windows-test-vs2019.dockerfile
@@ -27,13 +27,16 @@ FROM abrarov/msvc-2019:2.11.0
# Add unix tools to path
RUN setx path "%path%;C:\Program Files\Git\usr\bin"
-# Remove previous installations of python from the base image
+# 1. Remove previous installations of python from the base image
# NOTE: a more recent base image (tried with 2.12.1) comes with python 3.9.7
# and the msi installers are failing to remove pip and tcl/tk "products" making
# the subsequent choco python installation step failing for installing python
# version 3.9.* due to existing python version
+# 2. Install Minio for S3 testing.
RUN wmic product where "name like 'python%%'" call uninstall /nointeractive &&
\
- rm -rf Python*
+ rm -rf Python* && \
+ curl
https://dl.min.io/server/minio/release/windows-amd64/archive/minio.RELEASE.2022-05-26T05-48-41Z
\
+ --output "C:\Windows\Minio.exe"
# Install the GCS testbench using a well-known Python version.
# NOTE: cannot use pipx's `--fetch-missing-python` because of
diff --git a/ci/scripts/python_wheel_windows_test.bat
b/ci/scripts/python_wheel_windows_test.bat
index de5a2c2e96..ae5b7e36ad 100755
--- a/ci/scripts/python_wheel_windows_test.bat
+++ b/ci/scripts/python_wheel_windows_test.bat
@@ -28,7 +28,7 @@ set PYARROW_TEST_ORC=ON
set PYARROW_TEST_PARQUET=ON
set PYARROW_TEST_PARQUET_ENCRYPTION=ON
set PYARROW_TEST_SUBSTRAIT=ON
-set PYARROW_TEST_S3=OFF
+set PYARROW_TEST_S3=ON
set PYARROW_TEST_TENSORFLOW=ON
@REM Enable again once https://github.com/scipy/oldest-supported-numpy/pull/27
gets merged
