(arrow) branch main updated: GH-41347: [FlightRPC][C#] Allow hosting flight server in pre-Kestrel .net versions (#41348)

[curth]

This is an automated email from the ASF dual-hosted git repository.

curth pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new cf010cdf9c GH-41347: [FlightRPC][C#] Allow hosting flight server in 
pre-Kestrel .net versions (#41348)
cf010cdf9c is described below

commit cf010cdf9cb808ac872224b894bd5e1118ca76b7
Author: David Chapman <davidjchap...@gmail.com>
AuthorDate: Sat Sep 14 15:02:28 2024 +0100

    GH-41347: [FlightRPC][C#] Allow hosting flight server in pre-Kestrel .net 
versions (#41348)
    
    ### Rationale for this change
    
    With the existing structure it is not possible to create a flight RPC 
service as a regular GRPC service, outside of AspNet.Core/Kestrel.
    
    This can be supported by changing the protection level of the generated 
classes and FlightServiceImplementation.cs
    
    ### What changes are included in this PR?
    
    Change protection level from internal to public for generated protocol 
files and FlightServiceImplementation.cs
    
    ### Are these changes tested?
    
    Confirmed that classes are public in the built assembly.
    
    ### Are there any user-facing changes?
    
    Generated protocol classes will become visible to end users.
    
    * GitHub Issue: #41347
    
    Authored-by: David Chapman <david.chap...@gazprom-mt.com>
    Signed-off-by: Curt Hagenlocher <c...@hagenlocher.org>
---
 .../Apache.Arrow.Flight/Apache.Arrow.Flight.csproj |  6 +++++-
 .../Server/GrpcCoreFlightServerExtensions.cs       | 24 ++++++++++++++++++++++
 2 files changed, 29 insertions(+), 1 deletion(-)

diff --git a/csharp/src/Apache.Arrow.Flight/Apache.Arrow.Flight.csproj 
b/csharp/src/Apache.Arrow.Flight/Apache.Arrow.Flight.csproj
index a12f3f8249..dc2e720313 100644
--- a/csharp/src/Apache.Arrow.Flight/Apache.Arrow.Flight.csproj
+++ b/csharp/src/Apache.Arrow.Flight/Apache.Arrow.Flight.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks>
+    <TargetFrameworks>netstandard2.0;netstandard2.1;net462</TargetFrameworks>
   </PropertyGroup>
   
   <ItemGroup>
@@ -14,6 +14,10 @@
   <ItemGroup Condition="'$(TargetFramework)'=='netstandard2.0'">
     <PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="6.0.0" 
/>
   </ItemGroup>
+  
+  <ItemGroup Condition="'$(TargetFramework)'=='net462'">
+    <PackageReference Include="Grpc.Core" Version="2.46.6" />
+  </ItemGroup>
 
   <ItemGroup>
     <ProjectReference Include="..\Apache.Arrow\Apache.Arrow.csproj" />
diff --git 
a/csharp/src/Apache.Arrow.Flight/Server/GrpcCoreFlightServerExtensions.cs 
b/csharp/src/Apache.Arrow.Flight/Server/GrpcCoreFlightServerExtensions.cs
new file mode 100644
index 0000000000..92c0af630a
--- /dev/null
+++ b/csharp/src/Apache.Arrow.Flight/Server/GrpcCoreFlightServerExtensions.cs
@@ -0,0 +1,24 @@
+#if NET46_OR_GREATER
+
+using Apache.Arrow.Flight.Protocol;
+using Apache.Arrow.Flight.Server.Internal;
+using Grpc.Core;
+
+namespace Apache.Arrow.Flight.Server
+{
+    public static class GrpcCoreFlightServerExtensions
+    {
+        /// <summary>
+        /// Create a ServerServiceDefinition for use with a <see 
href="https://grpc.github.io/grpc/csharp/api/Grpc.Core.Server.html";>Grpc.Core 
Server</see>
+        //  This allows running a flight server on pre-Kestrel .net Framework 
versions
+        /// </summary>
+        /// <param name="flightServer"></param>
+        /// <returns></returns>
+        public static ServerServiceDefinition CreateServiceDefinition(this 
FlightServer flightServer)
+        {
+            return FlightService.BindService(new 
FlightServerImplementation(flightServer));
+        }
+    }
+}
+
+#endif