This is an automated email from the ASF dual-hosted git repository.
curth pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 46e7f38af7 GH-23995: [C#] Make PrimitiveArrayBuilder constructor
public (#44596)
46e7f38af7 is described below
commit 46e7f38af71ed701815593f4b6327ceb464d3686
Author: Benedikt Reinartz <[email protected]>
AuthorDate: Tue Nov 5 17:02:27 2024 +0100
GH-23995: [C#] Make PrimitiveArrayBuilder constructor public (#44596)
Fixes #23995.
Making these constructors `public` allows for writing custom builders.
### Rationale for this change
Allows for writing custom builders.
### What changes are included in this PR?
Only change of visibility on the default constructors of
`PrimitiveArrayBuilder`.
### Are these changes tested?
There is not much to test :)
### Are there any user-facing changes?
See above.
* GitHub Issue: #23995
Authored-by: Benedikt Reinartz <[email protected]>
Signed-off-by: Curt Hagenlocher <[email protected]>
---
csharp/src/Apache.Arrow/Arrays/PrimitiveArrayBuilder.cs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/csharp/src/Apache.Arrow/Arrays/PrimitiveArrayBuilder.cs
b/csharp/src/Apache.Arrow/Arrays/PrimitiveArrayBuilder.cs
index ae02173fb0..b3583842c1 100644
--- a/csharp/src/Apache.Arrow/Arrays/PrimitiveArrayBuilder.cs
+++ b/csharp/src/Apache.Arrow/Arrays/PrimitiveArrayBuilder.cs
@@ -30,7 +30,7 @@ namespace Apache.Arrow
public int Length => ArrayBuilder.Length;
- internal PrimitiveArrayBuilder(IArrowArrayBuilder<TTo, TArray,
IArrowArrayBuilder<TArray>> builder)
+ public PrimitiveArrayBuilder(IArrowArrayBuilder<TTo, TArray,
IArrowArrayBuilder<TArray>> builder)
{
ArrayBuilder = builder ?? throw new
ArgumentNullException(nameof(builder));
}
@@ -110,7 +110,7 @@ namespace Apache.Arrow
public int Length => ValueBuffer.Length;
protected int NullCount => ValidityBuffer.UnsetBitCount;
- internal PrimitiveArrayBuilder()
+ public PrimitiveArrayBuilder()
{
ValueBuffer = new ArrowBuffer.Builder<T>();
ValidityBuffer = new ArrowBuffer.BitmapBuilder();