This is an automated email from the ASF dual-hosted git repository.
kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 9d1945052d GH-44700: [C++][Parquet] Remove obsolete parquet_constants
generated files from old thrift (#44772)
9d1945052d is described below
commit 9d1945052d717730107b84ca660e373c0e2cc03c
Author: Raúl Cumplido <[email protected]>
AuthorDate: Tue Nov 19 02:34:41 2024 +0100
GH-44700: [C++][Parquet] Remove obsolete parquet_constants generated files
from old thrift (#44772)
### Rationale for this change
The files were generated 4 years ago with and old version of Thrift and
don't seem necessary anymore.
### What changes are included in this PR?
Remove obsolete files.
### Are these changes tested?
No new tests added, just validate tests pass.
### Are there any user-facing changes?
No
* GitHub Issue: #44700
Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
---
cpp/build-support/lint_exclusions.txt | 1 -
cpp/src/generated/parquet_constants.cpp | 17 -----------------
cpp/src/generated/parquet_constants.h | 24 ------------------------
cpp/src/parquet/CMakeLists.txt | 4 ----
dev/release/rat_exclude_files.txt | 2 --
5 files changed, 48 deletions(-)
diff --git a/cpp/build-support/lint_exclusions.txt
b/cpp/build-support/lint_exclusions.txt
index 195c3dee36..aa57db72ce 100644
--- a/cpp/build-support/lint_exclusions.txt
+++ b/cpp/build-support/lint_exclusions.txt
@@ -3,7 +3,6 @@
*RcppExports.cpp*
*_generated*
*arrowExports.cpp*
-*parquet_constants.*
*parquet_types.*
*pyarrow_api.h
*pyarrow_lib.h
diff --git a/cpp/src/generated/parquet_constants.cpp
b/cpp/src/generated/parquet_constants.cpp
deleted file mode 100644
index b1b4ce6267..0000000000
--- a/cpp/src/generated/parquet_constants.cpp
+++ /dev/null
@@ -1,17 +0,0 @@
-/**
- * Autogenerated by Thrift Compiler (0.13.0)
- *
- * DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
- * @generated
- */
-#include "parquet_constants.h"
-
-namespace parquet { namespace format {
-
-const parquetConstants g_parquet_constants;
-
-parquetConstants::parquetConstants() {
-}
-
-}} // namespace
-
diff --git a/cpp/src/generated/parquet_constants.h
b/cpp/src/generated/parquet_constants.h
deleted file mode 100644
index 1e288c7cd1..0000000000
--- a/cpp/src/generated/parquet_constants.h
+++ /dev/null
@@ -1,24 +0,0 @@
-/**
- * Autogenerated by Thrift Compiler (0.13.0)
- *
- * DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
- * @generated
- */
-#ifndef parquet_CONSTANTS_H
-#define parquet_CONSTANTS_H
-
-#include "parquet_types.h"
-
-namespace parquet { namespace format {
-
-class parquetConstants {
- public:
- parquetConstants();
-
-};
-
-extern const parquetConstants g_parquet_constants;
-
-}} // namespace
-
-#endif
diff --git a/cpp/src/parquet/CMakeLists.txt b/cpp/src/parquet/CMakeLists.txt
index e43a254fb6..9c28b749e4 100644
--- a/cpp/src/parquet/CMakeLists.txt
+++ b/cpp/src/parquet/CMakeLists.txt
@@ -140,8 +140,6 @@ set(PARQUET_THRIFT_SOURCE_DIR
"${ARROW_SOURCE_DIR}/src/generated/")
set_source_files_properties("${PARQUET_THRIFT_SOURCE_DIR}/parquet_types.cpp"
"${PARQUET_THRIFT_SOURCE_DIR}/parquet_types.h"
-
"${PARQUET_THRIFT_SOURCE_DIR}/parquet_constants.cpp"
- "${PARQUET_THRIFT_SOURCE_DIR}/parquet_constants.h"
PROPERTIES SKIP_PRECOMPILE_HEADERS ON
SKIP_UNITY_BUILD_INCLUSION ON)
@@ -178,7 +176,6 @@ set(PARQUET_SRCS
metadata.cc
xxhasher.cc
page_index.cc
- "${PARQUET_THRIFT_SOURCE_DIR}/parquet_constants.cpp"
"${PARQUET_THRIFT_SOURCE_DIR}/parquet_types.cpp"
platform.cc
printer.cc
@@ -307,7 +304,6 @@ add_arrow_lib(parquet
if(WIN32 AND NOT (ARROW_TEST_LINKAGE STREQUAL "static"))
add_library(parquet_test_support STATIC
- "${PARQUET_THRIFT_SOURCE_DIR}/parquet_constants.cpp"
"${PARQUET_THRIFT_SOURCE_DIR}/parquet_types.cpp")
target_link_libraries(parquet_test_support thrift::thrift)
list(PREPEND PARQUET_TEST_LINK_LIBS parquet_test_support)
diff --git a/dev/release/rat_exclude_files.txt
b/dev/release/rat_exclude_files.txt
index dda1d36dc1..5057667eb9 100644
--- a/dev/release/rat_exclude_files.txt
+++ b/dev/release/rat_exclude_files.txt
@@ -25,8 +25,6 @@ cpp/build-support/iwyu/*
cpp/cmake_modules/FindPythonLibsNew.cmake
cpp/examples/parquet/parquet-arrow/cmake_modules/FindArrow.cmake
cpp/src/parquet/.parquetcppversion
-cpp/src/generated/parquet_constants.cpp
-cpp/src/generated/parquet_constants.h
cpp/src/generated/parquet_types.cpp
cpp/src/generated/parquet_types.h
cpp/src/generated/substrait/*
