This is an automated email from the ASF dual-hosted git repository.
zeroshade pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-go.git
The following commit(s) were added to refs/heads/main by this push:
new e112ad0 ci: update pkg-config to pkgconf on Homebrew (#198)
e112ad0 is described below
commit e112ad0de5ca66133256f2db71bda4dd2d1731f5
Author: Matt Topol <[email protected]>
AuthorDate: Fri Nov 22 16:47:16 2024 -0500
ci: update pkg-config to pkgconf on Homebrew (#198)
See https://github.com/apache/arrow/pull/44798
Fixing the CI for macOS by switching to pkgconf from deprecated
pkg-config for Homebrew
---
.github/workflows/test.yml | 4 ++--
ci/scripts/test.sh | 5 +++++
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 65f536c..04c317f 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -239,8 +239,8 @@ jobs:
go-version: ${{ matrix.go }}
cache: true
cache-dependency-path: go.sum
- - name: Brew Install Arrow and pkg-config
- run: brew install apache-arrow pkg-config
+ - name: Brew Install Arrow
+ run: brew install apache-arrow
- name: Setup PKG_CONFIG_PATH
run: |
echo "PKG_CONFIG_PATH=$(brew --prefix
openssl@3)/lib/pkgconfig:$PKG_CONFIG_PATH" >> $GITHUB_ENV
diff --git a/ci/scripts/test.sh b/ci/scripts/test.sh
index 9607e30..25b236c 100755
--- a/ci/scripts/test.sh
+++ b/ci/scripts/test.sh
@@ -50,6 +50,11 @@ if [[ -n "${ARROW_GO_TESTCGO}" ]]; then
if [[ "${MSYSTEM:-}" = "MINGW64" ]]; then
export PATH=${MINGW_PREFIX}\\bin:${MINGW_PREFIX}\\lib:$PATH
fi
+
+ if [[ "$(go env GOOS)" = "darwin" ]]; then
+ # see https://github.com/golang/go/issues/61229#issuecomment-1988965927
+ test_args+=("-ldflags=-extldflags=-Wl,-ld_classic")
+ fi
tags+=",ccalloc"
fi
