jorisvandenbossche commented on PR #559: URL: https://github.com/apache/arrow-site/pull/559#issuecomment-2499043222
The clear issues I listed on that older PR indeed all look fine, and in general the website looks good from a quick test. BTW, I find it quite bad from dependabot that they do open PRs like this that "look" like an innocent version update that you want to merge just to ensure you stay on the latest patch version to get the latest security fixes, while for bootstrap it is know that their major versions are actually quite breaking .. (https://getbootstrap.com/docs/5.0/migration/) We don't use that much of custom css or styling, so I think in our case it's mostly OK. Looking at the migration guide, I noticed one small example: "Renamed `.ml-*` and `.mr-*` to `.ms-*` and `.me-*`." (this impacts eg the alignment of the hamburger menu on mobile, which is now right instead of at the left, so not a big deal but we should still update our css classes for bootstrap 5 at some point) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
