This is an automated email from the ASF dual-hosted git repository.
lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git
The following commit(s) were added to refs/heads/main by this push:
new 196522bb2 ci: make sure bash has pipefail (#2423)
196522bb2 is described below
commit 196522bb2f11665c7b6e0d1ed98da174315a19d9
Author: David Li <[email protected]>
AuthorDate: Tue Jan 7 05:11:03 2025 -0500
ci: make sure bash has pipefail (#2423)
Continuation of #2421.
---
.github/workflows/csharp.yml | 5 +++
.github/workflows/dev.yml | 5 +++
.github/workflows/dev_pr.yml | 5 +++
.github/workflows/integration.yml | 32 ++------------
.github/workflows/java.yml | 5 ++-
.github/workflows/native-unix.yml | 55 ++-----------------------
.github/workflows/native-windows.yml | 22 ++--------
.github/workflows/nightly-verify.yml | 12 +++---
.github/workflows/nightly-website.yml | 7 +++-
.github/workflows/packaging.yml | 4 +-
.github/workflows/verify.yml | 8 ++--
go/adbc/driver/flightsql/flightsql_adbc_test.go | 8 ++++
12 files changed, 56 insertions(+), 112 deletions(-)
diff --git a/.github/workflows/csharp.yml b/.github/workflows/csharp.yml
index 08d62e7a3..b4a5fc54b 100644
--- a/.github/workflows/csharp.yml
+++ b/.github/workflows/csharp.yml
@@ -36,6 +36,11 @@ concurrency:
permissions:
contents: read
+defaults:
+ run:
+ # 'bash' will expand to -eo pipefail
+ shell: bash
+
jobs:
csharp:
name: "C# ${{ matrix.os }} ${{ matrix.dotnet }}"
diff --git a/.github/workflows/dev.yml b/.github/workflows/dev.yml
index 88bcf119c..d89cfdbef 100644
--- a/.github/workflows/dev.yml
+++ b/.github/workflows/dev.yml
@@ -28,6 +28,11 @@ concurrency:
permissions:
contents: read
+defaults:
+ run:
+ # 'bash' will expand to -eo pipefail
+ shell: bash
+
jobs:
pre-commit:
name: "pre-commit"
diff --git a/.github/workflows/dev_pr.yml b/.github/workflows/dev_pr.yml
index fec7499d7..2beba3120 100644
--- a/.github/workflows/dev_pr.yml
+++ b/.github/workflows/dev_pr.yml
@@ -31,6 +31,11 @@ permissions:
issues: write
pull-requests: write
+defaults:
+ run:
+ # 'bash' will expand to -eo pipefail
+ shell: bash
+
jobs:
process:
name: Process
diff --git a/.github/workflows/integration.yml
b/.github/workflows/integration.yml
index e09a64413..07ecd2e94 100644
--- a/.github/workflows/integration.yml
+++ b/.github/workflows/integration.yml
@@ -46,6 +46,10 @@ env:
# Increment this to reset cache manually
CACHE_NUMBER: "0"
+defaults:
+ run:
+ shell: bash -l -eo pipefail {0}
+
jobs:
duckdb:
name: "DuckDB Integration Tests"
@@ -57,7 +61,6 @@ jobs:
persist-credentials: false
- name: Get Date
id: get-date
- shell: bash
run: |
echo "today=$(/bin/date -u '+%Y%m%d')" >> $GITHUB_OUTPUT
- name: Cache Conda
@@ -71,16 +74,13 @@ jobs:
use-only-tar-bz2: false
use-mamba: true
- name: Install Dependencies
- shell: bash -l {0}
run: |
mamba install -c conda-forge \
--file ci/conda_env_cpp.txt
- name: Work around ASAN issue (GH-1617)
- shell: bash -l {0}
run: |
sudo sysctl vm.mmap_rnd_bits=28
- name: Build DuckDB Integration Tests
- shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_MANAGER: "1"
@@ -92,7 +92,6 @@ jobs:
run: |
./ci/scripts/cpp_build.sh "$(pwd)" "$(pwd)/build"
- name: Run DuckDB Integration Tests
- shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_INTEGRATION_DUCKDB: "1"
@@ -112,7 +111,6 @@ jobs:
(. .env && echo "GO_VERSION=${GO}") >> $GITHUB_ENV
- name: Get Date
id: get-date
- shell: bash
run: |
echo "today=$(/bin/date -u '+%Y%m%d')" >> $GITHUB_OUTPUT
- name: Cache Conda
@@ -126,7 +124,6 @@ jobs:
use-only-tar-bz2: false
use-mamba: true
- name: Install Dependencies
- shell: bash -l {0}
run: |
mamba install -c conda-forge \
--file ci/conda_env_cpp.txt \
@@ -139,18 +136,15 @@ jobs:
cache: true
cache-dependency-path: go/adbc/go.sum
- name: Work around ASAN issue (GH-1617)
- shell: bash -l {0}
run: |
sudo sysctl vm.mmap_rnd_bits=28
- name: Start SQLite server and Dremio
- shell: bash -l {0}
run: |
docker compose up --detach flightsql-test flightsql-sqlite-test
dremio dremio-init
pip install python-dotenv[cli]
python -m dotenv -f .env list --format simple | tee -a $GITHUB_ENV
- name: Build FlightSQL Driver
- shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_FLIGHTSQL: "1"
@@ -159,7 +153,6 @@ jobs:
./ci/scripts/cpp_build.sh "$(pwd)" "$(pwd)/build"
./ci/scripts/python_build.sh "$(pwd)" "$(pwd)/build"
- name: Test FlightSQL Driver against Dremio and SQLite
- shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_FLIGHTSQL: "1"
@@ -167,7 +160,6 @@ jobs:
./ci/scripts/cpp_build.sh "$(pwd)" "$(pwd)/build"
./ci/scripts/cpp_test.sh "$(pwd)/build"
- name: Test Python Flight SQL driver against Dremio
- shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_FLIGHTSQL: "1"
@@ -175,7 +167,6 @@ jobs:
run: |
./ci/scripts/python_test.sh "$(pwd)" "$(pwd)/build"
- name: Stop SQLite server and Dremio
- shell: bash -l {0}
run: |
docker compose down
@@ -189,7 +180,6 @@ jobs:
persist-credentials: false
- name: Get Date
id: get-date
- shell: bash
run: |
echo "today=$(/bin/date -u '+%Y%m%d')" >> $GITHUB_OUTPUT
- name: Cache Conda
@@ -203,18 +193,15 @@ jobs:
use-only-tar-bz2: false
use-mamba: true
- name: Install Dependencies
- shell: bash -l {0}
run: |
mamba install -c conda-forge \
--file ci/conda_env_cpp.txt \
--file ci/conda_env_python.txt
pip install pytest-error-for-skips
- name: Work around ASAN issue (GH-1617)
- shell: bash -l {0}
run: |
sudo sysctl vm.mmap_rnd_bits=28
- name: Build PostgreSQL Driver
- shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_MANAGER: "1"
@@ -223,7 +210,6 @@ jobs:
./ci/scripts/cpp_build.sh "$(pwd)" "$(pwd)/build"
./ci/scripts/python_build.sh "$(pwd)" "$(pwd)/build"
- name: Configure Integration Env Vars
- shell: bash -l {0}
run: |
pip install python-dotenv[cli]
python -m dotenv -f .env list --format simple | tee -a $GITHUB_ENV
@@ -231,7 +217,6 @@ jobs:
echo "ADBC_USE_UBSAN=ON" >> $GITHUB_ENV
- name: Test PostgreSQL Driver - postgres 13
- shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_POSTGRESQL: "1"
@@ -242,7 +227,6 @@ jobs:
./ci/scripts/python_test.sh "$(pwd)" "$(pwd)/build"
docker compose down
- name: Test PostgreSQL Driver - postgres 14
- shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_POSTGRESQL: "1"
@@ -253,7 +237,6 @@ jobs:
./ci/scripts/python_test.sh "$(pwd)" "$(pwd)/build"
docker compose down
- name: Test PostgreSQL Driver - postgres 15
- shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_POSTGRESQL: "1"
@@ -264,7 +247,6 @@ jobs:
./ci/scripts/python_test.sh "$(pwd)" "$(pwd)/build"
docker compose down
- name: Test PostgreSQL Driver - postgres 16
- shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_POSTGRESQL: "1"
@@ -275,7 +257,6 @@ jobs:
./ci/scripts/python_test.sh "$(pwd)" "$(pwd)/build"
docker compose down
- name: Test PostgreSQL Driver - postgres 17
- shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_POSTGRESQL: "1"
@@ -299,7 +280,6 @@ jobs:
(. .env && echo "GO_VERSION=${GO}") >> $GITHUB_ENV
- name: Get Date
id: get-date
- shell: bash
run: |
echo "today=$(/bin/date -u '+%Y%m%d')" >> $GITHUB_OUTPUT
- name: Cache Conda
@@ -313,13 +293,11 @@ jobs:
use-only-tar-bz2: false
use-mamba: true
- name: Install Dependencies
- shell: bash -l {0}
run: |
mamba install -c conda-forge \
--file ci/conda_env_cpp.txt \
--file ci/conda_env_python.txt
- name: Work around ASAN issue (GH-1617)
- shell: bash -l {0}
run: |
sudo sysctl vm.mmap_rnd_bits=28
- uses: actions/setup-go@v5
@@ -329,7 +307,6 @@ jobs:
cache: true
cache-dependency-path: go/adbc/go.sum
- name: Build and Test Snowflake Driver
- shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_SNOWFLAKE: "1"
@@ -338,7 +315,6 @@ jobs:
./ci/scripts/cpp_build.sh "$(pwd)" "$(pwd)/build"
./ci/scripts/cpp_test.sh "$(pwd)/build"
- name: Build and Test Snowflake Driver (Python)
- shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_MANAGER: "1"
diff --git a/.github/workflows/java.yml b/.github/workflows/java.yml
index e2457f29c..de7d037cf 100644
--- a/.github/workflows/java.yml
+++ b/.github/workflows/java.yml
@@ -36,6 +36,10 @@ concurrency:
permissions:
contents: read
+defaults:
+ run:
+ shell: bash -l -eo pipefail {0}
+
jobs:
java:
name: "Java ${{ matrix.java }}/Linux"
@@ -55,7 +59,6 @@ jobs:
distribution: "temurin"
java-version: ${{ matrix.java }}
- name: Start test services
- shell: bash -l {0}
run: |
docker compose up --detach --wait flightsql-sqlite-test mssql-test
postgres-test
cat .env | grep -v -e '^#' | awk NF | tee -a $GITHUB_ENV
diff --git a/.github/workflows/native-unix.yml
b/.github/workflows/native-unix.yml
index fa471e7d1..53bd7905b 100644
--- a/.github/workflows/native-unix.yml
+++ b/.github/workflows/native-unix.yml
@@ -49,6 +49,10 @@ concurrency:
permissions:
contents: read
+defaults:
+ run:
+ shell: bash -l -eo pipefail {0}
+
env:
# Increment this to reset cache manually
CACHE_NUMBER: "1"
@@ -84,7 +88,6 @@ jobs:
(. .env && echo "GO_VERSION=${GO}") >> $GITHUB_ENV
- name: Get Date
id: get-date
- shell: bash
run: |
echo "today=$(/bin/date -u '+%Y%m%d')" >> $GITHUB_OUTPUT
- name: Cache Conda
@@ -98,7 +101,6 @@ jobs:
use-only-tar-bz2: false
use-mamba: true
- name: Install Dependencies
- shell: bash -l {0}
run: |
mamba install -c conda-forge \
--file ci/conda_env_cpp.txt
@@ -110,7 +112,6 @@ jobs:
cache-dependency-path: go/adbc/go.sum
- name: Build and Install (No ASan)
- shell: bash -l {0}
run: |
# Python and others need something that don't use the ASAN runtime
rm -rf "$(pwd)/build"
@@ -122,7 +123,6 @@ jobs:
export ADBC_CMAKE_ARGS="-DCMAKE_UNITY_BUILD=ON"
./ci/scripts/cpp_build.sh "$(pwd)" "$(pwd)/build" "$HOME/local"
- name: Go Build
- shell: bash -l {0}
env:
CGO_ENABLED: "1"
run: |
@@ -135,7 +135,6 @@ jobs:
# https://github.com/actions/download-artifact/issues/346
- name: tar artifacts
- shell: bash -l {0}
run: |
cd
tar czf ~/local.tgz local
@@ -167,7 +166,6 @@ jobs:
persist-credentials: false
- name: Get Date
id: get-date
- shell: bash
run: |
echo "today=$(/bin/date -u '+%Y%m%d')" >> $GITHUB_OUTPUT
- name: Cache Conda
@@ -181,18 +179,15 @@ jobs:
use-only-tar-bz2: false
use-mamba: true
- name: Install Dependencies
- shell: bash -l {0}
run: |
mamba install -c conda-forge \
--file ci/conda_env_cpp.txt
- name: Work around ASAN issue (GH-1617)
- shell: bash -l {0}
if: matrix.os == 'ubuntu-latest'
run: |
sudo sysctl vm.mmap_rnd_bits=28
- name: Build
- shell: bash -l {0}
env:
ADBC_CMAKE_ARGS: "-DCMAKE_UNITY_BUILD=ON"
BUILD_ALL: "0"
@@ -202,7 +197,6 @@ jobs:
run: |
./ci/scripts/cpp_build.sh "$(pwd)" "$(pwd)/build"
- name: Test
- shell: bash -l {0}
env:
BUILD_ALL: "0"
BUILD_DRIVER_MANAGER: "1"
@@ -244,7 +238,6 @@ jobs:
- name: Install Meson via Python
run: pip install meson
- name: Start SQLite server, Dremio, and postgresql
- shell: bash -l {0}
run: |
env POSTSGRES_VERSION=16 docker compose up --detach --wait \
dremio \
@@ -270,7 +263,6 @@ jobs:
run: |
meson test -C c/build --print-errorlogs
- name: Stop SQLite server, Dremio, and postgresql
- shell: bash -l {0}
run: |
docker compose down
@@ -284,7 +276,6 @@ jobs:
persist-credentials: false
- name: Get Date
id: get-date
- shell: bash
run: |
echo "today=$(/bin/date -u '+%Y%m%d')" >> $GITHUB_OUTPUT
- name: Cache Conda
@@ -298,14 +289,12 @@ jobs:
use-only-tar-bz2: false
use-mamba: true
- name: Install Dependencies
- shell: bash -l {0}
run: |
mamba install -c conda-forge \
--file ci/conda_env_cpp.txt \
--file ci/conda_env_cpp_lint.txt
- name: clang-tidy
- shell: bash -l {0}
run: |
./ci/scripts/cpp_clang_tidy.sh "$(pwd)" "$(pwd)/build"
@@ -333,7 +322,6 @@ jobs:
persist-credentials: false
- name: Get Date
id: get-date
- shell: bash
run: |
echo "today=$(/bin/date -u '+%Y%m%d')" >> $GITHUB_OUTPUT
- name: Cache Conda
@@ -347,14 +335,12 @@ jobs:
use-only-tar-bz2: false
use-mamba: true
- name: Install Dependencies
- shell: bash -l {0}
run: |
mamba install -c conda-forge \
'arrow-c-glib>=10.0.1' \
--file ci/conda_env_cpp.txt \
--file ci/conda_env_glib.txt
- name: Work around ASAN issue (GH-1617)
- shell: bash -l {0}
if: matrix.os == 'ubuntu-latest'
run: |
sudo sysctl vm.mmap_rnd_bits=28
@@ -365,17 +351,14 @@ jobs:
path: "~"
- name: untar artifacts
- shell: bash -l {0}
run: |
cd
tar xvf ~/local.tgz
- name: Build GLib Driver Manager
- shell: bash -l {0}
run: |
env BUILD_ALL=0 BUILD_DRIVER_MANAGER=1 ./ci/scripts/glib_build.sh
"$(pwd)" "$(pwd)/build" "$HOME/local"
- name: Test GLib/Ruby Driver Manager
- shell: bash -l {0}
run: |
env BUILD_ALL=0 BUILD_DRIVER_MANAGER=1 ./ci/scripts/glib_test.sh
"$(pwd)" "$(pwd)/build" "$HOME/local"
@@ -420,7 +403,6 @@ jobs:
cache: true
cache-dependency-path: go/adbc/go.sum
- name: Work around ASAN issue (GH-1617)
- shell: bash -l {0}
if: matrix.os == 'ubuntu-latest'
run: |
sudo sysctl vm.mmap_rnd_bits=28
@@ -476,7 +458,6 @@ jobs:
(. .env && echo "GO_VERSION=${GO}") >> $GITHUB_ENV
- name: Get Date
id: get-date
- shell: bash
run: |
echo "today=$(/bin/date -u '+%Y%m%d')" >> $GITHUB_OUTPUT
- name: Cache Conda
@@ -490,13 +471,11 @@ jobs:
use-only-tar-bz2: false
use-mamba: true
- name: Work around ASAN issue (GH-1617)
- shell: bash -l {0}
if: matrix.os == 'ubuntu-latest'
run: |
sudo sysctl vm.mmap_rnd_bits=28
- name: Install Dependencies
- shell: bash -l {0}
run: |
mamba install -c conda-forge \
--file ci/conda_env_cpp.txt
@@ -507,7 +486,6 @@ jobs:
cache: true
cache-dependency-path: go/adbc/go.sum
- name: Install staticcheck
- shell: bash -l {0}
if: matrix.os == 'ubuntu-latest'
run: go install honnef.co/go/tools/cmd/staticcheck@latest
@@ -517,25 +495,21 @@ jobs:
path: "~"
- name: untar artifacts
- shell: bash -l {0}
run: |
cd
tar xvf ~/local.tgz
- name: Go Build
- shell: bash -l {0}
run: |
export PATH=$RUNNER_TOOL_CACHE/go/${GO_VERSION}/${{ matrix.goarch
}}/bin:$PATH
./ci/scripts/go_build.sh "$(pwd)" "$(pwd)/build" "$HOME/local"
- name: Run Staticcheck
if: matrix.os == 'ubuntu-latest'
- shell: bash -l {0}
run: |
pushd go/adbc
staticcheck -f stylish ./...
popd
- name: Go Test
- shell: bash -l {0}
env:
SNOWFLAKE_URI: ${{ secrets.SNOWFLAKE_URI }}
run: |
@@ -568,7 +542,6 @@ jobs:
(. .env && echo "GO_VERSION=${GO}") >> $GITHUB_ENV
- name: Get Date
id: get-date
- shell: bash
run: |
echo "today=$(/bin/date -u '+%Y%m%d')" >> $GITHUB_OUTPUT
- name: Cache Conda
@@ -582,14 +555,12 @@ jobs:
use-only-tar-bz2: false
use-mamba: true
- name: Install Dependencies
- shell: bash -l {0}
run: |
mamba install -c conda-forge \
python=${{ matrix.python }} \
--file ci/conda_env_cpp.txt \
--file ci/conda_env_python.txt
- name: Work around ASAN issue (GH-1617)
- shell: bash -l {0}
if: matrix.os == 'ubuntu-latest'
run: |
sudo sysctl vm.mmap_rnd_bits=28
@@ -606,13 +577,11 @@ jobs:
path: "~"
- name: untar artifacts
- shell: bash -l {0}
run: |
cd
tar xvf ~/local.tgz
- name: Build
- shell: bash -l {0}
env:
BUILD_ALL: "1"
ADBC_USE_ASAN: "0"
@@ -621,7 +590,6 @@ jobs:
export PATH=$RUNNER_TOOL_CACHE/go/${GO_VERSION}/x64/bin:$PATH
./ci/scripts/python_build.sh "$(pwd)" "$(pwd)/build" "$HOME/local"
- name: Build Panic Dummy
- shell: bash -l {0}
run: |
export PATH=$RUNNER_TOOL_CACHE/go/${GO_VERSION}/x64/bin:$PATH
if [[ $(uname) = "Darwin" ]]; then
@@ -630,7 +598,6 @@ jobs:
make -C ./go/adbc/pkg libadbc_driver_panicdummy.so
fi
- name: Test Python Driver Manager
- shell: bash -l {0}
run: |
if [[ $(uname) = "Darwin" ]]; then
export
PANICDUMMY_LIBRARY_PATH=$(pwd)/go/adbc/pkg/libadbc_driver_panicdummy.dylib
@@ -640,7 +607,6 @@ jobs:
export PATH=$RUNNER_TOOL_CACHE/go/${GO_VERSION}/x64/bin:$PATH
env BUILD_ALL=0 BUILD_DRIVER_MANAGER=1 ./ci/scripts/python_test.sh
"$(pwd)" "$(pwd)/build" "$HOME/local"
- name: Test Python Driver Flight SQL
- shell: bash -l {0}
run: |
export PATH=$RUNNER_TOOL_CACHE/go/${GO_VERSION}/x64/bin:$PATH
# Can't use Docker on macOS
@@ -658,19 +624,15 @@ jobs:
env BUILD_ALL=0 BUILD_DRIVER_FLIGHTSQL=1 ./ci/scripts/python_test.sh
"$(pwd)" "$(pwd)/build" "$HOME/local"
kill %1
- name: Test Python Driver PostgreSQL
- shell: bash -l {0}
run: |
env BUILD_ALL=0 BUILD_DRIVER_POSTGRESQL=1
./ci/scripts/python_test.sh "$(pwd)" "$(pwd)/build" "$HOME/local"
- name: Test Python Driver SQLite
- shell: bash -l {0}
run: |
env BUILD_ALL=0 BUILD_DRIVER_SQLITE=1 ./ci/scripts/python_test.sh
"$(pwd)" "$(pwd)/build" "$HOME/local"
- name: Test Python Driver Snowflake
- shell: bash -l {0}
run: |
env BUILD_ALL=0 BUILD_DRIVER_SNOWFLAKE=1 ./ci/scripts/python_test.sh
"$(pwd)" "$(pwd)/build" "$HOME/local"
- name: Typecheck Python
- shell: bash -l {0}
run: |
./ci/scripts/python_typecheck.sh "$(pwd)"
@@ -690,7 +652,6 @@ jobs:
persist-credentials: false
- name: Get Date
id: get-date
- shell: bash
run: |
echo "today=$(/bin/date -u '+%Y%m%d')" >> $GITHUB_OUTPUT
- name: Cache Conda
@@ -704,14 +665,12 @@ jobs:
use-only-tar-bz2: false
use-mamba: true
- name: Install Dependencies
- shell: bash -l {0}
run: |
mamba install -c conda-forge \
python=${{ matrix.python }} \
--file ci/conda_env_docs.txt \
--file ci/conda_env_python.txt
- name: Work around ASAN issue (GH-1617)
- shell: bash -l {0}
if: matrix.os == 'ubuntu-latest'
run: |
sudo sysctl vm.mmap_rnd_bits=28
@@ -722,13 +681,11 @@ jobs:
path: "~"
- name: untar artifacts
- shell: bash -l {0}
run: |
cd
tar xvf ~/local.tgz
- name: Build Python
- shell: bash -l {0}
env:
BUILD_ALL: "1"
ADBC_USE_ASAN: "0"
@@ -737,7 +694,6 @@ jobs:
./ci/scripts/python_build.sh "$(pwd)" "$(pwd)/build" "$HOME/local"
# Docs requires Python packages since it runs doctests
- name: Build Docs
- shell: bash -l {0}
run: |
./ci/scripts/docs_build.sh "$(pwd)"
- name: Archive docs
@@ -748,16 +704,13 @@ jobs:
path: |
docs/build/html
- name: Configure Integration Env Vars
- shell: bash -l {0}
run: |
pip install python-dotenv[cli]
python -m dotenv -f .env list --format simple | tee -a $GITHUB_ENV
- name: Test Recipes (C++)
- shell: bash -l {0}
run: |
./ci/scripts/cpp_recipe.sh $(pwd) ~/local build/recipe
- name: Test Recipes (Python)
- shell: bash -l {0}
run: |
docker compose up --detach --wait dremio dremio-init
flightsql-sqlite-test postgres-test
pytest -vvs docs/source/tests/
diff --git a/.github/workflows/native-windows.yml
b/.github/workflows/native-windows.yml
index 9fb3caf22..6f02d327a 100644
--- a/.github/workflows/native-windows.yml
+++ b/.github/workflows/native-windows.yml
@@ -47,6 +47,10 @@ concurrency:
permissions:
contents: read
+defaults:
+ run:
+ shell: pwsh
+
jobs:
# ------------------------------------------------------------
# Common build (builds libraries used in GLib, Python, Ruby)
@@ -80,7 +84,6 @@ jobs:
miniforge-version: latest
use-mamba: true
- name: Install Dependencies
- shell: pwsh
run: |
mamba install -c conda-forge `
--file ci\conda_env_cpp.txt
@@ -88,7 +91,6 @@ jobs:
mamba uninstall gtest
- name: Build and Install (No ASan)
- shell: pwsh
env:
BUILD_ALL: "1"
# TODO(apache/arrow-adbc#634)
@@ -137,7 +139,6 @@ jobs:
miniforge-version: latest
use-mamba: true
- name: Install Dependencies
- shell: pwsh
run: |
mamba install -c conda-forge `
--file ci\conda_env_cpp.txt
@@ -145,31 +146,26 @@ jobs:
mamba uninstall gtest
- name: Build Driver Manager
- shell: pwsh
env:
BUILD_ALL: "0"
BUILD_DRIVER_MANAGER: "1"
run: .\ci\scripts\cpp_build.ps1 $pwd $pwd\build
- name: Build Driver PostgreSQL
- shell: pwsh
env:
BUILD_ALL: "0"
BUILD_DRIVER_POSTGRESQL: "1"
run: .\ci\scripts\cpp_build.ps1 $pwd $pwd\build
- name: Build Driver SQLite
- shell: pwsh
env:
BUILD_ALL: "0"
BUILD_DRIVER_SQLITE: "1"
run: .\ci\scripts\cpp_build.ps1 $pwd $pwd\build
- name: Test Driver Manager
- shell: pwsh
env:
BUILD_ALL: "0"
BUILD_DRIVER_MANAGER: "1"
run: .\ci\scripts\cpp_test.ps1 $pwd\build
- name: Test Driver SQLite
- shell: pwsh
env:
BUILD_ALL: "0"
BUILD_DRIVER_SQLITE: "1"
@@ -213,7 +209,6 @@ jobs:
miniforge-version: latest
use-mamba: true
- name: Install Dependencies
- shell: pwsh
run: |
mamba install -c conda-forge `
--file ci\conda_env_cpp.txt
@@ -230,7 +225,6 @@ jobs:
path: ${{ github.workspace }}/build
- name: Go Build
- shell: pwsh
env:
CGO_ENABLED: "1"
run: |
@@ -238,7 +232,6 @@ jobs:
.\ci\scripts\go_build.ps1 $pwd $pwd\build
# TODO(apache/arrow#358): enable these tests on Windows
# - name: Go Test
- # shell: pwsh
# env:
# CGO_ENABLED: "1"
# run: |
@@ -280,7 +273,6 @@ jobs:
miniforge-version: latest
use-mamba: true
- name: Install Dependencies
- shell: pwsh
run: |
mamba install -c conda-forge `
python=${{ matrix.python }} `
@@ -293,37 +285,31 @@ jobs:
path: ${{ github.workspace }}/build
- name: Build Python Driver Manager
- shell: pwsh
env:
BUILD_ALL: "0"
BUILD_DRIVER_MANAGER: "1"
run: .\ci\scripts\python_build.ps1 $pwd $pwd\build
- name: Build Python Driver PostgreSQL
- shell: pwsh
env:
BUILD_ALL: "0"
BUILD_DRIVER_POSTGRESQL: "1"
run: .\ci\scripts\python_build.ps1 $pwd $pwd\build
- name: Build Python Driver SQLite
- shell: pwsh
env:
BUILD_ALL: "0"
BUILD_DRIVER_SQLITE: "1"
run: .\ci\scripts\python_build.ps1 $pwd $pwd\build
- name: Test Python Driver Manager
- shell: pwsh
env:
BUILD_ALL: "0"
BUILD_DRIVER_MANAGER: "1"
run: .\ci\scripts\python_test.ps1 $pwd $pwd\build
- name: Test Python Driver PostgreSQL
- shell: pwsh
env:
BUILD_ALL: "0"
BUILD_DRIVER_POSTGRESQL: "1"
run: .\ci\scripts\python_test.ps1 $pwd $pwd\build
- name: Test Python Driver SQLite
- shell: pwsh
env:
BUILD_ALL: "0"
BUILD_DRIVER_SQLITE: "1"
diff --git a/.github/workflows/nightly-verify.yml
b/.github/workflows/nightly-verify.yml
index ae6d7f87d..3d27ef164 100644
--- a/.github/workflows/nightly-verify.yml
+++ b/.github/workflows/nightly-verify.yml
@@ -32,6 +32,11 @@ on:
permissions:
contents: read
+defaults:
+ run:
+ # 'bash' will expand to -eo pipefail
+ shell: bash
+
jobs:
source:
# For cron: only run on the main repo, not forks
@@ -45,14 +50,12 @@ jobs:
submodules: recursive
- name: Prepare version
- shell: bash
run: |
VERSION=$(grep 'set(ADBC_VERSION' c/cmake_modules/AdbcVersion.cmake
| \
grep -E -o '[0-9]+\.[0-9]+\.[0-9]+')
echo "VERSION=${VERSION}" >> $GITHUB_ENV
- name: Create archive
- shell: bash
run: |
git config --global user.name 'github-actions[bot]'
git config --global user.email
'github-actions[bot]@users.noreply.github.com'
@@ -64,7 +67,6 @@ jobs:
apache-arrow-adbc-${VERSION}-rc0
- name: Create fake GPG key
- shell: bash
run: |
gpg \
--quick-gen-key \
@@ -80,7 +82,6 @@ jobs:
--export >> KEYS
- name: Create sum/signature
- shell: bash
run: |
gpg \
--armor \
@@ -118,7 +119,6 @@ jobs:
persist-credentials: false
- name: Prepare version
- shell: bash
run: |
VERSION=$(grep 'set(ADBC_VERSION'
arrow-adbc/c/cmake_modules/AdbcVersion.cmake | \
grep -E -o '[0-9]+\.[0-9]+\.[0-9]+')
@@ -130,7 +130,6 @@ jobs:
path: ${{ github.workspace }}/apache-arrow-adbc-${{ env.VERSION
}}-rc0/
- name: Setup directory structure
- shell: bash
run: |
mv apache-arrow-adbc-${{ env.VERSION }}-rc0/KEYS .
@@ -142,7 +141,6 @@ jobs:
use-mamba: true
- name: Work around ASAN issue (GH-1617)
- shell: bash -l {0}
if: matrix.os == 'ubuntu-latest'
run: |
sudo sysctl vm.mmap_rnd_bits=28
diff --git a/.github/workflows/nightly-website.yml
b/.github/workflows/nightly-website.yml
index c4a8193dd..0c6f8278d 100644
--- a/.github/workflows/nightly-website.yml
+++ b/.github/workflows/nightly-website.yml
@@ -31,6 +31,11 @@ concurrency:
group: ${{ github.repository }}-${{ github.workflow }}
cancel-in-progress: false
+defaults:
+ run:
+ # 'bash' will expand to -eo pipefail
+ shell: bash
+
jobs:
build:
name: "Build Website"
@@ -41,7 +46,6 @@ jobs:
fetch-depth: 0
persist-credentials: false
- name: Build
- shell: bash
run: |
docker compose run docs
- name: Archive docs
@@ -80,7 +84,6 @@ jobs:
with:
python-version: '3.x'
- name: Build
- shell: bash
run: |
pip install sphobjinv
./scripts/ci/scripts/website_build.sh "$(pwd)/scripts" "$(pwd)/site"
"$(pwd)/temp"
diff --git a/.github/workflows/packaging.yml b/.github/workflows/packaging.yml
index 135ee1c99..0e25a9a36 100644
--- a/.github/workflows/packaging.yml
+++ b/.github/workflows/packaging.yml
@@ -495,7 +495,7 @@ jobs:
arch: ["osx_64_"]
defaults:
run:
- shell: bash -l {0}
+ shell: bash -l -eo pipefail {0}
steps:
- uses: actions/download-artifact@v4
with:
@@ -1035,7 +1035,7 @@ jobs:
# - python-conda-macos
defaults:
run:
- shell: bash -l {0}
+ shell: bash -l -eo pipefail {0}
steps:
- uses: actions/checkout@v4
with:
diff --git a/.github/workflows/verify.yml b/.github/workflows/verify.yml
index bb546eb91..7c8230e57 100644
--- a/.github/workflows/verify.yml
+++ b/.github/workflows/verify.yml
@@ -38,6 +38,11 @@ on:
permissions:
contents: read
+defaults:
+ run:
+ # 'bash' will expand to -eo pipefail
+ shell: bash
+
jobs:
binary-unix:
name: "Verify Binaries/${{ matrix.os }}"
@@ -54,12 +59,10 @@ jobs:
# No Docker on M1
- name: Skip Binary Verifiction
if: matrix.os == 'macos-latest'
- shell: bash
run: |
echo "TEST_APT=0" | tee -a $GITHUB_ENV
echo "TEST_YUM=0" | tee -a $GITHUB_ENV
- name: Verify
- shell: bash
env:
CI: "false"
REPOSITORY: ${{ github.repository }}
@@ -91,7 +94,6 @@ jobs:
miniforge-version: latest
use-mamba: true
- name: Work around ASAN issue (GH-1617)
- shell: bash -l {0}
if: matrix.os == 'ubuntu-latest'
run: |
sudo sysctl vm.mmap_rnd_bits=28
diff --git a/go/adbc/driver/flightsql/flightsql_adbc_test.go
b/go/adbc/driver/flightsql/flightsql_adbc_test.go
index 8fda41bb5..fd91db157 100644
--- a/go/adbc/driver/flightsql/flightsql_adbc_test.go
+++ b/go/adbc/driver/flightsql/flightsql_adbc_test.go
@@ -1055,6 +1055,14 @@ type DomainSocketTests struct {
}
func (suite *DomainSocketTests) SetupSuite() {
+ // This doesn't appear to run under Windows
+ // transport: Error while dialing: dial unix
+ //
/Users/RUNNER~1/AppData/Local/Temp/adbc-flight-sql-tests-1919020904/adbc.sock:
+ // connect: A socket operation encountered a dead network.
+ if runtime.GOOS == "windows" {
+ suite.T().Skip()
+ }
+
suite.alloc = memory.NewCheckedAllocator(memory.DefaultAllocator)
tempDir, err := os.MkdirTemp("", "adbc-flight-sql-tests-*")
