This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch 53.0.0_maintenance
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
The following commit(s) were added to refs/heads/53.0.0_maintenance by this
push:
new 962c92fcd8 [53.0.0_maintenance] Fix CI (#6964)
962c92fcd8 is described below
commit 962c92fcd873895378cadcb7cbb230fd8b56ca64
Author: Andrew Lamb <[email protected]>
AuthorDate: Sun Jan 12 08:37:12 2025 -0500
[53.0.0_maintenance] Fix CI (#6964)
* Ignore some clippy lints introduced in rust 1.84
* Fix CI for Rust 1.84 release
* sprinkle more allows
---
.github/workflows/arrow.yml | 6 +++---
.github/workflows/object_store.yml | 6 +++---
.github/workflows/parquet.yml | 6 +++---
arrow-cast/src/parse.rs | 1 +
arrow-flight/src/encode.rs | 1 +
object_store/src/aws/client.rs | 1 +
object_store/src/azure/client.rs | 1 +
object_store/src/gcp/client.rs | 1 +
parquet/src/arrow/async_reader/mod.rs | 1 +
parquet/src/column/writer/mod.rs | 1 +
10 files changed, 16 insertions(+), 9 deletions(-)
diff --git a/.github/workflows/arrow.yml b/.github/workflows/arrow.yml
index d3b2526740..30ae3c52e3 100644
--- a/.github/workflows/arrow.yml
+++ b/.github/workflows/arrow.yml
@@ -146,11 +146,11 @@ jobs:
- name: Setup Rust toolchain
uses: ./.github/actions/setup-builder
with:
- target: wasm32-unknown-unknown,wasm32-wasi
+ target: wasm32-unknown-unknown,wasm32-wasip1
- name: Build wasm32-unknown-unknown
run: cargo build -p arrow --no-default-features
--features=json,csv,ipc,ffi --target wasm32-unknown-unknown
- - name: Build wasm32-wasi
- run: cargo build -p arrow --no-default-features
--features=json,csv,ipc,ffi --target wasm32-wasi
+ - name: Build wasm32-wasip1
+ run: cargo build -p arrow --no-default-features
--features=json,csv,ipc,ffi --target wasm32-wasip1
clippy:
name: Clippy
diff --git a/.github/workflows/object_store.yml
b/.github/workflows/object_store.yml
index 1857b33032..65be782e82 100644
--- a/.github/workflows/object_store.yml
+++ b/.github/workflows/object_store.yml
@@ -199,11 +199,11 @@ jobs:
- name: Setup Rust toolchain
uses: ./.github/actions/setup-builder
with:
- target: wasm32-unknown-unknown,wasm32-wasi
+ target: wasm32-unknown-unknown,wasm32-wasip1
- name: Build wasm32-unknown-unknown
run: cargo build --target wasm32-unknown-unknown
- - name: Build wasm32-wasi
- run: cargo build --target wasm32-wasi
+ - name: Build wasm32-wasip1
+ run: cargo build --target wasm32-wasip1
windows:
name: cargo test LocalFileSystem (win64)
diff --git a/.github/workflows/parquet.yml b/.github/workflows/parquet.yml
index a4e6548926..d336a7289d 100644
--- a/.github/workflows/parquet.yml
+++ b/.github/workflows/parquet.yml
@@ -123,13 +123,13 @@ jobs:
- name: Setup Rust toolchain
uses: ./.github/actions/setup-builder
with:
- target: wasm32-unknown-unknown,wasm32-wasi
+ target: wasm32-unknown-unknown,wasm32-wasip1
- name: Install clang # Needed for zlib compilation
run: apt-get update && apt-get install -y clang gcc-multilib
- name: Build wasm32-unknown-unknown
run: cargo build -p parquet --target wasm32-unknown-unknown
- - name: Build wasm32-wasi
- run: cargo build -p parquet --target wasm32-wasi
+ - name: Build wasm32-wasip1
+ run: cargo build -p parquet --target wasm32-wasip1
pyspark-integration-test:
name: PySpark Integration Test
diff --git a/arrow-cast/src/parse.rs b/arrow-cast/src/parse.rs
index f4c4639c1c..482d07d852 100644
--- a/arrow-cast/src/parse.rs
+++ b/arrow-cast/src/parse.rs
@@ -864,6 +864,7 @@ pub fn parse_decimal<T: DecimalType>(
// Overflow checks are not required if 10^(precision - 1) <= T::MAX holds.
// Thus, if we validate the precision correctly, we can skip overflow
checks.
+ #[allow(clippy::question_mark)]
while let Some((index, b)) = bs.next() {
match b {
b'0'..=b'9' => {
diff --git a/arrow-flight/src/encode.rs b/arrow-flight/src/encode.rs
index ae3475c7c7..561c26fa82 100644
--- a/arrow-flight/src/encode.rs
+++ b/arrow-flight/src/encode.rs
@@ -1798,6 +1798,7 @@ mod tests {
}
/// Return size, in memory of flight data
+ #[allow(clippy::needless_as_bytes)]
fn flight_data_size(d: &FlightData) -> usize {
let flight_descriptor_size = d
.flight_descriptor
diff --git a/object_store/src/aws/client.rs b/object_store/src/aws/client.rs
index 82348b267c..1076e3fb5c 100644
--- a/object_store/src/aws/client.rs
+++ b/object_store/src/aws/client.rs
@@ -291,6 +291,7 @@ pub(crate) struct Request<'a> {
retry_error_body: bool,
}
+#[allow(clippy::needless_lifetimes)]
impl<'a> Request<'a> {
pub(crate) fn query<T: Serialize + ?Sized + Sync>(self, query: &T) -> Self
{
let builder = self.builder.query(query);
diff --git a/object_store/src/azure/client.rs b/object_store/src/azure/client.rs
index e78f8db7a8..df8f90cbfe 100644
--- a/object_store/src/azure/client.rs
+++ b/object_store/src/azure/client.rs
@@ -170,6 +170,7 @@ struct PutRequest<'a> {
idempotent: bool,
}
+#[allow(clippy::needless_lifetimes)]
impl<'a> PutRequest<'a> {
fn header(self, k: &HeaderName, v: &str) -> Self {
let builder = self.builder.header(k, v);
diff --git a/object_store/src/gcp/client.rs b/object_store/src/gcp/client.rs
index ccc9c341f2..d80d3d625f 100644
--- a/object_store/src/gcp/client.rs
+++ b/object_store/src/gcp/client.rs
@@ -174,6 +174,7 @@ pub(crate) struct Request<'a> {
idempotent: bool,
}
+#[allow(clippy::needless_lifetimes)]
impl<'a> Request<'a> {
fn header(self, k: &HeaderName, v: &str) -> Self {
let builder = self.builder.header(k, v);
diff --git a/parquet/src/arrow/async_reader/mod.rs
b/parquet/src/arrow/async_reader/mod.rs
index 8b315cc9f7..9281a39cec 100644
--- a/parquet/src/arrow/async_reader/mod.rs
+++ b/parquet/src/arrow/async_reader/mod.rs
@@ -724,6 +724,7 @@ struct InMemoryRowGroup<'a> {
row_count: usize,
}
+#[allow(clippy::needless_lifetimes)]
impl<'a> InMemoryRowGroup<'a> {
/// Fetches the necessary column data into memory
async fn fetch<T: AsyncFileReader + Send>(
diff --git a/parquet/src/column/writer/mod.rs b/parquet/src/column/writer/mod.rs
index 9bd79840f7..f2db7d7448 100644
--- a/parquet/src/column/writer/mod.rs
+++ b/parquet/src/column/writer/mod.rs
@@ -3163,6 +3163,7 @@ mod tests {
assert_eq!(&v.unwrap(), "b\u{10ffff}".as_bytes());
}
+ #[allow(clippy::needless_as_bytes)]
#[test]
fn test_truncate_utf8() {
// No-op
