This is an automated email from the ASF dual-hosted git repository.
assignuser pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 0d61cfdb6e GH-45155: [Python][CI] Fix path for scientific nightly
windows wheel upload (#45222)
0d61cfdb6e is described below
commit 0d61cfdb6ecbc5136c0a67d459c55a2d3f87d7ba
Author: Jacob Wujciak-Jens <[email protected]>
AuthorDate: Mon Jan 13 19:47:03 2025 +0100
GH-45155: [Python][CI] Fix path for scientific nightly windows wheel upload
(#45222)
### Rationale for this change
The upload wasn't failing with the empty, non existent dir.
### What changes are included in this PR?
- Fix the path
- Prevent the upload from failing silently when no wheels are found
### Are these changes tested?
crossbow
### Are there any user-facing changes?
no
* GitHub Issue: #45155
Lead-authored-by: Jacob Wujciak-Jens <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Jacob Wujciak-Jens <[email protected]>
---
dev/tasks/macros.jinja | 6 ++++++
dev/tasks/python-wheels/github.windows.yml | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/dev/tasks/macros.jinja b/dev/tasks/macros.jinja
index dded9492f0..1c118b4c4f 100644
--- a/dev/tasks/macros.jinja
+++ b/dev/tasks/macros.jinja
@@ -186,6 +186,12 @@ env:
- name: Upload wheel to Anaconda scientific-python
shell: bash
run: |
+ # check if completion actually expands to wheel files
+ # to prevent empty dirs from failing silently
+ if ! compgen -G "{{ pattern }}" > /dev/null; then
+ echo "No wheel files found!"
+ exit 1
+ fi
python3 -m pip install
git+https://github.com/Anaconda-Platform/[email protected]
anaconda -t ${CROSSBOW_SCIENTIFIC_PYTHON_UPLOAD_TOKEN} upload --force -u
scientific-python-nightly-wheels --label main {{ pattern }}
env:
diff --git a/dev/tasks/python-wheels/github.windows.yml
b/dev/tasks/python-wheels/github.windows.yml
index 36b25e9819..2ac942d5bd 100644
--- a/dev/tasks/python-wheels/github.windows.yml
+++ b/dev/tasks/python-wheels/github.windows.yml
@@ -91,7 +91,7 @@ jobs:
{{
macros.github_upload_releases("arrow/python/repaired_wheels/*.whl")|indent }}
{{
macros.github_upload_gemfury("arrow/python/repaired_wheels/*.whl")|indent }}
- {{
macros.github_upload_wheel_scientific_python("arrow/repaired_wheels/repaired_wheels/*.whl")|indent
}}
+ {{
macros.github_upload_wheel_scientific_python("arrow/python/repaired_wheels/*.whl")|indent
}}
{% if arrow.is_default_branch() %}
- name: Push Docker image
