This is an automated email from the ASF dual-hosted git repository.
lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-java.git
The following commit(s) were added to refs/heads/main by this push:
new 3dd03115 GH-41: Add VariableWidthViewVectorBenchmarks (#453)
3dd03115 is described below
commit 3dd0311592f7ca8db615791b4f8fd3aa8dea71cb
Author: ViggoC <[email protected]>
AuthorDate: Fri Jan 24 12:08:43 2025 +0800
GH-41: Add VariableWidthViewVectorBenchmarks (#453)
GitHub Issue: https://github.com/apache/arrow-java/issues/41
---
.../VariableWidthVectorBenchmarkConstants.java | 22 +++++++++++++++++
.../vector/VariableWidthVectorBenchmarks.java | 13 ++++++----
... VariableWidthVectorInlineValueBenchmarks.java} | 17 ++++++++-----
...java => VariableWidthViewVectorBenchmarks.java} | 27 ++++++++++++---------
...iableWidthViewVectorInlineValueBenchmarks.java} | 28 +++++++++++++---------
5 files changed, 75 insertions(+), 32 deletions(-)
diff --git
a/performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarkConstants.java
b/performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarkConstants.java
new file mode 100644
index 00000000..d4ef49d9
--- /dev/null
+++
b/performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarkConstants.java
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.arrow.vector;
+
+public class VariableWidthVectorBenchmarkConstants {
+ public static final String SHORT_VALUE = "InlineValue";
+ public static final String LONG_VALUE =
VariableWidthVectorBenchmarks.class.getName();
+}
diff --git
a/performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarks.java
b/performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarks.java
index 0bce6569..17d3ac1f 100644
---
a/performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarks.java
+++
b/performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarks.java
@@ -23,8 +23,10 @@ import org.apache.arrow.memory.RootAllocator;
import org.apache.arrow.vector.holders.NullableVarCharHolder;
import org.openjdk.jmh.annotations.Benchmark;
import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Level;
import org.openjdk.jmh.annotations.Mode;
import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Param;
import org.openjdk.jmh.annotations.Scope;
import org.openjdk.jmh.annotations.Setup;
import org.openjdk.jmh.annotations.State;
@@ -45,15 +47,18 @@ public class VariableWidthVectorBenchmarks {
private static final int ALLOCATOR_CAPACITY = 1024 * 1024;
- private static byte[] bytes =
VariableWidthVectorBenchmarks.class.getName().getBytes();
+ private static byte[] bytes =
VariableWidthVectorBenchmarkConstants.LONG_VALUE.getBytes();
private ArrowBuf arrowBuff;
private BufferAllocator allocator;
private VarCharVector vector;
+ @Param({"1", "2", "10", "40"})
+ private int step;
+
/** Setup benchmarks. */
- @Setup
+ @Setup(Level.Iteration)
public void prepare() {
allocator = new RootAllocator(ALLOCATOR_CAPACITY);
vector = new VarCharVector("vector", allocator);
@@ -63,7 +68,7 @@ public class VariableWidthVectorBenchmarks {
}
/** Tear down benchmarks. */
- @TearDown
+ @TearDown(Level.Iteration)
public void tearDown() {
arrowBuff.close();
vector.close();
@@ -87,7 +92,7 @@ public class VariableWidthVectorBenchmarks {
@OutputTimeUnit(TimeUnit.MILLISECONDS)
public int setSafeFromArray() {
for (int i = 0; i < 500; ++i) {
- vector.setSafe(i * 40, bytes);
+ vector.setSafe(i * step, bytes);
}
return vector.getBufferSize();
}
diff --git
a/performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarks.java
b/performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorInlineValueBenchmarks.java
similarity index 88%
copy from
performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarks.java
copy to
performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorInlineValueBenchmarks.java
index 0bce6569..354d1b14 100644
---
a/performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarks.java
+++
b/performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorInlineValueBenchmarks.java
@@ -23,8 +23,10 @@ import org.apache.arrow.memory.RootAllocator;
import org.apache.arrow.vector.holders.NullableVarCharHolder;
import org.openjdk.jmh.annotations.Benchmark;
import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Level;
import org.openjdk.jmh.annotations.Mode;
import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Param;
import org.openjdk.jmh.annotations.Scope;
import org.openjdk.jmh.annotations.Setup;
import org.openjdk.jmh.annotations.State;
@@ -36,7 +38,7 @@ import org.openjdk.jmh.runner.options.OptionsBuilder;
/** Benchmarks for {@link BaseVariableWidthVector}. */
@State(Scope.Benchmark)
-public class VariableWidthVectorBenchmarks {
+public class VariableWidthVectorInlineValueBenchmarks {
// checkstyle:off: MissingJavadocMethod
private static final int VECTOR_CAPACITY = 16 * 1024;
@@ -45,15 +47,18 @@ public class VariableWidthVectorBenchmarks {
private static final int ALLOCATOR_CAPACITY = 1024 * 1024;
- private static byte[] bytes =
VariableWidthVectorBenchmarks.class.getName().getBytes();
+ private static final byte[] bytes =
VariableWidthVectorBenchmarkConstants.SHORT_VALUE.getBytes();
private ArrowBuf arrowBuff;
private BufferAllocator allocator;
private VarCharVector vector;
+ @Param({"1", "2", "10", "40"})
+ private int step;
+
/** Setup benchmarks. */
- @Setup
+ @Setup(Level.Iteration)
public void prepare() {
allocator = new RootAllocator(ALLOCATOR_CAPACITY);
vector = new VarCharVector("vector", allocator);
@@ -63,7 +68,7 @@ public class VariableWidthVectorBenchmarks {
}
/** Tear down benchmarks. */
- @TearDown
+ @TearDown(Level.Iteration)
public void tearDown() {
arrowBuff.close();
vector.close();
@@ -87,7 +92,7 @@ public class VariableWidthVectorBenchmarks {
@OutputTimeUnit(TimeUnit.MILLISECONDS)
public int setSafeFromArray() {
for (int i = 0; i < 500; ++i) {
- vector.setSafe(i * 40, bytes);
+ vector.setSafe(i * step, bytes);
}
return vector.getBufferSize();
}
@@ -115,7 +120,7 @@ public class VariableWidthVectorBenchmarks {
public static void main(String[] args) throws RunnerException {
Options opt =
new OptionsBuilder()
- .include(VariableWidthVectorBenchmarks.class.getSimpleName())
+
.include(VariableWidthVectorInlineValueBenchmarks.class.getSimpleName())
.forks(1)
.build();
diff --git
a/performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarks.java
b/performance/src/main/java/org/apache/arrow/vector/VariableWidthViewVectorBenchmarks.java
similarity index 82%
copy from
performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarks.java
copy to
performance/src/main/java/org/apache/arrow/vector/VariableWidthViewVectorBenchmarks.java
index 0bce6569..b85377dc 100644
---
a/performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarks.java
+++
b/performance/src/main/java/org/apache/arrow/vector/VariableWidthViewVectorBenchmarks.java
@@ -20,11 +20,13 @@ import java.util.concurrent.TimeUnit;
import org.apache.arrow.memory.ArrowBuf;
import org.apache.arrow.memory.BufferAllocator;
import org.apache.arrow.memory.RootAllocator;
-import org.apache.arrow.vector.holders.NullableVarCharHolder;
+import org.apache.arrow.vector.holders.NullableViewVarCharHolder;
import org.openjdk.jmh.annotations.Benchmark;
import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Level;
import org.openjdk.jmh.annotations.Mode;
import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Param;
import org.openjdk.jmh.annotations.Scope;
import org.openjdk.jmh.annotations.Setup;
import org.openjdk.jmh.annotations.State;
@@ -36,7 +38,7 @@ import org.openjdk.jmh.runner.options.OptionsBuilder;
/** Benchmarks for {@link BaseVariableWidthVector}. */
@State(Scope.Benchmark)
-public class VariableWidthVectorBenchmarks {
+public class VariableWidthViewVectorBenchmarks {
// checkstyle:off: MissingJavadocMethod
private static final int VECTOR_CAPACITY = 16 * 1024;
@@ -45,25 +47,28 @@ public class VariableWidthVectorBenchmarks {
private static final int ALLOCATOR_CAPACITY = 1024 * 1024;
- private static byte[] bytes =
VariableWidthVectorBenchmarks.class.getName().getBytes();
+ private static byte[] bytes =
VariableWidthVectorBenchmarkConstants.LONG_VALUE.getBytes();
private ArrowBuf arrowBuff;
private BufferAllocator allocator;
- private VarCharVector vector;
+ private ViewVarCharVector vector;
+
+ @Param({"1", "2", "10", "40"})
+ private int step;
/** Setup benchmarks. */
- @Setup
+ @Setup(Level.Iteration)
public void prepare() {
- allocator = new RootAllocator(ALLOCATOR_CAPACITY);
- vector = new VarCharVector("vector", allocator);
+ allocator = new RootAllocator();
+ vector = new ViewVarCharVector("vector", allocator);
vector.allocateNew(VECTOR_CAPACITY, VECTOR_LENGTH);
arrowBuff = allocator.buffer(VECTOR_LENGTH);
arrowBuff.setBytes(0, bytes, 0, bytes.length);
}
/** Tear down benchmarks. */
- @TearDown
+ @TearDown(Level.Iteration)
public void tearDown() {
arrowBuff.close();
vector.close();
@@ -87,7 +92,7 @@ public class VariableWidthVectorBenchmarks {
@OutputTimeUnit(TimeUnit.MILLISECONDS)
public int setSafeFromArray() {
for (int i = 0; i < 500; ++i) {
- vector.setSafe(i * 40, bytes);
+ vector.setSafe(i * step, bytes);
}
return vector.getBufferSize();
}
@@ -96,7 +101,7 @@ public class VariableWidthVectorBenchmarks {
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.MILLISECONDS)
public int setSafeFromNullableVarcharHolder() {
- NullableVarCharHolder nvch = new NullableVarCharHolder();
+ NullableViewVarCharHolder nvch = new NullableViewVarCharHolder();
nvch.buffer = arrowBuff;
nvch.start = 0;
nvch.end = bytes.length;
@@ -115,7 +120,7 @@ public class VariableWidthVectorBenchmarks {
public static void main(String[] args) throws RunnerException {
Options opt =
new OptionsBuilder()
- .include(VariableWidthVectorBenchmarks.class.getSimpleName())
+ .include(VariableWidthViewVectorBenchmarks.class.getSimpleName())
.forks(1)
.build();
diff --git
a/performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarks.java
b/performance/src/main/java/org/apache/arrow/vector/VariableWidthViewVectorInlineValueBenchmarks.java
similarity index 81%
copy from
performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarks.java
copy to
performance/src/main/java/org/apache/arrow/vector/VariableWidthViewVectorInlineValueBenchmarks.java
index 0bce6569..32143d47 100644
---
a/performance/src/main/java/org/apache/arrow/vector/VariableWidthVectorBenchmarks.java
+++
b/performance/src/main/java/org/apache/arrow/vector/VariableWidthViewVectorInlineValueBenchmarks.java
@@ -20,11 +20,13 @@ import java.util.concurrent.TimeUnit;
import org.apache.arrow.memory.ArrowBuf;
import org.apache.arrow.memory.BufferAllocator;
import org.apache.arrow.memory.RootAllocator;
-import org.apache.arrow.vector.holders.NullableVarCharHolder;
+import org.apache.arrow.vector.holders.NullableViewVarCharHolder;
import org.openjdk.jmh.annotations.Benchmark;
import org.openjdk.jmh.annotations.BenchmarkMode;
+import org.openjdk.jmh.annotations.Level;
import org.openjdk.jmh.annotations.Mode;
import org.openjdk.jmh.annotations.OutputTimeUnit;
+import org.openjdk.jmh.annotations.Param;
import org.openjdk.jmh.annotations.Scope;
import org.openjdk.jmh.annotations.Setup;
import org.openjdk.jmh.annotations.State;
@@ -36,7 +38,7 @@ import org.openjdk.jmh.runner.options.OptionsBuilder;
/** Benchmarks for {@link BaseVariableWidthVector}. */
@State(Scope.Benchmark)
-public class VariableWidthVectorBenchmarks {
+public class VariableWidthViewVectorInlineValueBenchmarks {
// checkstyle:off: MissingJavadocMethod
private static final int VECTOR_CAPACITY = 16 * 1024;
@@ -45,25 +47,29 @@ public class VariableWidthVectorBenchmarks {
private static final int ALLOCATOR_CAPACITY = 1024 * 1024;
- private static byte[] bytes =
VariableWidthVectorBenchmarks.class.getName().getBytes();
+ private static byte[] bytes =
VariableWidthVectorBenchmarkConstants.SHORT_VALUE.getBytes();
private ArrowBuf arrowBuff;
private BufferAllocator allocator;
- private VarCharVector vector;
+ private ViewVarCharVector vector;
+
+ @Param({"1", "2", "10", "40"})
+ private int step;
/** Setup benchmarks. */
- @Setup
+ @Setup(Level.Invocation)
public void prepare() {
- allocator = new RootAllocator(ALLOCATOR_CAPACITY);
- vector = new VarCharVector("vector", allocator);
+ allocator = new RootAllocator();
+ vector = new ViewVarCharVector("vector", allocator);
vector.allocateNew(VECTOR_CAPACITY, VECTOR_LENGTH);
+ vector.zeroVector();
arrowBuff = allocator.buffer(VECTOR_LENGTH);
arrowBuff.setBytes(0, bytes, 0, bytes.length);
}
/** Tear down benchmarks. */
- @TearDown
+ @TearDown(Level.Invocation)
public void tearDown() {
arrowBuff.close();
vector.close();
@@ -87,7 +93,7 @@ public class VariableWidthVectorBenchmarks {
@OutputTimeUnit(TimeUnit.MILLISECONDS)
public int setSafeFromArray() {
for (int i = 0; i < 500; ++i) {
- vector.setSafe(i * 40, bytes);
+ vector.setSafe(i * step, bytes);
}
return vector.getBufferSize();
}
@@ -96,7 +102,7 @@ public class VariableWidthVectorBenchmarks {
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.MILLISECONDS)
public int setSafeFromNullableVarcharHolder() {
- NullableVarCharHolder nvch = new NullableVarCharHolder();
+ NullableViewVarCharHolder nvch = new NullableViewVarCharHolder();
nvch.buffer = arrowBuff;
nvch.start = 0;
nvch.end = bytes.length;
@@ -115,7 +121,7 @@ public class VariableWidthVectorBenchmarks {
public static void main(String[] args) throws RunnerException {
Options opt =
new OptionsBuilder()
- .include(VariableWidthVectorBenchmarks.class.getSimpleName())
+
.include(VariableWidthViewVectorInlineValueBenchmarks.class.getSimpleName())
.forks(1)
.build();
