This is an automated email from the ASF dual-hosted git repository.
kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 2c90dafa0a GH-39023: [C++][CMake] Add missing launcher path conversion
for ExternalPackage (#45349)
2c90dafa0a is described below
commit 2c90dafa0abeaa5661a4ccac78c16dfd370bca32
Author: Sutou Kouhei <[email protected]>
AuthorDate: Sat Jan 25 17:33:56 2025 +0900
GH-39023: [C++][CMake] Add missing launcher path conversion for
ExternalPackage (#45349)
### Rationale for this change
We need to convert it on Windows.
### What changes are included in this PR?
Convert it to CMake path.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
* GitHub Issue: #39023
Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
---
cpp/cmake_modules/ThirdpartyToolchain.cmake | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake
b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index f9459f4175..cbc96ce397 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -988,9 +988,11 @@ endif()
# Enable s/ccache if set by parent.
if(CMAKE_C_COMPILER_LAUNCHER AND CMAKE_CXX_COMPILER_LAUNCHER)
+ file(TO_CMAKE_PATH "${CMAKE_C_COMPILER_LAUNCHER}"
EP_CMAKE_C_COMPILER_LAUNCHER)
+ file(TO_CMAKE_PATH "${CMAKE_CXX_COMPILER_LAUNCHER}"
EP_CMAKE_CXX_COMPILER_LAUNCHER)
list(APPEND EP_COMMON_CMAKE_ARGS
- -DCMAKE_C_COMPILER_LAUNCHER=${CMAKE_C_COMPILER_LAUNCHER}
- -DCMAKE_CXX_COMPILER_LAUNCHER=${CMAKE_CXX_COMPILER_LAUNCHER})
+ -DCMAKE_C_COMPILER_LAUNCHER=${EP_CMAKE_C_COMPILER_LAUNCHER}
+ -DCMAKE_CXX_COMPILER_LAUNCHER=${EP_CMAKE_CXX_COMPILER_LAUNCHER})
endif()
if(NOT ARROW_VERBOSE_THIRDPARTY_BUILD)