This is an automated email from the ASF dual-hosted git repository.
kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 5bedd95f71 GH-45659: [GLib][Ruby] Fix Ruby lint violation(add space
after comma) (#45660)
5bedd95f71 is described below
commit 5bedd95f714274ca1ab64b7a9e0096209c045fcd
Author: Hiroyuki Sato <[email protected]>
AuthorDate: Tue Mar 4 14:15:58 2025 +0900
GH-45659: [GLib][Ruby] Fix Ruby lint violation(add space after comma)
(#45660)
### Rationale for this change
Preparing to add Ruby lint rule. require space after comma.
ex) `[1,2,3]` -> `[1, 2, 3]`
### What changes are included in this PR?
Add space after comma.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
* GitHub Issue: #45659
Authored-by: Hiroyuki Sato <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
---
c_glib/test/test-record-batch.rb | 2 +-
c_glib/test/test-take.rb | 2 +-
ruby/red-arrow/test/test-array.rb | 14 +++++++-------
3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/c_glib/test/test-record-batch.rb b/c_glib/test/test-record-batch.rb
index ff821ddf02..86ae5b2e2d 100644
--- a/c_glib/test/test-record-batch.rb
+++ b/c_glib/test/test-record-batch.rb
@@ -234,7 +234,7 @@ valid: [
# U+3042 HIRAGANA LETTER A, U+3044 HIRAGANA LETTER I
data = "\u3042\u3044".b[0..-2]
- value_offsets = Arrow::Buffer.new([0,data.size].pack("l*"))
+ value_offsets = Arrow::Buffer.new([0, data.size].pack("l*"))
@invalid_name_value = Arrow::StringArray.new(1,
value_offsets,
Arrow::Buffer.new(data),
diff --git a/c_glib/test/test-take.rb b/c_glib/test/test-take.rb
index f97c7ad730..5b7af2d21f 100644
--- a/c_glib/test/test-take.rb
+++ b/c_glib/test/test-take.rb
@@ -23,7 +23,7 @@ class TestTake < Test::Unit::TestCase
def test_no_null
indices = build_int16_array([1, 0, 2])
assert_equal(build_int16_array([0, 1, 2]),
- build_int16_array([1, 0 ,2]).take(indices))
+ build_int16_array([1, 0, 2]).take(indices))
end
def test_null
diff --git a/ruby/red-arrow/test/test-array.rb
b/ruby/red-arrow/test/test-array.rb
index 6dbf7e52e8..f566a40ef1 100644
--- a/ruby/red-arrow/test/test-array.rb
+++ b/ruby/red-arrow/test/test-array.rb
@@ -142,7 +142,7 @@ class ArrayTest < Test::Unit::TestCase
sub_test_case("#take") do
def setup
- values = [1, 0 ,2]
+ values = [1, 0, 2]
@array = Arrow::Int16Array.new(values)
end
@@ -205,14 +205,14 @@ class ArrayTest < Test::Unit::TestCase
sub_test_case("#concatenate") do
test("Arrow::Array: same") do
- assert_equal(Arrow::Int32Array.new([1, 2, nil, 4 ,5, 6]),
+ assert_equal(Arrow::Int32Array.new([1, 2, nil, 4, 5, 6]),
Arrow::Int32Array.new([1, 2, nil]).
concatenate(Arrow::Int32Array.new([4, 5]),
Arrow::Int32Array.new([6])))
end
test("Arrow::Array: castable") do
- assert_equal(Arrow::Int32Array.new([1, 2, nil, 4 ,5, 6]),
+ assert_equal(Arrow::Int32Array.new([1, 2, nil, 4, 5, 6]),
Arrow::Int32Array.new([1, 2, nil]).
concatenate(Arrow::Int8Array.new([4, 5]),
Arrow::UInt32Array.new([6])))
@@ -226,7 +226,7 @@ class ArrayTest < Test::Unit::TestCase
end
test("Array") do
- assert_equal(Arrow::Int32Array.new([1, 2, nil, 4 ,nil, 6]),
+ assert_equal(Arrow::Int32Array.new([1, 2, nil, 4, nil, 6]),
Arrow::Int32Array.new([1, 2, nil]).
concatenate([4, nil],
[6]))
@@ -243,13 +243,13 @@ class ArrayTest < Test::Unit::TestCase
sub_test_case("#+") do
test("Arrow::Array: same") do
- assert_equal(Arrow::Int32Array.new([1, 2, nil, 4 ,5, 6]),
+ assert_equal(Arrow::Int32Array.new([1, 2, nil, 4, 5, 6]),
Arrow::Int32Array.new([1, 2, nil]) +
Arrow::Int32Array.new([4, 5, 6]))
end
test("Arrow::Array: castable") do
- assert_equal(Arrow::Int32Array.new([1, 2, nil, 4 ,5, 6]),
+ assert_equal(Arrow::Int32Array.new([1, 2, nil, 4, 5, 6]),
Arrow::Int32Array.new([1, 2, nil]) +
Arrow::Int8Array.new([4, 5, 6]))
end
@@ -262,7 +262,7 @@ class ArrayTest < Test::Unit::TestCase
end
test("Array") do
- assert_equal(Arrow::Int32Array.new([1, 2, nil, 4 ,nil, 6]),
+ assert_equal(Arrow::Int32Array.new([1, 2, nil, 4, nil, 6]),
Arrow::Int32Array.new([1, 2, nil]) +
[4, nil, 6])
end