This is an automated email from the ASF dual-hosted git repository.

westonpace pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git


The following commit(s) were added to refs/heads/main by this push:
     new 43ee8cfa48 Apply clippy suggestions newly introduced in rust 1.86 
(#7382)
43ee8cfa48 is described below

commit 43ee8cfa48f4d032cbe8de37f79c9f287ea4ed3f
Author: Weston Pace <[email protected]>
AuthorDate: Thu Apr 3 08:23:29 2025 -0700

    Apply clippy suggestions newly introduced in rust 1.86 (#7382)
---
 arrow-buffer/src/bigint/div.rs                          | 4 ++--
 arrow-buffer/src/util/bit_chunk_iterator.rs             | 2 +-
 arrow/benches/buffer_create.rs                          | 2 +-
 parquet/src/arrow/array_reader/fixed_size_list_array.rs | 2 +-
 parquet/src/arrow/array_reader/list_array.rs            | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arrow-buffer/src/bigint/div.rs b/arrow-buffer/src/bigint/div.rs
index bc94e1c457..f094f662cc 100644
--- a/arrow-buffer/src/bigint/div.rs
+++ b/arrow-buffer/src/bigint/div.rs
@@ -39,8 +39,8 @@ pub fn div_rem<const N: usize>(numerator: &[u64; N], divisor: 
&[u64; N]) -> ([u6
         return div_rem_small(numerator, divisor[0]);
     }
 
-    let numerator_words = (numerator_bits + 63) / 64;
-    let divisor_words = (divisor_bits + 63) / 64;
+    let numerator_words = numerator_bits.div_ceil(64);
+    let divisor_words = divisor_bits.div_ceil(64);
     let n = divisor_words;
     let m = numerator_words - divisor_words;
 
diff --git a/arrow-buffer/src/util/bit_chunk_iterator.rs 
b/arrow-buffer/src/util/bit_chunk_iterator.rs
index 0562c7ad59..ea8e8f472a 100644
--- a/arrow-buffer/src/util/bit_chunk_iterator.rs
+++ b/arrow-buffer/src/util/bit_chunk_iterator.rs
@@ -53,7 +53,7 @@ impl<'a> UnalignedBitChunk<'a> {
         let byte_offset = offset / 8;
         let offset_padding = offset % 8;
 
-        let bytes_len = (len + offset_padding + 7) / 8;
+        let bytes_len = (len + offset_padding).div_ceil(8);
         let buffer = &buffer[byte_offset..byte_offset + bytes_len];
 
         let prefix_mask = compute_prefix_mask(offset_padding);
diff --git a/arrow/benches/buffer_create.rs b/arrow/benches/buffer_create.rs
index f6199ccab5..2c4d0d6a99 100644
--- a/arrow/benches/buffer_create.rs
+++ b/arrow/benches/buffer_create.rs
@@ -50,7 +50,7 @@ fn mutable_buffer_iter_bitset(data: &[Vec<bool>]) -> 
Vec<Buffer> {
         data.iter()
             .map(|datum| {
                 let mut result =
-                    MutableBuffer::new((data.len() + 7) / 
8).with_bitset(datum.len(), false);
+                    
MutableBuffer::new(data.len().div_ceil(8)).with_bitset(datum.len(), false);
                 for (i, value) in datum.iter().enumerate() {
                     if *value {
                         unsafe {
diff --git a/parquet/src/arrow/array_reader/fixed_size_list_array.rs 
b/parquet/src/arrow/array_reader/fixed_size_list_array.rs
index 43a9037d4a..5750ef94e3 100644
--- a/parquet/src/arrow/array_reader/fixed_size_list_array.rs
+++ b/parquet/src/arrow/array_reader/fixed_size_list_array.rs
@@ -77,7 +77,7 @@ impl ArrayReader for FixedSizeListArrayReader {
 
     fn consume_batch(&mut self) -> Result<ArrayRef> {
         let next_batch_array = self.item_reader.consume_batch()?;
-        if next_batch_array.len() == 0 {
+        if next_batch_array.is_empty() {
             return Ok(new_empty_array(&self.data_type));
         }
 
diff --git a/parquet/src/arrow/array_reader/list_array.rs 
b/parquet/src/arrow/array_reader/list_array.rs
index 6e583ed00c..06448d5f6f 100644
--- a/parquet/src/arrow/array_reader/list_array.rs
+++ b/parquet/src/arrow/array_reader/list_array.rs
@@ -83,7 +83,7 @@ impl<OffsetSize: OffsetSizeTrait> ArrayReader for 
ListArrayReader<OffsetSize> {
 
     fn consume_batch(&mut self) -> Result<ArrayRef> {
         let next_batch_array = self.item_reader.consume_batch()?;
-        if next_batch_array.len() == 0 {
+        if next_batch_array.is_empty() {
             return Ok(new_empty_array(&self.data_type));
         }
 

Reply via email to