This is an automated email from the ASF dual-hosted git repository. assignuser pushed a commit to branch release-20.0.0-rc1 in repository https://gitbox.apache.org/repos/asf/arrow.git
commit 792c82ba98fc7c9ba1fb6284577c84f35b9e0f0e Author: Sutou Kouhei <[email protected]> AuthorDate: Thu Apr 10 11:10:24 2025 +0900 GH-46072: [Release] Disable sync in 05-binary-upload.sh (#46074) ### Rationale for this change A Yum repository uses hash value for metadata file name. e.g.: https://apache.jfrog.io/artifactory/arrow/almalinux/9/x86_64/repodata/00965b628ce7491674b8b0e20355e2c0e81c8d57b04b7e88ac2e6777aad09472-filelists.sqlite.bz2 We can remove old metadata files when update a Yum repository's metadata. But our Artifactory/Maven repository client implementation (`dev/release/binary-task.rb`) doesn't have a complete implementation for removing existing files. But our configuration enables the feature. ### What changes are included in this PR? Disable the feature. The feature was enabled by #45903 accidentally. Old implementation disables the feature. So this doesn't change the existing behavior. (Garbage will be increased in Yum repositories...) ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: #46072 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]> --- dev/release/binary-task.rb | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/dev/release/binary-task.rb b/dev/release/binary-task.rb index 77d0352b8d..8e12a85a77 100644 --- a/dev/release/binary-task.rb +++ b/dev/release/binary-task.rb @@ -2231,7 +2231,10 @@ APT::FTPArchive::Release::Description "#{apt_repository_description}"; rc: rc, source: upload_target_dir, staging: staging?, - sync: true, + # Don't remove old repodata + # because our implementation + # doesn't support it. + sync: false, sync_pattern: /\/repodata\//) uploader.upload end @@ -2381,7 +2384,12 @@ APT::FTPArchive::Release::Description "#{apt_repository_description}"; distribution: distribution, rc: rc, source: upload_target_dir, - sync: true, + # Don't remove old + # repodata. Because + # removing files + # aren't supported + # on Maven repository. + sync: false, sync_pattern: /\/repodata\//) uploader.upload end
