This is an automated email from the ASF dual-hosted git repository.

alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs-object-store.git


The following commit(s) were added to refs/heads/main by this push:
     new 3e12e1a  Run CI on PRs (#336)
3e12e1a is described below

commit 3e12e1a229754fc7a2cb20ffce37bf14c3aaca1a
Author: Adam Gutglick <[email protected]>
AuthorDate: Tue Apr 15 20:29:07 2025 +0100

    Run CI on PRs (#336)
    
    * .
    
    * clippy fixes
    
    * no need for a path filter
---
 .github/workflows/{object_store.yml => ci.yml} | 9 +++------
 src/delimited.rs                               | 2 +-
 src/integration.rs                             | 2 +-
 3 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/object_store.yml b/.github/workflows/ci.yml
similarity index 97%
rename from .github/workflows/object_store.yml
rename to .github/workflows/ci.yml
index 3b1b676..308a304 100644
--- a/.github/workflows/object_store.yml
+++ b/.github/workflows/ci.yml
@@ -16,8 +16,8 @@
 # under the License.
 
 ---
-# tests for `object_store` crate
-name: object_store
+
+name: CI
 
 concurrency:
   group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ 
github.workflow }}
@@ -29,9 +29,6 @@ on:
     branches:
       - main
   pull_request:
-    paths:
-      - object_store/**
-      - .github/**
 
 jobs:
   clippy:
@@ -77,7 +74,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - name: Run cargo doc
-        run: cargo doc --document-private-items --no-deps --workspace 
--all-features
+        run: cargo doc --document-private-items --no-deps --all-features
 
   # test the crate
   # This runs outside a container to workaround lack of support for passing 
arguments
diff --git a/src/delimited.rs b/src/delimited.rs
index 5b11a0b..0994b4f 100644
--- a/src/delimited.rs
+++ b/src/delimited.rs
@@ -109,7 +109,7 @@ impl LineDelimiter {
                 }
             },
         };
-        let end_offset = record_ends.last().unwrap_or(start_offset);
+        let end_offset = record_ends.next_back().unwrap_or(start_offset);
         if start_offset != end_offset {
             self.complete.push_back(val.slice(start_offset..end_offset));
         }
diff --git a/src/integration.rs b/src/integration.rs
index f10b2d3..f1baf79 100644
--- a/src/integration.rs
+++ b/src/integration.rs
@@ -657,7 +657,7 @@ pub async fn put_opts(storage: &dyn ObjectStore, 
supports_update: bool) {
             .put_opts(&path, "c".into(), 
PutMode::Update(v1.clone().into()).into())
             .await
             .unwrap_err();
-        assert!(matches!(err, Error::NotImplemented { .. }), "{err}");
+        assert!(matches!(err, Error::NotImplemented), "{err}");
 
         return;
     }

Reply via email to