This is an automated email from the ASF dual-hosted git repository.
kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new f88c19fd0b GH-46587: [CI][JS] Remove JS related test CI (#46588)
f88c19fd0b is described below
commit f88c19fd0b6aaac6817b3de72dec6f002c70e7b8
Author: Raúl Cumplido <[email protected]>
AuthorDate: Mon May 26 22:37:43 2025 +0200
GH-46587: [CI][JS] Remove JS related test CI (#46588)
### Rationale for this change
As part of moving the JavaScript implementation to
https://github.com/apache/arrow-js we have to remove CI related workflows and
scripts from the main repository.
### What changes are included in this PR?
Remove JS related CI and build scripts.
### Are these changes tested?
No
### Are there any user-facing changes?
No
* GitHub Issue: #46587
Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
---
.github/workflows/js.yml | 148 --------------------------------------
ci/docker/debian-12-js.dockerfile | 33 ---------
ci/scripts/js_build.sh | 60 ----------------
ci/scripts/js_test.sh | 31 --------
dev/tasks/tasks.yml | 3 -
docker-compose.yml | 30 +-------
6 files changed, 1 insertion(+), 304 deletions(-)
diff --git a/.github/workflows/js.yml b/.github/workflows/js.yml
deleted file mode 100644
index 22c975fc30..0000000000
--- a/.github/workflows/js.yml
+++ /dev/null
@@ -1,148 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-name: NodeJS
-
-on:
- push:
- branches:
- - '**'
- - '!dependabot/**'
- tags:
- - '**'
- paths:
- - '.dockerignore'
- - '.github/workflows/js.yml'
- - 'ci/docker/*js.dockerfile'
- - 'ci/scripts/js_*'
- - 'js/**'
- pull_request:
- paths:
- - '.dockerignore'
- - '.github/workflows/js.yml'
- - 'ci/docker/*js.dockerfile'
- - 'ci/scripts/js_*'
- - 'js/**'
-
-concurrency:
- group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
- cancel-in-progress: true
-
-permissions:
- contents: read
-
-env:
- ARCHERY_DEBUG: 1
-
-jobs:
-
- docker:
- name: AMD64 Debian 12 NodeJS 18
- runs-on: ubuntu-latest
- if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
- timeout-minutes: 60
- steps:
- - name: Checkout Arrow
- uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac #
v4.0.0
- with:
- fetch-depth: 0
- - name: Setup Python
- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 #
v5.6.0
- with:
- python-version: 3.12
- - name: Setup Archery
- run: pip install -e dev/archery[docker]
- - name: Execute Docker Build
- env:
- ARCHERY_DOCKER_USER: ${{ secrets.DOCKERHUB_USER }}
- ARCHERY_DOCKER_PASSWORD: ${{ secrets.DOCKERHUB_TOKEN }}
- run: |
- source ci/scripts/util_enable_core_dumps.sh
- archery docker run debian-js
- - name: Docker Push
- if: >-
- success() &&
- github.event_name == 'push' &&
- github.repository == 'apache/arrow' &&
- github.ref_name == 'main'
- env:
- ARCHERY_DOCKER_USER: ${{ secrets.DOCKERHUB_USER }}
- ARCHERY_DOCKER_PASSWORD: ${{ secrets.DOCKERHUB_TOKEN }}
- continue-on-error: true
- run: archery docker push debian-js
-
- macos:
- name: AMD64 macOS 13 NodeJS ${{ matrix.node }}
- runs-on: macos-13
- if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
- timeout-minutes: 45
- strategy:
- fail-fast: false
- matrix:
- node: [18]
- steps:
- - name: Checkout Arrow
- uses: actions/checkout@v4
- with:
- fetch-depth: 0
- - name: Jest Cache
- uses: actions/cache@v4
- with:
- path: js/.jest-cache
- key: js-jest-cache-${{ runner.os }}-${{ hashFiles('js/src/**/*.ts',
'js/test/**/*.ts', 'js/yarn.lock') }}
- restore-keys: js-jest-cache-${{ runner.os }}-
- - name: Install NodeJS
- uses: actions/setup-node@v4
- with:
- node-version: ${{ matrix.node }}
- - name: Build
- shell: bash
- run: ci/scripts/js_build.sh $(pwd) build
- - name: Test
- shell: bash
- run: ci/scripts/js_test.sh $(pwd) build
-
- windows:
- name: AMD64 Windows NodeJS ${{ matrix.node }}
- runs-on: windows-latest
- if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
- timeout-minutes: 45
- strategy:
- fail-fast: false
- matrix:
- node: [18]
- steps:
- - name: Checkout Arrow
- uses: actions/checkout@v4
- with:
- fetch-depth: 0
- - name: Jest Cache
- uses: actions/cache@v4
- with:
- path: js/.jest-cache
- key: js-jest-cache-${{ runner.os }}-${{ hashFiles('js/src/**/*.ts',
'js/test/**/*.ts', 'js/yarn.lock') }}
- restore-keys: js-jest-cache-${{ runner.os }}-
- - name: Install NodeJS
- uses: actions/setup-node@v4
- with:
- node-version: ${{ matrix.node }}
- - name: Build
- shell: bash
- run: ci/scripts/js_build.sh $(pwd) build
- - name: Test
- shell: bash
- run: ci/scripts/js_test.sh $(pwd) build
diff --git a/ci/docker/debian-12-js.dockerfile
b/ci/docker/debian-12-js.dockerfile
deleted file mode 100644
index e0935676d9..0000000000
--- a/ci/docker/debian-12-js.dockerfile
+++ /dev/null
@@ -1,33 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-ARG arch=amd64
-ARG node=18
-FROM ${arch}/node:${node}
-
-ENV NODE_NO_WARNINGS=1
-
-# install rsync for copying the generated documentation
-RUN apt-get update -y -q && \
- apt-get install -y -q --no-install-recommends rsync && \
- apt-get clean && \
- rm -rf /var/lib/apt/lists/*
-
-# TODO(kszucs):
-# 1. add the files required to install the dependencies to .dockerignore
-# 2. copy these files to their appropriate path
-# 3. download and compile the dependencies
diff --git a/ci/scripts/js_build.sh b/ci/scripts/js_build.sh
deleted file mode 100755
index 196539ee0f..0000000000
--- a/ci/scripts/js_build.sh
+++ /dev/null
@@ -1,60 +0,0 @@
-#!/usr/bin/env bash
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-set -ex
-
-arrow_dir=${1}
-source_dir=${arrow_dir}/js
-build_dir=${2}
-
-: ${BUILD_DOCS_JS:=OFF}
-
-# https://github.com/apache/arrow/issues/41429
-# TODO: We want to out-of-source build. This is a workaround. We copy
-# all needed files to the build directory from the source directory
-# and build in the build directory.
-rm -rf ${build_dir}/js
-mkdir -p ${build_dir}
-cp -aL ${arrow_dir}/LICENSE.txt ${build_dir}/
-cp -aL ${arrow_dir}/NOTICE.txt ${build_dir}/
-cp -aL ${source_dir} ${build_dir}/js
-pushd ${build_dir}/js
-
-yarn --immutable
-yarn lint:ci
-yarn build
-
-if [ "${BUILD_DOCS_JS}" == "ON" ]; then
- # If apache or upstream are defined use those as remote.
- # Otherwise use origin which could be a fork on PRs.
- if [ "$(git -C ${arrow_dir} config --get remote.apache.url)" ==
"[email protected]:apache/arrow.git" ]; then
- yarn doc --gitRemote apache
- elif [[ "$(git -C ${arrow_dir}config --get remote.upstream.url)" =~
"https://github.com/apache/arrow"; ]]; then
- yarn doc --gitRemote upstream
- elif [[ "$(basename -s .git $(git -C ${arrow_dir} config --get
remote.origin.url))" == "arrow" ]]; then
- yarn doc
- else
- echo "Failed to build docs because the remote is not set correctly. Please
set the origin or upstream remote to https://github.com/apache/arrow.git or the
apache remote to [email protected]:apache/arrow.git."
- exit 0
- fi
- mkdir -p ${build_dir}/docs/js
- rsync -a doc/ ${build_dir}/docs/js
-fi
-
-popd
diff --git a/ci/scripts/js_test.sh b/ci/scripts/js_test.sh
deleted file mode 100755
index 863b1c3d34..0000000000
--- a/ci/scripts/js_test.sh
+++ /dev/null
@@ -1,31 +0,0 @@
-#!/usr/bin/env bash
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-set -ex
-
-source_dir=${1}/js
-build_dir=${2}/js
-
-pushd ${build_dir}
-
-yarn lint
-yarn test
-yarn test:bundle
-
-popd
diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml
index 6bb7ec2d3e..cf5e440b51 100644
--- a/dev/tasks/tasks.yml
+++ b/dev/tasks/tasks.yml
@@ -567,7 +567,6 @@ tasks:
{% for target in ["cpp",
"csharp",
"integration",
- "js",
"python",
"ruby"] %}
verify-rc-source-{{ target }}-linux-{{ distribution }}-{{ version }}-amd64:
@@ -597,7 +596,6 @@ tasks:
{% for target in ["cpp",
"csharp",
"integration",
- "js",
"python",
"ruby"] %}
verify-rc-source-{{ target }}-macos-amd64:
@@ -611,7 +609,6 @@ tasks:
{% for target in ["cpp",
"csharp",
"integration",
- "js",
"python",
"ruby"] %}
verify-rc-source-{{ target }}-macos-arm64:
diff --git a/docker-compose.yml b/docker-compose.yml
index b02b0b7467..96013d2b68 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -135,7 +135,6 @@ x-hierarchy:
- debian-ruby
- debian-python:
- debian-docs
- - debian-js
- fedora-cpp:
- fedora-python
- python-sdist
@@ -1768,31 +1767,6 @@ services:
command: >
/bin/bash -c "/arrow/ci/scripts/r_revdepcheck.sh /arrow"
- ############################# JavaScript ####################################
-
- debian-js:
- # Usage:
- # docker compose build debian-js
- # docker compose run debian-js
- image: ${REPO}:${ARCH}-debian-${DEBIAN}-js-${NODE}
- build:
- context: .
- dockerfile: ci/docker/debian-${DEBIAN}-js.dockerfile
- cache_from:
- - ${REPO}:${ARCH}-debian-${DEBIAN}-js-${NODE}
- args:
- arch: ${ARCH}
- node: ${NODE}
- shm_size: *shm-size
- volumes: *debian-volumes
- environment:
- <<: *common
- BUILD_DOCS_JS: "ON"
- command: &js-command >
- /bin/bash -c "
- /arrow/ci/scripts/js_build.sh /arrow /build &&
- /arrow/ci/scripts/js_test.sh /arrow /build"
-
#################################### C# #####################################
ubuntu-csharp:
@@ -1884,7 +1858,6 @@ services:
ARROW_SUBSTRAIT: "ON"
BUILD_DOCS_C_GLIB: "ON"
BUILD_DOCS_CPP: "ON"
- BUILD_DOCS_JS: "ON"
BUILD_DOCS_PYTHON: "ON"
BUILD_DOCS_R: "ON"
volumes: *debian-volumes
@@ -1895,8 +1868,7 @@ services:
/arrow/ci/scripts/cpp_build.sh /arrow /build &&
/arrow/ci/scripts/python_build.sh /arrow /build &&
/arrow/ci/scripts/c_glib_build.sh /arrow /build &&
- /arrow/ci/scripts/r_build.sh /arrow /build &&
- /arrow/ci/scripts/js_build.sh /arrow /build"
+ /arrow/ci/scripts/r_build.sh /arrow /build"
################################# Tools #####################################
