This is an automated email from the ASF dual-hosted git repository.
kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 19aadb2ff0 GH-46662: [CI][Dev] Fix shellcheck SC2148 errors in
ci/scripts directory (#46663)
19aadb2ff0 is described below
commit 19aadb2ff09a2455064ba083c0fb0b626b651473
Author: Hiroyuki Sato <[email protected]>
AuthorDate: Mon Jun 2 13:02:02 2025 +0900
GH-46662: [CI][Dev] Fix shellcheck SC2148 errors in ci/scripts directory
(#46663)
### Rationale for this change
We are trying to implement shellcheck on all sh files in #44748.
### What changes are included in this PR?
* SC2148: Add `shellcheck shell=bash` in `util_*` files
```
In ci/scripts/util_enable_core_dumps.sh line 1:
# Licensed to the Apache Software Foundation (ASF) under one
^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a
shebang or a 'shell' directive.
```
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
* GitHub Issue: #46662
Authored-by: Hiroyuki Sato <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
---
.pre-commit-config.yaml | 2 ++
ci/scripts/util_enable_core_dumps.sh | 2 ++
ci/scripts/util_log.sh | 2 ++
3 files changed, 6 insertions(+)
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 38a8972071..c650bf1719 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -299,7 +299,9 @@ repos:
?^ci/scripts/release_test\.sh$|
?^ci/scripts/ruby_test\.sh$|
?^ci/scripts/rust_build\.sh$|
+ ?^ci/scripts/util_enable_core_dumps\.sh$|
?^ci/scripts/util_free_space\.sh$|
+ ?^ci/scripts/util_log\.sh$|
?^cpp/build-support/build-lz4-lib\.sh$|
?^cpp/build-support/build-zstd-lib\.sh$|
?^cpp/build-support/get-upstream-commit\.sh$|
diff --git a/ci/scripts/util_enable_core_dumps.sh
b/ci/scripts/util_enable_core_dumps.sh
index 09f8d2d727..48061fd50c 100644
--- a/ci/scripts/util_enable_core_dumps.sh
+++ b/ci/scripts/util_enable_core_dumps.sh
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
diff --git a/ci/scripts/util_log.sh b/ci/scripts/util_log.sh
index 6caad1408a..08b768905d 100644
--- a/ci/scripts/util_log.sh
+++ b/ci/scripts/util_log.sh
@@ -1,3 +1,5 @@
+# shellcheck shell=bash
+#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information