(arrow-rs) branch main updated: [Variant] Add commented out primitive test casees (#7631)

[alamb]

This is an automated email from the ASF dual-hosted git repository.

alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git


The following commit(s) were added to refs/heads/main by this push:
     new 375bee76b1 [Variant] Add commented out primitive test casees (#7631)
375bee76b1 is described below

commit 375bee76b1558b18cf0654a2156c229d8babfc46
Author: Andrew Lamb <and...@nerdnetworks.org>
AuthorDate: Mon Jun 9 09:40:53 2025 -0400

    [Variant] Add commented out primitive test casees (#7631)
    
    # Which issue does this PR close?
    
    - Part of https://github.com/apache/arrow-rs/issues/7630
    
    # Rationale for this change
    
    Make it easy to add this feature by preparing the path with tests
    
    # What changes are included in this PR?
    
    Add tests (commented out) that should pass after
    https://github.com/apache/arrow-rs/issues/7630 is done
    
    # Are there any user-facing changes?
    
    No
---
 parquet-variant/tests/variant_interop.rs | 23 ++++++++++++++++++-----
 1 file changed, 18 insertions(+), 5 deletions(-)

diff --git a/parquet-variant/tests/variant_interop.rs 
b/parquet-variant/tests/variant_interop.rs
index 33bbbd5f5e..617a10d63d 100644
--- a/parquet-variant/tests/variant_interop.rs
+++ b/parquet-variant/tests/variant_interop.rs
@@ -40,16 +40,29 @@ fn load_case(name: &str) -> Result<(Vec<u8>, Vec<u8>), 
ArrowError> {
     Ok((meta, val))
 }
 
+/// Return a list of the values from the parquet testing repository:
+/// <https://github.com/apache/parquet-testing/tree/master/variant>
 fn get_primitive_cases() -> Vec<(&'static str, Variant<'static, 'static>)> {
+    // Cases are commented out
+    // Enabling is tracked in  https://github.com/apache/arrow-rs/issues/7630
     vec![
-        ("primitive_null", Variant::Null),
+        // ("primitive_binary", Variant::Binary),
         ("primitive_boolean_false", Variant::BooleanFalse),
         ("primitive_boolean_true", Variant::BooleanTrue),
+        // ("primitive_date", Variant::Null),
+        //("primitive_decimal4", Variant::Null),
+        //("primitive_decimal8", Variant::Null),
+        //("primitive_decimal16", Variant::Null),
+        //("primitive_float", Variant::Null),
         ("primitive_int8", Variant::Int8(42)),
-        // Using the From<String> trait
-        ("primitive_string", Variant::from("This string is longer than 64 
bytes and therefore does not fit in a short_string and it also includes several 
non ascii characters such as 🐢, 💖, ♥\u{fe0f}, 🎣 and 🤦!!")),
-        // Using the From<String> trait
-        ("short_string", Variant::from("Less than 64 bytes (❤\u{fe0f} with 
utf8)")), 
+        //("primitive_int16", Variant::Null),
+        //("primitive_int32", Variant::Null),
+        //("primitive_int64", Variant::Null),
+        ("primitive_null", Variant::Null),
+        ("primitive_string", Variant::String("This string is longer than 64 
bytes and therefore does not fit in a short_string and it also includes several 
non ascii characters such as 🐢, 💖, ♥\u{fe0f}, 🎣 and 🤦!!")),
+        //("primitive_timestamp", Variant::Null),
+        //("primitive_timestampntz", Variant::Null),
+        ("short_string", Variant::ShortString("Less than 64 bytes (❤\u{fe0f} 
with utf8)")),
     ]
 }