This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
The following commit(s) were added to refs/heads/main by this push:
new 04300b4deb Minor: Remove outdated FIXME from `ParquetMetaDataReader`
(#7635)
04300b4deb is described below
commit 04300b4deb209ebef48d8182094143686224b92e
Author: Ed Seidl <[email protected]>
AuthorDate: Tue Jun 10 21:20:06 2025 -0700
Minor: Remove outdated FIXME from `ParquetMetaDataReader` (#7635)
# Which issue does this PR close?
Related to #6447.
While reviewing other PRs I happened to notice an old FIXME I left
behind that should have been removed in #6639.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing changes?
No, just removes a comment
---
parquet/src/file/metadata/reader.rs | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/parquet/src/file/metadata/reader.rs
b/parquet/src/file/metadata/reader.rs
index 6edf2e611d..cbf33c2f96 100644
--- a/parquet/src/file/metadata/reader.rs
+++ b/parquet/src/file/metadata/reader.rs
@@ -336,15 +336,6 @@ impl ParquetMetaDataReader {
));
}
- // FIXME: there are differing implementations in the case where page
indexes are missing
- // from the file. `MetadataLoader` will leave them as `None`, while
the parser in
- // `index_reader::read_columns_indexes` returns a vector of empty
vectors.
- // It is best for this function to replicate the latter behavior for
now, but in a future
- // breaking release, the two paths to retrieve metadata should be made
consistent. Note that this is only
- // an issue if the user requested page indexes, so there is no need to
provide empty
- // vectors in `try_parse_sized()`.
- // https://github.com/apache/arrow-rs/issues/6447
-
// Get bounds needed for page indexes (if any are present in the file).
let Some(range) = self.range_for_page_index() else {
return Ok(());
