This is an automated email from the ASF dual-hosted git repository.
zeroshade pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git
The following commit(s) were added to refs/heads/main by this push:
new a38b4e808 fix(go/adbc/driver/internal/driverbase): fix missing
interface func (#3009)
a38b4e808 is described below
commit a38b4e8083c903a5115683c58800e48d84886288
Author: Matt Topol <[email protected]>
AuthorDate: Mon Jun 23 16:37:49 2025 -0400
fix(go/adbc/driver/internal/driverbase): fix missing interface func (#3009)
Looks like the changes and update for the Otel infrastructure introduced
a mismatch with how the interface for ExecuteSchema is handled. As a
result we have a failing test:
https://github.com/apache/arrow-adbc/actions/runs/15828865854/job/44625340147
This change updates the interface definition to fix the tests.
---
go/adbc/driver/internal/driverbase/driver_test.go | 4 ++++
go/adbc/driver/internal/driverbase/statement.go | 1 +
2 files changed, 5 insertions(+)
diff --git a/go/adbc/driver/internal/driverbase/driver_test.go
b/go/adbc/driver/internal/driverbase/driver_test.go
index 85422c4d9..f33b1fbcd 100644
--- a/go/adbc/driver/internal/driverbase/driver_test.go
+++ b/go/adbc/driver/internal/driverbase/driver_test.go
@@ -553,6 +553,10 @@ func (base *statement) ExecuteQuery(ctx context.Context)
(array.RecordReader, in
return nil, 0,
base.Base().ErrorHelper.Errorf(adbc.StatusNotImplemented, "ExecuteQuery")
}
+func (base *statement) ExecuteSchema(ctx context.Context) (*arrow.Schema,
error) {
+ return nil, base.Base().ErrorHelper.Errorf(adbc.StatusNotImplemented,
"ExecuteSchema")
+}
+
func (base *statement) ExecuteUpdate(ctx context.Context) (int64, error) {
return 0, base.Base().ErrorHelper.Errorf(adbc.StatusNotImplemented,
"ExecuteUpdate")
}
diff --git a/go/adbc/driver/internal/driverbase/statement.go
b/go/adbc/driver/internal/driverbase/statement.go
index 26312ff4f..5fa43da91 100644
--- a/go/adbc/driver/internal/driverbase/statement.go
+++ b/go/adbc/driver/internal/driverbase/statement.go
@@ -34,6 +34,7 @@ const (
type StatementImpl interface {
adbc.Statement
+ adbc.StatementExecuteSchema
adbc.GetSetOptions
adbc.OTelTracing
Base() *StatementImplBase
