This is an automated email from the ASF dual-hosted git repository.
curth pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git
The following commit(s) were added to refs/heads/main by this push:
new 8fa2a22ef chore(csharp/test/Drivers/Databricks): Split the Databricks
test into unit test and integration test (#3095)
8fa2a22ef is described below
commit 8fa2a22ef1b253bfa474f7db0d3a90477953b740
Author: Jacky Hu <[email protected]>
AuthorDate: Thu Jul 3 13:47:59 2025 -0700
chore(csharp/test/Drivers/Databricks): Split the Databricks test into unit
test and integration test (#3095)
# PR Description
### Motivation
The tests under `csharp/test/Drivers/Databricks` include both unit test
and E2E test, and E2E test depends on the connection setup with
Databricks and cannot (currently) be run by the CI/voter, but unit test
does not have this dependency and should be run by the CI to detect code
regression early. So we should restructure the tests into sub-folder
`Unit` and `E2E`.
### Changes
- Restructure the tests under `csharp/test/Drivers/Databricks` into
`Unit` and `E2E` folder
- Use namespace `Apache.Arrow.Adbc.Tests.Drivers.Databricks.Unit` as the
root namespace for all the Databricks unit test
- Update `ci/scripts/csharp_test.sh` to include Databricks unit test so
that it can be run by the CI
### Testing
- Run `ci/scripts/csharp_test.sh`
- Run both E2E test and unit test under `csharp/test/Drivers/Databricks`
---
ci/scripts/csharp_test.sh | 5 +++++
.../Databricks/{ => E2E}/Auth/OAuthClientCredentialsProviderTests.cs | 0
csharp/test/Drivers/Databricks/{ => E2E}/ClientTests.cs | 0
.../Databricks/{ => E2E}/CloudFetch/CloudFetchDownloaderTest.cs | 0
.../Databricks/{ => E2E}/CloudFetch/CloudFetchResultFetcherTest.cs | 0
csharp/test/Drivers/Databricks/{ => E2E}/CloudFetchE2ETest.cs | 0
csharp/test/Drivers/Databricks/{ => E2E}/ComplexTypesValueTests.cs | 0
csharp/test/Drivers/Databricks/{ => E2E}/DatabricksConnectionTest.cs | 0
.../test/Drivers/Databricks/{ => E2E}/DatabricksTestConfiguration.cs | 0
.../test/Drivers/Databricks/{ => E2E}/DatabricksTestEnvironment.cs | 0
csharp/test/Drivers/Databricks/{ => E2E}/DateTimeValueTests.cs | 0
csharp/test/Drivers/Databricks/{ => E2E}/DriverTests.cs | 0
csharp/test/Drivers/Databricks/{ => E2E}/NumericValueTests.cs | 0
.../test/Drivers/Databricks/{ => E2E}/ServerSidePropertyE2ETest.cs | 0
csharp/test/Drivers/Databricks/{ => E2E}/StatementTests.cs | 0
csharp/test/Drivers/Databricks/{ => E2E}/StringValueTests.cs | 0
.../Databricks/{ => Unit}/DatabricksOperationStatusPollerTests.cs | 2 +-
.../Databricks/{ => Unit}/Result/DescTableExtendedResultTest.cs | 2 +-
csharp/test/Drivers/Databricks/{ => Unit}/RetryHttpHandlerTest.cs | 2 +-
19 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/ci/scripts/csharp_test.sh b/ci/scripts/csharp_test.sh
index 4f79069be..da6ce98e2 100755
--- a/ci/scripts/csharp_test.sh
+++ b/ci/scripts/csharp_test.sh
@@ -24,3 +24,8 @@ source_dir=${1}/csharp/test/Apache.Arrow.Adbc.Tests
pushd ${source_dir}
dotnet test
popd
+
+source_dir=${1}/csharp/test/Drivers/Databricks
+pushd ${source_dir}
+dotnet test --filter
"FullyQualifiedName~Apache.Arrow.Adbc.Tests.Drivers.Databricks.Unit"
+popd
diff --git
a/csharp/test/Drivers/Databricks/Auth/OAuthClientCredentialsProviderTests.cs
b/csharp/test/Drivers/Databricks/E2E/Auth/OAuthClientCredentialsProviderTests.cs
similarity index 100%
rename from
csharp/test/Drivers/Databricks/Auth/OAuthClientCredentialsProviderTests.cs
rename to
csharp/test/Drivers/Databricks/E2E/Auth/OAuthClientCredentialsProviderTests.cs
diff --git a/csharp/test/Drivers/Databricks/ClientTests.cs
b/csharp/test/Drivers/Databricks/E2E/ClientTests.cs
similarity index 100%
rename from csharp/test/Drivers/Databricks/ClientTests.cs
rename to csharp/test/Drivers/Databricks/E2E/ClientTests.cs
diff --git
a/csharp/test/Drivers/Databricks/CloudFetch/CloudFetchDownloaderTest.cs
b/csharp/test/Drivers/Databricks/E2E/CloudFetch/CloudFetchDownloaderTest.cs
similarity index 100%
rename from
csharp/test/Drivers/Databricks/CloudFetch/CloudFetchDownloaderTest.cs
rename to
csharp/test/Drivers/Databricks/E2E/CloudFetch/CloudFetchDownloaderTest.cs
diff --git
a/csharp/test/Drivers/Databricks/CloudFetch/CloudFetchResultFetcherTest.cs
b/csharp/test/Drivers/Databricks/E2E/CloudFetch/CloudFetchResultFetcherTest.cs
similarity index 100%
rename from
csharp/test/Drivers/Databricks/CloudFetch/CloudFetchResultFetcherTest.cs
rename to
csharp/test/Drivers/Databricks/E2E/CloudFetch/CloudFetchResultFetcherTest.cs
diff --git a/csharp/test/Drivers/Databricks/CloudFetchE2ETest.cs
b/csharp/test/Drivers/Databricks/E2E/CloudFetchE2ETest.cs
similarity index 100%
rename from csharp/test/Drivers/Databricks/CloudFetchE2ETest.cs
rename to csharp/test/Drivers/Databricks/E2E/CloudFetchE2ETest.cs
diff --git a/csharp/test/Drivers/Databricks/ComplexTypesValueTests.cs
b/csharp/test/Drivers/Databricks/E2E/ComplexTypesValueTests.cs
similarity index 100%
rename from csharp/test/Drivers/Databricks/ComplexTypesValueTests.cs
rename to csharp/test/Drivers/Databricks/E2E/ComplexTypesValueTests.cs
diff --git a/csharp/test/Drivers/Databricks/DatabricksConnectionTest.cs
b/csharp/test/Drivers/Databricks/E2E/DatabricksConnectionTest.cs
similarity index 100%
rename from csharp/test/Drivers/Databricks/DatabricksConnectionTest.cs
rename to csharp/test/Drivers/Databricks/E2E/DatabricksConnectionTest.cs
diff --git a/csharp/test/Drivers/Databricks/DatabricksTestConfiguration.cs
b/csharp/test/Drivers/Databricks/E2E/DatabricksTestConfiguration.cs
similarity index 100%
rename from csharp/test/Drivers/Databricks/DatabricksTestConfiguration.cs
rename to csharp/test/Drivers/Databricks/E2E/DatabricksTestConfiguration.cs
diff --git a/csharp/test/Drivers/Databricks/DatabricksTestEnvironment.cs
b/csharp/test/Drivers/Databricks/E2E/DatabricksTestEnvironment.cs
similarity index 100%
rename from csharp/test/Drivers/Databricks/DatabricksTestEnvironment.cs
rename to csharp/test/Drivers/Databricks/E2E/DatabricksTestEnvironment.cs
diff --git a/csharp/test/Drivers/Databricks/DateTimeValueTests.cs
b/csharp/test/Drivers/Databricks/E2E/DateTimeValueTests.cs
similarity index 100%
rename from csharp/test/Drivers/Databricks/DateTimeValueTests.cs
rename to csharp/test/Drivers/Databricks/E2E/DateTimeValueTests.cs
diff --git a/csharp/test/Drivers/Databricks/DriverTests.cs
b/csharp/test/Drivers/Databricks/E2E/DriverTests.cs
similarity index 100%
rename from csharp/test/Drivers/Databricks/DriverTests.cs
rename to csharp/test/Drivers/Databricks/E2E/DriverTests.cs
diff --git a/csharp/test/Drivers/Databricks/NumericValueTests.cs
b/csharp/test/Drivers/Databricks/E2E/NumericValueTests.cs
similarity index 100%
rename from csharp/test/Drivers/Databricks/NumericValueTests.cs
rename to csharp/test/Drivers/Databricks/E2E/NumericValueTests.cs
diff --git a/csharp/test/Drivers/Databricks/ServerSidePropertyE2ETest.cs
b/csharp/test/Drivers/Databricks/E2E/ServerSidePropertyE2ETest.cs
similarity index 100%
rename from csharp/test/Drivers/Databricks/ServerSidePropertyE2ETest.cs
rename to csharp/test/Drivers/Databricks/E2E/ServerSidePropertyE2ETest.cs
diff --git a/csharp/test/Drivers/Databricks/StatementTests.cs
b/csharp/test/Drivers/Databricks/E2E/StatementTests.cs
similarity index 100%
rename from csharp/test/Drivers/Databricks/StatementTests.cs
rename to csharp/test/Drivers/Databricks/E2E/StatementTests.cs
diff --git a/csharp/test/Drivers/Databricks/StringValueTests.cs
b/csharp/test/Drivers/Databricks/E2E/StringValueTests.cs
similarity index 100%
rename from csharp/test/Drivers/Databricks/StringValueTests.cs
rename to csharp/test/Drivers/Databricks/E2E/StringValueTests.cs
diff --git
a/csharp/test/Drivers/Databricks/DatabricksOperationStatusPollerTests.cs
b/csharp/test/Drivers/Databricks/Unit/DatabricksOperationStatusPollerTests.cs
similarity index 98%
rename from
csharp/test/Drivers/Databricks/DatabricksOperationStatusPollerTests.cs
rename to
csharp/test/Drivers/Databricks/Unit/DatabricksOperationStatusPollerTests.cs
index c72326a62..a8f23fb66 100644
--- a/csharp/test/Drivers/Databricks/DatabricksOperationStatusPollerTests.cs
+++
b/csharp/test/Drivers/Databricks/Unit/DatabricksOperationStatusPollerTests.cs
@@ -25,7 +25,7 @@ using Moq;
using Xunit;
using Xunit.Abstractions;
-namespace Apache.Arrow.Adbc.Tests.Drivers.Databricks
+namespace Apache.Arrow.Adbc.Tests.Drivers.Databricks.Unit
{
public class DatabricksOperationStatusPollerTests
{
diff --git
a/csharp/test/Drivers/Databricks/Result/DescTableExtendedResultTest.cs
b/csharp/test/Drivers/Databricks/Unit/Result/DescTableExtendedResultTest.cs
similarity index 99%
rename from csharp/test/Drivers/Databricks/Result/DescTableExtendedResultTest.cs
rename to
csharp/test/Drivers/Databricks/Unit/Result/DescTableExtendedResultTest.cs
index 93a29ad36..651334d65 100644
--- a/csharp/test/Drivers/Databricks/Result/DescTableExtendedResultTest.cs
+++ b/csharp/test/Drivers/Databricks/Unit/Result/DescTableExtendedResultTest.cs
@@ -23,7 +23,7 @@ using static
Apache.Arrow.Adbc.Drivers.Apache.Hive2.HiveServer2Connection;
using Xunit;
-namespace Apache.Arrow.Adbc.Tests.Drivers.Databricks.Result
+namespace Apache.Arrow.Adbc.Tests.Drivers.Databricks.Unit.Result
{
public class DescTableExtendedResultTest
{
diff --git a/csharp/test/Drivers/Databricks/RetryHttpHandlerTest.cs
b/csharp/test/Drivers/Databricks/Unit/RetryHttpHandlerTest.cs
similarity index 99%
rename from csharp/test/Drivers/Databricks/RetryHttpHandlerTest.cs
rename to csharp/test/Drivers/Databricks/Unit/RetryHttpHandlerTest.cs
index e0849593f..0aa8ba55a 100644
--- a/csharp/test/Drivers/Databricks/RetryHttpHandlerTest.cs
+++ b/csharp/test/Drivers/Databricks/Unit/RetryHttpHandlerTest.cs
@@ -22,7 +22,7 @@ using System.Threading.Tasks;
using Apache.Arrow.Adbc.Drivers.Databricks;
using Xunit;
-namespace Apache.Arrow.Adbc.Tests.Drivers.Databricks
+namespace Apache.Arrow.Adbc.Tests.Drivers.Databricks.Unit
{
/// <summary>
/// Tests for the RetryHttpHandler class.
