This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
The following commit(s) were added to refs/heads/main by this push:
new 16794ab14f Minor: Restore warning comment on Int96 statistics read
(#7975)
16794ab14f is described below
commit 16794ab14fa62ecf67de0da9460cc5752a9358f4
Author: Andrew Lamb <[email protected]>
AuthorDate: Wed Jul 23 16:47:18 2025 -0400
Minor: Restore warning comment on Int96 statistics read (#7975)
# Which issue does this PR close?
- Follow on to https://github.com/apache/arrow-rs/pull/7687
# Rationale for this change
I merged https://github.com/apache/arrow-rs/pull/7687 without addressing
one of @emkornfield 's suggestions:
https://github.com/apache/arrow-rs/pull/7687/files#r2205393903
# What changes are included in this PR?
Implement the suggestion (restore a comment_
# Are these changes tested?
BY CI
# Are there any user-facing changes?
No
---
parquet/src/file/statistics.rs | 1 +
1 file changed, 1 insertion(+)
diff --git a/parquet/src/file/statistics.rs b/parquet/src/file/statistics.rs
index d0105461f1..02729a5016 100644
--- a/parquet/src/file/statistics.rs
+++ b/parquet/src/file/statistics.rs
@@ -209,6 +209,7 @@ pub fn from_thrift(
old_format,
),
Type::INT96 => {
+ // INT96 statistics may not be correct, because comparison
is signed
let min = if let Some(data) = min {
assert_eq!(data.len(), 12);
Some(Int96::try_from_le_slice(&data)?)
