This is an automated email from the ASF dual-hosted git repository.

alamb pushed a commit to branch shredding-variant-part1
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git

commit 61bca91e0f099bb124ff891e8e27f8971ec7906c
Author: Andrew Lamb <and...@nerdnetworks.org>
AuthorDate: Thu Sep 4 16:33:17 2025 -0400

    Fix clippy
---
 parquet-variant-compute/src/variant_get/mod.rs | 35 ++++++++------------------
 1 file changed, 11 insertions(+), 24 deletions(-)

diff --git a/parquet-variant-compute/src/variant_get/mod.rs 
b/parquet-variant-compute/src/variant_get/mod.rs
index 64d6c3980f..7f4176989d 100644
--- a/parquet-variant-compute/src/variant_get/mod.rs
+++ b/parquet-variant-compute/src/variant_get/mod.rs
@@ -1159,17 +1159,12 @@ mod test {
     fn create_depth_1_shredded_test_data_working() -> ArrayRef {
         // Create metadata following the working pattern from 
shredded_object_with_x_field_variant_array
         let (metadata, _) = {
-            // Create nested structure: {"a": {"x": 55}, "b": 42}
-            let a_variant = {
-                let mut a_builder = parquet_variant::VariantBuilder::new();
-                let mut a_obj = a_builder.new_object();
-                a_obj.insert("x", Variant::Int32(55));  // "a.x" field 
(shredded when possible)
-                a_obj.finish().unwrap()
-            };
-            
             let mut builder = parquet_variant::VariantBuilder::new();
+            // Create nested structure: {"a": {"x": 55}, "b": 42}
             let mut obj = builder.new_object();
-            obj.insert("a", a_variant); 
+            let mut a_obj = obj.new_object("x");
+            a_obj.insert("x", Variant::Int32(55));  // "a.x" field (shredded 
when possible)
+            a_obj.finish().unwrap();
             obj.insert("b", Variant::Int32(42));
             obj.finish().unwrap();
             builder.finish()
@@ -1273,23 +1268,15 @@ mod test {
         // Create metadata following the working pattern
         let (metadata, _) = {
             // Create deeply nested structure: {"a": {"b": {"x": 100}}}
-            let b_variant = {
-                let mut b_builder = parquet_variant::VariantBuilder::new();
-                let mut b_obj = b_builder.new_object();
-                b_obj.insert("x", Variant::Int32(100));
-                b_obj.finish().unwrap()
-            };
-            
-            let a_variant = {
-                let mut a_builder = parquet_variant::VariantBuilder::new();
-                let mut a_obj = a_builder.new_object();
-                a_obj.insert("b", b_variant);
-                a_obj.finish().unwrap()
-            };
-            
+
             let mut builder = parquet_variant::VariantBuilder::new();
+            // Create deeply nested structure: {"a": {"b": {"x": 100}}}
             let mut obj = builder.new_object();
-            obj.insert("a", a_variant);  // "a" field containing b
+            let mut a_obj = obj.new_object("a");
+            let mut b_obj = a_obj.new_object("b");
+            b_obj.insert("x", Variant::Int32(100));  // "a.b.x" field 
(shredded when possible)
+            b_obj.finish().unwrap();
+            a_obj.finish().unwrap();
             obj.finish().unwrap();
             builder.finish()
         };

Reply via email to