This is an automated email from the ASF dual-hosted git repository.
curth pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git
The following commit(s) were added to refs/heads/main by this push:
new e9d70e4a3 chore(csharp): Bump DuckDB.NET.Bindings.Full from 1.3.0 to
1.4.1 (#3587)
e9d70e4a3 is described below
commit e9d70e4a3a48b1afc92f437c4e61acb96e4688ec
Author: Curt Hagenlocher <[email protected]>
AuthorDate: Fri Oct 17 13:08:17 2025 -0700
chore(csharp): Bump DuckDB.NET.Bindings.Full from 1.3.0 to 1.4.1 (#3587)
The dependabot PR is failing because of a change in behavior of DuckDb
which I've filed as
[https://github.com/duckdb/duckdb/issues/19443](https://github.com/duckdb/duckdb/issues/19443).
---
csharp/Benchmarks/Benchmarks.csproj | 2 +-
.../Apache.Arrow.Adbc.Tests/Apache.Arrow.Adbc.Tests.csproj | 2 +-
.../test/Apache.Arrow.Adbc.Tests/Client/DuckDbClientTests.cs | 10 +++++++++-
csharp/test/Apache.Arrow.Adbc.Tests/ImportedDuckDbTests.cs | 10 +++++++++-
4 files changed, 20 insertions(+), 4 deletions(-)
diff --git a/csharp/Benchmarks/Benchmarks.csproj
b/csharp/Benchmarks/Benchmarks.csproj
index 96e6f4f42..9e22a9025 100644
--- a/csharp/Benchmarks/Benchmarks.csproj
+++ b/csharp/Benchmarks/Benchmarks.csproj
@@ -10,7 +10,7 @@
<ItemGroup>
<PackageReference Include="BenchmarkDotNet" Version="0.15.4" />
- <PackageReference Include="DuckDB.NET.Bindings.Full" Version="1.3.0"
GeneratePathProperty="true" />
+ <PackageReference Include="DuckDB.NET.Bindings.Full" Version="1.4.1"
GeneratePathProperty="true" />
</ItemGroup>
<ItemGroup>
diff --git a/csharp/test/Apache.Arrow.Adbc.Tests/Apache.Arrow.Adbc.Tests.csproj
b/csharp/test/Apache.Arrow.Adbc.Tests/Apache.Arrow.Adbc.Tests.csproj
index 20a4bb948..010fad68f 100644
--- a/csharp/test/Apache.Arrow.Adbc.Tests/Apache.Arrow.Adbc.Tests.csproj
+++ b/csharp/test/Apache.Arrow.Adbc.Tests/Apache.Arrow.Adbc.Tests.csproj
@@ -19,7 +19,7 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles;
analyzers</IncludeAssets>
</PackageReference>
- <PackageReference Include="DuckDB.NET.Bindings.Full" Version="1.3.0"
GeneratePathProperty="true" />
+ <PackageReference Include="DuckDB.NET.Bindings.Full" Version="1.4.1"
GeneratePathProperty="true" />
<PackageReference Include="Xunit.SkippableFact" Version="1.5.23" />
</ItemGroup>
diff --git a/csharp/test/Apache.Arrow.Adbc.Tests/Client/DuckDbClientTests.cs
b/csharp/test/Apache.Arrow.Adbc.Tests/Client/DuckDbClientTests.cs
index 0a8e89d82..d41b82aef 100644
--- a/csharp/test/Apache.Arrow.Adbc.Tests/Client/DuckDbClientTests.cs
+++ b/csharp/test/Apache.Arrow.Adbc.Tests/Client/DuckDbClientTests.cs
@@ -16,6 +16,7 @@
*/
using System.Data;
+using System.Runtime.InteropServices;
using Apache.Arrow.Adbc.Client;
using Apache.Arrow.Types;
using Xunit;
@@ -128,7 +129,14 @@ namespace Apache.Arrow.Adbc.Tests.Client
command.CommandText = "select ?, ?";
command.Prepare();
Assert.Equal(2, command.Parameters.Count);
- Assert.Equal("0", command.Parameters[0].ParameterName);
+ if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+ {
+ Assert.Equal(string.Empty,
command.Parameters[0].ParameterName);
+ }
+ else
+ {
+ Assert.Equal("0", command.Parameters[0].ParameterName);
+ }
Assert.Equal(DbType.Object, command.Parameters[0].DbType);
Assert.Equal("1", command.Parameters[1].ParameterName);
Assert.Equal(DbType.Object, command.Parameters[1].DbType);
diff --git a/csharp/test/Apache.Arrow.Adbc.Tests/ImportedDuckDbTests.cs
b/csharp/test/Apache.Arrow.Adbc.Tests/ImportedDuckDbTests.cs
index 63bc1022b..eeec6baa5 100644
--- a/csharp/test/Apache.Arrow.Adbc.Tests/ImportedDuckDbTests.cs
+++ b/csharp/test/Apache.Arrow.Adbc.Tests/ImportedDuckDbTests.cs
@@ -17,6 +17,7 @@
using System;
using System.Collections.Generic;
+using System.Runtime.InteropServices;
using System.Threading.Tasks;
using Apache.Arrow.Types;
using Xunit;
@@ -220,7 +221,14 @@ namespace Apache.Arrow.Adbc.Tests
statement.Prepare();
var schema = statement.GetParameterSchema();
Assert.Equal(2, schema.FieldsList.Count);
- Assert.Equal("0", schema.FieldsList[0].Name);
+ if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+ {
+ Assert.Equal(string.Empty, schema.FieldsList[0].Name);
+ }
+ else
+ {
+ Assert.Equal("0", schema.FieldsList[0].Name);
+ }
Assert.Equal(ArrowTypeId.Null,
schema.FieldsList[0].DataType.TypeId);
Assert.Equal("1", schema.FieldsList[1].Name);
Assert.Equal(ArrowTypeId.Null,
schema.FieldsList[1].DataType.TypeId);