This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
The following commit(s) were added to refs/heads/main by this push:
new 63f58c50ab chore: use magic number`FOOTER_SIZE` instead of hard code
number (#8585)
63f58c50ab is described below
commit 63f58c50abdf9d8a9e82db3065d4e5fe9e327c8b
Author: lichuang <[email protected]>
AuthorDate: Sat Oct 11 04:24:33 2025 +0800
chore: use magic number`FOOTER_SIZE` instead of hard code number (#8585)
# Which issue does this PR close?
chore: use magic number instead of hard code number, make the code more
clearly.
# Rationale for this change
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
# What changes are included in this PR?
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
# Are these changes tested?
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
# Are there any user-facing changes?
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.
---
parquet/src/file/metadata/reader.rs | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/parquet/src/file/metadata/reader.rs
b/parquet/src/file/metadata/reader.rs
index c8befa399d..231741de03 100644
--- a/parquet/src/file/metadata/reader.rs
+++ b/parquet/src/file/metadata/reader.rs
@@ -542,9 +542,9 @@ impl ParquetMetaDataReader {
return Err(ParquetError::NeedMoreData(FOOTER_SIZE));
}
- let mut footer = [0_u8; 8];
+ let mut footer = [0_u8; FOOTER_SIZE];
chunk_reader
- .get_read(file_size - 8)?
+ .get_read(file_size - FOOTER_SIZE as u64)?
.read_exact(&mut footer)?;
let footer = FooterTail::try_new(&footer)?;
@@ -844,7 +844,7 @@ mod tests {
let err = ParquetMetaDataReader::new()
.parse_metadata(&test_file)
.unwrap_err();
- assert!(matches!(err, ParquetError::NeedMoreData(8)));
+ assert!(matches!(err, ParquetError::NeedMoreData(FOOTER_SIZE)));
}
#[test]
