This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 7e3aad71c4 GH-47933: [Release][R] Don't upload *.sha512.{asc,sha512} 
(#47982)
7e3aad71c4 is described below

commit 7e3aad71c49c11ec6593565d1292208dcd58a2da
Author: Nic Crane <[email protected]>
AuthorDate: Wed Oct 29 01:25:01 2025 +0000

    GH-47933: [Release][R] Don't upload *.sha512.{asc,sha512} (#47982)
    
    ### Rationale for this change
    
    R binary CI jobs already create `.sha512` checksum files, but the upload 
script was signing and checksumming them again, creating redundant 
`.sha512.asc`  and `.sha512.sha512` files.
    
    ### What changes are included in this PR?
    
    Skip signing and checksumming for files that already end in `.sha512`.
    
    ### Are these changes tested?
    
    Reviewed manually. The bash pattern matching correctly identifies and skips 
`.sha512` files.
    
    ### Are there any user-facing changes?
    
    No. This only reduces redundant files in release artifacts.
    
    * GitHub Issue: #47933
    
    Authored-by: Nic Crane <[email protected]>
    Signed-off-by: Sutou Kouhei <[email protected]>
---
 dev/release/05-binary-upload.sh | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/dev/release/05-binary-upload.sh b/dev/release/05-binary-upload.sh
index 04707cbde7..f628cce0e0 100755
--- a/dev/release/05-binary-upload.sh
+++ b/dev/release/05-binary-upload.sh
@@ -86,15 +86,18 @@ upload_to_github_release() {
     local base_name
     base_name="$(basename "${target}")"
     cp -a "${target}" "${dist_dir}/${base_name}"
-    gpg \
-      --armor \
-      --detach-sign \
-      --local-user "${GPG_KEY_ID}" \
-      --output "${dist_dir}/${base_name}.asc" \
-      "${target}"
-    pushd "${dist_dir}"
-    shasum -a 512 "${base_name}" >"${base_name}.sha512"
-    popd
+    # Skip signing/checksumming .sha512 files (e.g., R binaries already 
include checksums from CI)
+    if [[ "${base_name}" != *.sha512 ]]; then
+      gpg \
+        --armor \
+        --detach-sign \
+        --local-user "${GPG_KEY_ID}" \
+        --output "${dist_dir}/${base_name}.asc" \
+        "${target}"
+      pushd "${dist_dir}"
+      shasum -a 512 "${base_name}" >"${base_name}.sha512"
+      popd
+    fi
   done
   gh release upload \
     --repo apache/arrow \

Reply via email to