This is an automated email from the ASF dual-hosted git repository.
jeffreyvo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
The following commit(s) were added to refs/heads/main by this push:
new 4b3da3d001 Uncomment part of test_utf8_single_column_reader_test
(#9148)
4b3da3d001 is described below
commit 4b3da3d001c652fa29e732f44b6b9043d078b61e
Author: Kosta Tarasov <[email protected]>
AuthorDate: Mon Jan 12 21:19:28 2026 -0500
Uncomment part of test_utf8_single_column_reader_test (#9148)
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax.
-->
- Closes #9147 .
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
Check issue
<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
# Are these changes tested?
It's a test
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
# Are there any user-facing changes?
No
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.
-->
---
parquet/src/arrow/arrow_reader/mod.rs | 31 +++++++++++++++----------------
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/parquet/src/arrow/arrow_reader/mod.rs
b/parquet/src/arrow/arrow_reader/mod.rs
index f8ab07cba4..3e7714a3b6 100644
--- a/parquet/src/arrow/arrow_reader/mod.rs
+++ b/parquet/src/arrow/arrow_reader/mod.rs
@@ -2435,22 +2435,21 @@ pub(crate) mod tests {
encodings,
);
- // https://github.com/apache/arrow-rs/issues/1179
- // let data_type = ArrowDataType::Dictionary(
- // Box::new(key.clone()),
- // Box::new(ArrowDataType::LargeUtf8),
- // );
- //
- // run_single_column_reader_tests::<ByteArrayType, _, RandUtf8Gen>(
- // 2,
- // ConvertedType::UTF8,
- // Some(data_type.clone()),
- // move |vals| {
- // let vals = string_converter::<i64>(vals);
- // arrow::compute::cast(&vals, &data_type).unwrap()
- // },
- // encodings,
- // );
+ let data_type = ArrowDataType::Dictionary(
+ Box::new(key.clone()),
+ Box::new(ArrowDataType::LargeUtf8),
+ );
+
+ run_single_column_reader_tests::<ByteArrayType, _, RandUtf8Gen>(
+ 2,
+ ConvertedType::UTF8,
+ Some(data_type.clone()),
+ move |vals| {
+ let vals = string_converter::<i64>(vals);
+ arrow::compute::cast(&vals, &data_type).unwrap()
+ },
+ encodings,
+ );
}
}
