This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
The following commit(s) were added to refs/heads/main by this push:
new 5695bb3374 fix: support casting string to f16 (#9262)
5695bb3374 is described below
commit 5695bb33746735dde01b80ee9e7e6bcccbd7bdd4
Author: Jeffrey Vo <[email protected]>
AuthorDate: Sat Jan 31 03:18:13 2026 +0900
fix: support casting string to f16 (#9262)
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax.
-->
- N/A
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
Extend some cast support to float16
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
Support casting string arrays to float16
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
Added tests
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.
-->
No
---
arrow-cast/src/cast/mod.rs | 39 ++++++++++++++++++++++++---------------
1 file changed, 24 insertions(+), 15 deletions(-)
diff --git a/arrow-cast/src/cast/mod.rs b/arrow-cast/src/cast/mod.rs
index 736a427ec0..34416eb91b 100644
--- a/arrow-cast/src/cast/mod.rs
+++ b/arrow-cast/src/cast/mod.rs
@@ -241,20 +241,9 @@ pub fn can_cast_types(from_type: &DataType, to_type:
&DataType) -> bool {
}
(Struct(_), _) => false,
(_, Struct(_)) => false,
- (_, Boolean) => {
- DataType::is_integer(from_type)
- || DataType::is_floating(from_type)
- || from_type == &Utf8View
- || from_type == &Utf8
- || from_type == &LargeUtf8
- }
- (Boolean, _) => {
- DataType::is_integer(to_type)
- || DataType::is_floating(to_type)
- || to_type == &Utf8View
- || to_type == &Utf8
- || to_type == &LargeUtf8
- }
+
+ (_, Boolean) => from_type.is_integer() || from_type.is_floating() ||
from_type.is_string(),
+ (Boolean, _) => to_type.is_integer() || to_type.is_floating() ||
to_type.is_string(),
(Binary, LargeBinary | Utf8 | LargeUtf8 | FixedSizeBinary(_) |
BinaryView | Utf8View) => {
true
@@ -284,7 +273,7 @@ pub fn can_cast_types(from_type: &DataType, to_type:
&DataType) -> bool {
) => true,
(Utf8 | LargeUtf8, Utf8View) => true,
(BinaryView, Binary | LargeBinary | Utf8 | LargeUtf8 | Utf8View) =>
true,
- (Utf8View | Utf8 | LargeUtf8, _) => to_type.is_numeric() && to_type !=
&Float16,
+ (Utf8View | Utf8 | LargeUtf8, _) => to_type.is_numeric(),
(_, Utf8 | Utf8View | LargeUtf8) => from_type.is_primitive(),
(_, Binary | LargeBinary) => from_type.is_integer(),
@@ -1217,6 +1206,7 @@ pub fn cast_with_options(
Int16 => parse_string::<Int16Type, i32>(array, cast_options),
Int32 => parse_string::<Int32Type, i32>(array, cast_options),
Int64 => parse_string::<Int64Type, i32>(array, cast_options),
+ Float16 => parse_string::<Float16Type, i32>(array, cast_options),
Float32 => parse_string::<Float32Type, i32>(array, cast_options),
Float64 => parse_string::<Float64Type, i32>(array, cast_options),
Date32 => parse_string::<Date32Type, i32>(array, cast_options),
@@ -1279,6 +1269,7 @@ pub fn cast_with_options(
Int16 => parse_string_view::<Int16Type>(array, cast_options),
Int32 => parse_string_view::<Int32Type>(array, cast_options),
Int64 => parse_string_view::<Int64Type>(array, cast_options),
+ Float16 => parse_string_view::<Float16Type>(array, cast_options),
Float32 => parse_string_view::<Float32Type>(array, cast_options),
Float64 => parse_string_view::<Float64Type>(array, cast_options),
Date32 => parse_string_view::<Date32Type>(array, cast_options),
@@ -1330,6 +1321,7 @@ pub fn cast_with_options(
Int16 => parse_string::<Int16Type, i64>(array, cast_options),
Int32 => parse_string::<Int32Type, i64>(array, cast_options),
Int64 => parse_string::<Int64Type, i64>(array, cast_options),
+ Float16 => parse_string::<Float16Type, i64>(array, cast_options),
Float32 => parse_string::<Float32Type, i64>(array, cast_options),
Float64 => parse_string::<Float64Type, i64>(array, cast_options),
Date32 => parse_string::<Date32Type, i64>(array, cast_options),
@@ -4572,6 +4564,23 @@ mod tests {
assert_eq!(8.9, c.value(3));
}
+ #[test]
+ fn test_cast_string_to_f16() {
+ let arrays = [
+ Arc::new(StringViewArray::from(vec!["3", "4.56", "seven", "8.9"]))
as ArrayRef,
+ Arc::new(StringArray::from(vec!["3", "4.56", "seven", "8.9"])),
+ Arc::new(LargeStringArray::from(vec!["3", "4.56", "seven",
"8.9"])),
+ ];
+ for array in arrays {
+ let b = cast(&array, &DataType::Float16).unwrap();
+ let c = b.as_primitive::<Float16Type>();
+ assert_eq!(half::f16::from_f32(3.0), c.value(0));
+ assert_eq!(half::f16::from_f32(4.56), c.value(1));
+ assert!(!c.is_valid(2));
+ assert_eq!(half::f16::from_f32(8.9), c.value(3));
+ }
+ }
+
#[test]
fn test_cast_utf8view_to_decimal128() {
let array = StringViewArray::from(vec![None, Some("4"), Some("5.6"),
Some("7.89")]);
