This is an automated email from the ASF dual-hosted git repository.

lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git


The following commit(s) were added to refs/heads/main by this push:
     new d8bd708e0 ci: build windows artifacts in release mode in packaging 
workflow (#4099)
d8bd708e0 is described below

commit d8bd708e0ba41d894a40e89975ead35fed981f0e
Author: Bryce Mecum <[email protected]>
AuthorDate: Tue Mar 17 17:25:13 2026 -0700

    ci: build windows artifacts in release mode in packaging workflow (#4099)
    
    Fixes an issue with the packaging.yaml workflow which was causing at
    least the windows JNI driver to get built in debug mode instead of
    release mode. My understanding of the issue is that when you use MSVC as
    a generator for CMake, it ignores CMAKE_BUILD_TYPE (defaults to Debug)
    so we need to pass it down correctly and set `--config` explicitly.
---
 .github/workflows/packaging.yml | 2 +-
 ci/scripts/cpp_build.sh         | 2 +-
 ci/scripts/java_jni_build.sh    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/packaging.yml b/.github/workflows/packaging.yml
index e8eef34f3..94b0dd2a5 100644
--- a/.github/workflows/packaging.yml
+++ b/.github/workflows/packaging.yml
@@ -283,7 +283,7 @@ jobs:
           ADBC_USE_UBSAN: OFF
           BUILD_ALL: 0
           BUILD_DRIVER_MANAGER: 1
-          CMAKE_BUILD_TYPE: release
+          CMAKE_BUILD_TYPE: Release
         run: |
           ./ci/scripts/cpp_build.sh $(pwd) $(pwd)/build_driver_manager
           ./ci/scripts/java_build.sh $(pwd)
diff --git a/ci/scripts/cpp_build.sh b/ci/scripts/cpp_build.sh
index 50901c5df..4f271442c 100755
--- a/ci/scripts/cpp_build.sh
+++ b/ci/scripts/cpp_build.sh
@@ -74,7 +74,7 @@ build_subproject() {
           
-DADBC_DRIVER_MANAGER_TEST_MANIFEST_SYSTEM_LEVEL="${BUILD_DRIVER_MANAGER_SYSTEM_CONFIG_TEST}"
 \
           
-DADBC_DRIVER_MANAGER_TEST_MANIFEST_USER_LEVEL="${BUILD_DRIVER_MANAGER_USER_CONFIG_TEST}"
     set +x
-    cmake --build . --target install -j
+    cmake --build . --config ${CMAKE_BUILD_TYPE} --target install -j
 
     popd
 }
diff --git a/ci/scripts/java_jni_build.sh b/ci/scripts/java_jni_build.sh
index 6ccfb183a..fa2b88abf 100755
--- a/ci/scripts/java_jni_build.sh
+++ b/ci/scripts/java_jni_build.sh
@@ -37,7 +37,7 @@ main() {
         -DCMAKE_PREFIX_PATH="${install_dir}/lib/cmake/"
     set +x
 
-    cmake --build . --target install -j
+    cmake --build . --config ${CMAKE_BUILD_TYPE} --target install -j
 
     popd
 }

Reply via email to