This is an automated email from the ASF dual-hosted git repository.
kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 4fce185a1a GH-50115: [Dev] Adjust GitHub Copilot configuration for
preliminary reviews (#50117)
4fce185a1a is described below
commit 4fce185a1a34dd6b409260c142e6e4e148f43995
Author: Sutou Kouhei <[email protected]>
AuthorDate: Sun Jun 14 17:40:42 2026 +0900
GH-50115: [Dev] Adjust GitHub Copilot configuration for preliminary reviews
(#50117)
### Rationale for this change
We tried auto GitHub Copilot reviews recently and discussed our experience
for them:
https://lists.apache.org/thread/thq0dz19shxbrjypb81q5ltx8h0w54ob
We want to tune auto GitHub Copilot reviews:
* We don't need auto GitHub Copilot reviews for draft PR:
https://lists.apache.org/thread/y7yc4yg9n4mdqd1y00w7s498y8m6yold
* GitHub Copilot review is too verbose:
https://github.com/apache/arrow/pull/50023#issuecomment-4535261566
* We need to document the expectation for contributors responding to GitHub
Copilot reviews:
https://lists.apache.org/thread/wvhdqqtq2ndxxjnqwnj39xfcys21tpc4
### What changes are included in this PR?
* Disable auto GitHub Copilot reviews for draft PR
* Add code review instructions for GitHub Copilot
* Base text is generated by Gemini 3 Flash Preview and I adjusted it
### Are these changes tested?
No. We need to merge this to test this.
### Are there any user-facing changes?
No.
* GitHub Issue: #50115
Lead-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Raúl Cumplido <[email protected]>
Co-authored-by: Andrew Lamb <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
---
.asf.yaml | 2 +-
.github/copilot-instructions.md | 21 +++++++++++++++++++++
dev/release/rat_exclude_files.txt | 1 +
docs/source/developers/overview.rst | 5 +++++
4 files changed, 28 insertions(+), 1 deletion(-)
diff --git a/.asf.yaml b/.asf.yaml
index 3235f15a44..6463a35a87 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -41,7 +41,7 @@ github:
copilot_code_review:
enabled: true
- review_drafts: true
+ review_drafts: false
review_on_push: true
notifications:
diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md
new file mode 100644
index 0000000000..e4a8ef0269
--- /dev/null
+++ b/.github/copilot-instructions.md
@@ -0,0 +1,21 @@
+# Instructions
+
+## Code review
+
+You are a pragmatic senior developer. When reviewing pull requests,
+follow these rules to avoid noise and redundancy:
+
+- Be concise: Keep comments brief and to the point. Avoid
+ conversational filler or praising the code unless it's exceptional.
+- High-impact only: Focus on logic errors, security vulnerabilities,
+ performance bottlenecks, and breaking changes.
+- Skip the Obvious: Do not describe what the code is doing. Assume the
+ reader understands the code.
+- Ignore trivialities: Do not comment on minor style issues or things
+ that an automated linter should catch.
+- Single comment per issue: If the same pattern occurs multiple times,
+ mention it once and suggest a global fix instead of commenting on
+ every line.
+- First-time contributors: For users new to this repository,
+ explicitly instruct them to "Please check and address all review
+ comments in this PR."
diff --git a/dev/release/rat_exclude_files.txt
b/dev/release/rat_exclude_files.txt
index f9e1cebcd7..7b3f9eebe5 100644
--- a/dev/release/rat_exclude_files.txt
+++ b/dev/release/rat_exclude_files.txt
@@ -101,4 +101,5 @@ r/tools/nixlibs-allowlist.txt
.gitattributes
ruby/red-arrow/.yardopts
ruby/red-arrow-format/lib/arrow-format/org/*
+.github/copilot-instructions.md
.github/pull_request_template.md
diff --git a/docs/source/developers/overview.rst
b/docs/source/developers/overview.rst
index e91d1c28ac..3b87750232 100644
--- a/docs/source/developers/overview.rst
+++ b/docs/source/developers/overview.rst
@@ -104,6 +104,11 @@ When contributing a patch, use this list as a checklist of
Apache Arrow workflow
merged, this will be retained in the extended commit message.
* Make sure that your code **passes the unit tests**. You can find
instructions how
to run the unit tests for each Arrow component in its respective README file.
+* In order to improve our code and your review experience, we have
+ enabled GitHub Copilot reviews to automate the first pass. Reviewers
+ and contributors are encouraged to address valid suggestions; you
+ don't need to respond to every comment, but please don't ignore them
+ either.
Core developers and others with a stake in the part of the project your change
affects will review, request changes, and hopefully indicate their approval
