This is an automated email from the ASF dual-hosted git repository.
paleolimbot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-nanoarrow.git
The following commit(s) were added to refs/heads/main by this push:
new 72076b35 chore: Fix flatcc linking for non-bundled case (#894)
72076b35 is described below
commit 72076b358a8eddaad27a97b7d895ecbac56be2ce
Author: Dewey Dunnington <[email protected]>
AuthorDate: Sat Jun 20 01:17:09 2026 +0000
chore: Fix flatcc linking for non-bundled case (#894)
It looks as though nanoarrow's IPC feature was added upstream in vcpkg
before I could get there; however, required a patch in the flatcc
linking (and an update to flatcc, which was also done).
This PR applies the patch with some input from Opus 4.5 that will
hopefully help the process (and help get the IPC feature build for
homebrew as well).
Closes #796
---
CMakeLists.txt | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 2d808493..d03c42a4 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -221,7 +221,7 @@ if(NANOARROW_IPC)
add_library(flatccrt STATIC IMPORTED)
set_target_properties(flatccrt
PROPERTIES IMPORTED_LOCATION
-
"${NANOARROW_FLATCC_LIB_DIR}/libflatccrt.a"
+
"${NANOARROW_FLATCC_LIB_DIR}/${CMAKE_STATIC_LIBRARY_PREFIX}flatccrt${CMAKE_STATIC_LIBRARY_SUFFIX}"
INTERFACE_INCLUDE_DIRECTORIES
"${NANOARROW_FLATCC_INCLUDE_DIR}")
@@ -230,7 +230,11 @@ if(NANOARROW_IPC)
add_library(flatccrt STATIC IMPORTED)
set_target_properties(flatccrt
PROPERTIES IMPORTED_LOCATION
-
"${NANOARROW_FLATCC_ROOT_DIR}/lib/libflatccrt.a"
+
"${NANOARROW_FLATCC_ROOT_DIR}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}flatccrt${CMAKE_STATIC_LIBRARY_SUFFIX}"
+ IMPORTED_LOCATION_DEBUG
+
"${NANOARROW_FLATCC_ROOT_DIR}/debug/lib/${CMAKE_STATIC_LIBRARY_PREFIX}flatccrt_d${CMAKE_STATIC_LIBRARY_SUFFIX}"
+ IMPORTED_LOCATION_RELEASE
+
"${NANOARROW_FLATCC_ROOT_DIR}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}flatccrt${CMAKE_STATIC_LIBRARY_SUFFIX}"
INTERFACE_INCLUDE_DIRECTORIES
"${NANOARROW_FLATCC_INCLUDE_DIR}")
endif()
