This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
The following commit(s) were added to refs/heads/main by this push:
new 3ed472165c test(arrow-select): add take_bytes coverage for sliced
values and nullable offset overflow (#10053)
3ed472165c is described below
commit 3ed472165c4f8d980b7b83c33e2fd359b25fcaa4
Author: Andrew Lamb <[email protected]>
AuthorDate: Mon Jun 22 14:00:33 2026 -0400
test(arrow-select): add take_bytes coverage for sliced values and nullable
offset overflow (#10053)
# Which issue does this PR close?
- test-only follow-up to #9625.
# Rationale for this change
While reviewing #9625 (which rewrites `take_bytes`), I noticed two paths
in the existing test suite were not directly exercised:
1. **Taking from a *sliced* byte array**
2. **The `OffsetOverflowError` on the nullable path** —
`test_take_bytes_offset_overflow` only uses non-null indices, so it only
covers the no-null fast path.
I can write tests which pass against `main` today and show the existing
behavior give #9625 (and future `take_bytes` changes) better coverage of
the byte-copy and overflow paths.
# What changes are included in this PR?
Two new tests in `arrow-select/src/take.rs`:
# Are these changes tested?
These changes *are* tests. They pass on the current implementation.
# Are there any user-facing changes?
None.
---------
Co-authored-by: Claude Opus 4.8 (1M context) <[email protected]>
