This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 8e574ad0bd GH-50417: [CI][Dev] Fix shellcheck error in 
ci/scripts/install_bison.sh (#50418)
8e574ad0bd is described below

commit 8e574ad0bd0aa58fa6a49246bede862b45f3a404
Author: Hiroyuki Sato <[email protected]>
AuthorDate: Wed Jul 8 22:51:22 2026 +0900

    GH-50417: [CI][Dev] Fix shellcheck error in ci/scripts/install_bison.sh 
(#50418)
    
    ### Rationale for this change
    
    Fix shellcheck errors in `ci/scripts/install_bison.sh`
    
    This is the sub issue #44748.
    
    * SC2046: Quote this to prevent word splitting
    
    ```
    In ci/scripts/install_bison.sh line 37:
    make -j$(nproc)
           ^------^ SC2046 (warning): Quote this to prevent word splitting.
    
    For more information:
      https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word 
splitt...
    ```
    
    ### What changes are included in this PR?
    
    * SC2046: Quota variable.
    
    ### Are these changes tested?
    
    Yes.
    
    ### Are there any user-facing changes?
    
    No.
    
    * GitHub Issue: #50417
    
    Authored-by: Hiroyuki Sato <[email protected]>
    Signed-off-by: Sutou Kouhei <[email protected]>
---
 .pre-commit-config.yaml     | 1 +
 ci/scripts/install_bison.sh | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 6fdc177705..145fadd5af 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -298,6 +298,7 @@ repos:
           ?^ci/scripts/cpp_test\.sh$|
           ?^ci/scripts/download_tz_database\.sh$|
           ?^ci/scripts/install_azurite\.sh$|
+          ?^ci/scripts/install_bison\.sh$|
           ?^ci/scripts/install_ccache\.sh$|
           ?^ci/scripts/install_chromedriver\.sh$|
           ?^ci/scripts/install_cmake\.sh$|
diff --git a/ci/scripts/install_bison.sh b/ci/scripts/install_bison.sh
index 793ecdf840..85c49b760d 100755
--- a/ci/scripts/install_bison.sh
+++ b/ci/scripts/install_bison.sh
@@ -34,7 +34,7 @@ wget -q "${url}" -O - | tar -xzf - --directory /tmp/bison 
--strip-components=1
 
 pushd /tmp/bison
 ./configure --prefix="${prefix}"
-make -j$(nproc)
+make -j"$(nproc)"
 make install
 popd
 

Reply via email to