This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new c1f1954ad3 GH-50510: [CI][Dev] Fix shellcheck error in the 
ci/scripts/ccache_fix_perms.sh (#50511)
c1f1954ad3 is described below

commit c1f1954ad306fd14054a894a01e56843e0227cbb
Author: Hiroyuki Sato <[email protected]>
AuthorDate: Thu Jul 16 06:05:50 2026 +0900

    GH-50510: [CI][Dev] Fix shellcheck error in the 
ci/scripts/ccache_fix_perms.sh (#50511)
    
    ### Rationale for this change
    
    This is the sub issue #44748.
    
    * SC2086: Double quote to prevent globbing and word splitting
    
    ```
    In ci/scripts/ccache_fix_perms.sh line 27:
    find ${cache_dir} -type f -exec chmod 644 {} \;
         ^----------^ SC2086 (info): Double quote to prevent globbing and word 
splitting.
    
    Did you mean:
    find "${cache_dir}" -type f -exec chmod 644 {} \;
    
    For more information:
      https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent 
globbing ...
    ```
    
    ### What changes are included in this PR?
    
    * SC2086: Quote the variable.
    
    ### Are these changes tested?
    
    Yes.
    
    ### Are there any user-facing changes?
    
    No.
    * GitHub Issue: #50510
    
    Authored-by: Hiroyuki Sato <[email protected]>
    Signed-off-by: Sutou Kouhei <[email protected]>
---
 .pre-commit-config.yaml        | 1 +
 ci/scripts/ccache_fix_perms.sh | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 878e42aec1..cd81d6e23e 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -294,6 +294,7 @@ repos:
           ?^c_glib/test/run-test\.sh$|
           ?^ci/scripts/c_glib_build\.sh$|
           ?^ci/scripts/c_glib_test\.sh$|
+          ?^ci/scripts/ccache_fix_perms\.sh$|
           ?^ci/scripts/ccache_setup\.sh$|
           ?^ci/scripts/cpp_build\.sh$|
           ?^ci/scripts/cpp_test\.sh$|
diff --git a/ci/scripts/ccache_fix_perms.sh b/ci/scripts/ccache_fix_perms.sh
index 54f9d6d997..9dc1c6502d 100755
--- a/ci/scripts/ccache_fix_perms.sh
+++ b/ci/scripts/ccache_fix_perms.sh
@@ -24,4 +24,4 @@ set -eux
 
 cache_dir=$(ccache --get-config cache_dir)
 
-find ${cache_dir} -type f -exec chmod 644 {} \;
+find "${cache_dir}" -type f -exec chmod 644 {} \;

Reply via email to