(arrow-rs) branch main updated: Remove always-panicking benchmarks (#10384)

[jeffreyvo]

This is an automated email from the ASF dual-hosted git repository.

Jefffrey pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git


The following commit(s) were added to refs/heads/main by this push:
     new ba2ac554c7 Remove always-panicking benchmarks (#10384)
ba2ac554c7 is described below

commit ba2ac554c70df653a4ea2c595ac3cabf6108621d
Author: June <61218022+itsjunet...@users.noreply.github.com>
AuthorDate: Sun Jul 19 22:57:13 2026 -0500

    Remove always-panicking benchmarks (#10384)
    
    # Which issue does this PR close?
    
    No attached issue
    
    # Rationale for this change
    
    These benchmarks always panic, since calling
    `arrow_string::concat_elements::concat_elements_dyn` with
    `DictionaryArray`s always returns an array.
    
    # Are these changes tested?
    
    Yes, all tests pass and now a higher percentage of benchmarks run
    correctly
    
    # Are there any user-facing changes?
    
    No, this is all dev-related
---
 arrow/benches/concatenate_elements.rs | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/arrow/benches/concatenate_elements.rs 
b/arrow/benches/concatenate_elements.rs
index 0b197a54ce..2e841eb031 100644
--- a/arrow/benches/concatenate_elements.rs
+++ b/arrow/benches/concatenate_elements.rs
@@ -22,7 +22,6 @@ extern crate criterion;
 use criterion::Criterion;
 
 use arrow::array::*;
-use arrow::datatypes::*;
 use arrow::util::bench_util::*;
 use arrow_string::concat_elements::concat_elements_dyn;
 use std::hint;
@@ -70,22 +69,6 @@ fn add_benchmark(c: &mut Criterion) {
             c.bench_function(&id, |b| b.iter(|| bench_concat(&array, &array)));
         }
     }
-
-    let v1 = create_string_array_with_len::<i32>(10, 0.0, 20);
-    let v1 = create_dict_from_values::<Int32Type>(1024, 0.0, &v1);
-    let v2 = create_string_array_with_len::<i32>(10, 0.0, 20);
-    let v2 = create_dict_from_values::<Int32Type>(1024, 0.0, &v2);
-    c.bench_function("concat str_dict 1024", |b| {
-        b.iter(|| bench_concat(&v1, &v2))
-    });
-
-    let v1 = create_string_array_with_len::<i32>(1024, 0.0, 20);
-    let v1 = create_sparse_dict_from_values::<Int32Type>(1024, 0.0, &v1, 
10..20);
-    let v2 = create_string_array_with_len::<i32>(1024, 0.0, 20);
-    let v2 = create_sparse_dict_from_values::<Int32Type>(1024, 0.0, &v2, 
30..40);
-    c.bench_function("concat str_dict_sparse 1024", |b| {
-        b.iter(|| bench_concat(&v1, &v2))
-    });
 }
 
 criterion_group!(benches, add_benchmark);