This is an automated email from the ASF dual-hosted git repository.
kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 986641ff8f8 GH-50670: [Release][Dev] Fix only shellcheck SC2086 errors
in the dev directory (#50671)
986641ff8f8 is described below
commit 986641ff8f869256b4c57bd6d34ad06d933655f2
Author: Hiroyuki Sato <[email protected]>
AuthorDate: Tue Jul 28 12:59:42 2026 +0900
GH-50670: [Release][Dev] Fix only shellcheck SC2086 errors in the dev
directory (#50671)
### Rationale for this change
This is the sub issue #44748.
Fix only ShellCheck SC2086 errors in the dev directory.
* SC2086: Double quote to prevent globbing and word splitting.
```
shellcheck dev/release/post-01-tag.sh
In dev/release/post-01-tag.sh line 34:
git tag -a ${release_tag} ${release_candidate_tag} -m "[Release] Apache
Arrow Release ${version}"
^------------^ SC2086 (info): Double quote to prevent globbing
and word splitting.
^----------------------^ SC2086 (info): Double
quote to prevent globbing and word splitting.
Did you mean:
git tag -a "${release_tag}" "${release_candidate_tag}" -m "[Release] Apache
Arrow Release ${version}"
In dev/release/post-01-tag.sh line 35:
git push upstream ${release_tag}
^------------^ SC2086 (info): Double quote to prevent
globbing and word splitting.
Did you mean:
git push upstream "${release_tag}"
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent
globbing ...
```
### What changes are included in this PR?
* SC2086: Quote variables.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
* GitHub Issue: #50670
Authored-by: Hiroyuki Sato <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
---
.pre-commit-config.yaml | 9 +++++++++
dev/release/08-publish-gh-release.sh | 2 +-
dev/release/account-ruby.sh | 2 +-
dev/release/post-01-tag.sh | 4 ++--
dev/release/post-02-upload.sh | 4 ++--
dev/release/post-05-update-gh-release-notes.sh | 2 +-
dev/release/post-07-remove-old-artifacts.sh | 4 ++--
dev/release/post-13-vcpkg.sh | 6 +++---
dev/release/post-14-conan.sh | 6 +++---
dev/release/utils-watch-gh-workflow.sh | 2 +-
10 files changed, 25 insertions(+), 16 deletions(-)
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index dc938bac344..47e0bafc234 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -359,13 +359,22 @@ repos:
?^cpp/src/arrow/flight/sql/odbc/tests/dremio/set_up_dremio_instance\.sh$|
?^dev/release/05-binary-upload\.sh$|
?^dev/release/07-flightsqlodbc-upload\.sh$|
+ ?^dev/release/08-publish-gh-release\.sh$|
?^dev/release/09-binary-verify\.sh$|
+ ?^dev/release/account-ruby\.sh$|
?^dev/release/binary-recover\.sh$|
+ ?^dev/release/post-01-tag\.sh$|
+ ?^dev/release/post-02-upload\.sh$|
?^dev/release/post-03-binary\.sh$|
+ ?^dev/release/post-05-update-gh-release-notes\.sh$|
+ ?^dev/release/post-07-remove-old-artifacts\.sh$|
?^dev/release/post-08-docs\.sh$|
?^dev/release/post-09-python\.sh$|
+ ?^dev/release/post-13-vcpkg\.sh$|
+ ?^dev/release/post-14-conan\.sh$|
?^dev/release/setup-rhel-rebuilds\.sh$|
?^dev/release/utils-generate-checksum\.sh$|
+ ?^dev/release/utils-watch-gh-workflow\.sh$|
?^swift/gen-protobuffers\.sh$|
)
- repo: https://github.com/scop/pre-commit-shfmt
diff --git a/dev/release/08-publish-gh-release.sh
b/dev/release/08-publish-gh-release.sh
index 7e542df8fcb..4a4c3f12e68 100755
--- a/dev/release/08-publish-gh-release.sh
+++ b/dev/release/08-publish-gh-release.sh
@@ -35,4 +35,4 @@ rc=$2
REPOSITORY="apache/arrow"
rc_tag="apache-arrow-${version}-rc${rc}"
-gh release edit ${rc_tag} --repo ${REPOSITORY} --draft=false
+gh release edit "${rc_tag}" --repo "${REPOSITORY}" --draft=false
diff --git a/dev/release/account-ruby.sh b/dev/release/account-ruby.sh
index 9fe1e47bfd2..72f021290ca 100755
--- a/dev/release/account-ruby.sh
+++ b/dev/release/account-ruby.sh
@@ -33,6 +33,6 @@ account=$1
pushd "${SOURCE_DIR}/../../ruby"
for gem in red-*; do
- gem owner ${gem} -a ${account}
+ gem owner "${gem}" -a "${account}"
done
popd
diff --git a/dev/release/post-01-tag.sh b/dev/release/post-01-tag.sh
index 7d261b8c5ba..83052a6c01a 100755
--- a/dev/release/post-01-tag.sh
+++ b/dev/release/post-01-tag.sh
@@ -31,5 +31,5 @@ rc=$2
# Create the release tag and trigger the Publish Release workflow.
release_tag=apache-arrow-${version}
release_candidate_tag=${release_tag}-rc${rc}
-git tag -a ${release_tag} ${release_candidate_tag} -m "[Release] Apache Arrow
Release ${version}"
-git push upstream ${release_tag}
+git tag -a "${release_tag}" "${release_candidate_tag}" -m "[Release] Apache
Arrow Release ${version}"
+git push upstream "${release_tag}"
diff --git a/dev/release/post-02-upload.sh b/dev/release/post-02-upload.sh
index 577972d289b..0c739590511 100755
--- a/dev/release/post-02-upload.sh
+++ b/dev/release/post-02-upload.sh
@@ -34,8 +34,8 @@ echo "Copying dev/ to release/"
svn \
cp \
-m "Apache Arrow ${version}" \
- https://dist.apache.org/repos/dist/dev/arrow/${rc_id} \
- https://dist.apache.org/repos/dist/release/arrow/${release_id}
+ "https://dist.apache.org/repos/dist/dev/arrow/${rc_id}"; \
+ "https://dist.apache.org/repos/dist/release/arrow/${release_id}";
echo "Success! The release is available here:"
echo " https://dist.apache.org/repos/dist/release/arrow/${release_id}";
diff --git a/dev/release/post-05-update-gh-release-notes.sh
b/dev/release/post-05-update-gh-release-notes.sh
index 87c49fa85db..ec3e496b84d 100755
--- a/dev/release/post-05-update-gh-release-notes.sh
+++ b/dev/release/post-05-update-gh-release-notes.sh
@@ -41,4 +41,4 @@ WORKFLOW="release.yml"
# Update the Release Notes section
RELEASE_NOTES_URL="https://arrow.apache.org/release/${VERSION}.html";
RELEASE_NOTES="Release Notes URL: ${RELEASE_NOTES_URL}"
-gh release edit ${TAG} --repo ${REPOSITORY} --notes "${RELEASE_NOTES}"
--verify-tag
+gh release edit "${TAG}" --repo "${REPOSITORY}" --notes "${RELEASE_NOTES}"
--verify-tag
diff --git a/dev/release/post-07-remove-old-artifacts.sh
b/dev/release/post-07-remove-old-artifacts.sh
index cd1bf45b03b..f940049c1d9 100755
--- a/dev/release/post-07-remove-old-artifacts.sh
+++ b/dev/release/post-07-remove-old-artifacts.sh
@@ -33,7 +33,7 @@ for old_rc in $old_rcs; do
svn \
delete \
-m "Remove old Apache Arrow RC: ${old_rc}" \
- ${dev_base_url}/${old_rc}
+ "${dev_base_url}/${old_rc}"
done
echo "Keep only the latest release"
@@ -49,7 +49,7 @@ for old_release_version in $old_releases; do
svn \
delete \
-m "Remove old Apache Arrow release: ${old_release_version}" \
- ${release_base_url}/${old_release_version}
+ "${release_base_url}/${old_release_version}"
done
echo "Success! See the current artifacts:"
diff --git a/dev/release/post-13-vcpkg.sh b/dev/release/post-13-vcpkg.sh
index 6674894e040..f3d1ac9f62c 100755
--- a/dev/release/post-13-vcpkg.sh
+++ b/dev/release/post-13-vcpkg.sh
@@ -52,8 +52,8 @@ git rebase upstream/master
branch="arrow-${version}"
echo "Creating branch: ${branch}"
-git branch -D ${branch} || :
-git checkout -b ${branch}
+git branch -D "${branch}" || :
+git checkout -b "${branch}"
port_arrow=ports/arrow
echo "Updating: ${port_arrow}"
@@ -92,7 +92,7 @@ git commit -m "[arrow] Update to ${version}"
git add versions
git commit -m "Update versions"
-git push origin ${branch}
+git push origin "${branch}"
owner=$(git remote get-url origin | \
diff --git a/dev/release/post-14-conan.sh b/dev/release/post-14-conan.sh
index 45a23e515d7..cf642506340 100755
--- a/dev/release/post-14-conan.sh
+++ b/dev/release/post-14-conan.sh
@@ -52,8 +52,8 @@ git rebase upstream/master
branch="arrow-${version}"
echo "Creating branch: ${branch}"
-git branch -D ${branch} || :
-git checkout -b ${branch}
+git branch -D "${branch}" || :
+git checkout -b "${branch}"
recipes_arrow=recipes/arrow
echo "Updating: ${recipes_arrow}"
@@ -84,7 +84,7 @@ git add ${recipes_arrow}/config.yml
git add ${recipes_arrow}/all/conandata.yml
git commit -m "arrow: add version ${version}"
-git push origin ${branch}
+git push origin "${branch}"
owner=$(git remote get-url origin | \
diff --git a/dev/release/utils-watch-gh-workflow.sh
b/dev/release/utils-watch-gh-workflow.sh
index 163f30251fb..3b93c87cf2c 100755
--- a/dev/release/utils-watch-gh-workflow.sh
+++ b/dev/release/utils-watch-gh-workflow.sh
@@ -52,4 +52,4 @@ gh run watch \
--exit-status \
--interval 60 \
--repo "${REPOSITORY}" \
- ${RUN_ID}
+ "${RUN_ID}"
