(arrow-go) branch main updated: fix(flight/flightsql/driver): convert Date32 values (#1039)

[zeroshade]

This is an automated email from the ASF dual-hosted git repository.

zeroshade pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-go.git


The following commit(s) were added to refs/heads/main by this push:
     new 4b939530 fix(flight/flightsql/driver): convert Date32 values (#1039)
4b939530 is described below

commit 4b93953082e2f5a9b6d68f5421b7d5d53e94f9b0
Author: Minh Vu <vuhoangmin...@gmail.com>
AuthorDate: Tue Jul 28 17:07:50 2026 +0200

    fix(flight/flightsql/driver): convert Date32 values (#1039)
    
    ## What changed
    
    Convert FlightSQL `Date32` array values to `time.Time`, matching the
    existing `Date64` behavior.
    
    ## Why
    
    `Date32` previously fell through to `ErrNotSupported`, preventing valid
    Date32 columns from being consumed through the database/sql driver.
    
    Tests cover both a concrete Date32 value and a null value.
    
    ## Validation
    
    `go test ./arrow/flight/flightsql/driver`
---
 arrow/flight/flightsql/driver/utils.go      |  2 ++
 arrow/flight/flightsql/driver/utils_test.go | 16 ++++++++++++++++
 2 files changed, 18 insertions(+)

diff --git a/arrow/flight/flightsql/driver/utils.go 
b/arrow/flight/flightsql/driver/utils.go
index f8624698..c0e2b3a1 100644
--- a/arrow/flight/flightsql/driver/utils.go
+++ b/arrow/flight/flightsql/driver/utils.go
@@ -102,6 +102,8 @@ func fromArrowType(arr arrow.Array, idx int) (interface{}, 
error) {
                ts := arr.DataType().(*arrow.TimestampType)
                v := c.Value(idx)
                return v.ToTime(ts.TimeUnit()), nil
+       case *array.Date32:
+               return c.Value(idx).ToTime(), nil
        case *array.Date64:
                return c.Value(idx).ToTime(), nil
        case *array.Duration:
diff --git a/arrow/flight/flightsql/driver/utils_test.go 
b/arrow/flight/flightsql/driver/utils_test.go
index d14f00c4..757aa6c0 100644
--- a/arrow/flight/flightsql/driver/utils_test.go
+++ b/arrow/flight/flightsql/driver/utils_test.go
@@ -54,6 +54,7 @@ func Test_fromArrowType(t *testing.T) {
                {Name: "f19-duration_ms", Type: 
arrow.FixedWidthTypes.Duration_ms},
                {Name: "f20-duration_us", Type: 
arrow.FixedWidthTypes.Duration_us},
                {Name: "f21-duration_ns", Type: 
arrow.FixedWidthTypes.Duration_ns},
+               {Name: "f22-d32", Type: arrow.FixedWidthTypes.Date32},
        }
 
        schema := arrow.NewSchema(fields, nil)
@@ -98,6 +99,8 @@ func Test_fromArrowType(t *testing.T) {
        b.Field(18).(*array.DurationBuilder).Append(1)
        b.Field(19).(*array.DurationBuilder).Append(1)
        b.Field(20).(*array.DurationBuilder).Append(1)
+       testDate := time.Date(2026, 7, 28, 0, 0, 0, 0, time.UTC)
+       
b.Field(21).(*array.Date32Builder).Append(arrow.Date32FromTime(testDate))
 
        rec := b.NewRecordBatch()
        defer rec.Release()
@@ -135,4 +138,17 @@ func Test_fromArrowType(t *testing.T) {
        tf(t, 18, time.Duration(1000000))                        // 
"f19-duration_ms"
        tf(t, 19, time.Duration(1000))                           // 
"f20-duration_us"
        tf(t, 20, time.Duration(1))                              // 
"f21-duration_ns"
+       tf(t, 21, testDate)                                      // "f22-d32"
+}
+
+func TestFromArrowTypeReturnsNilForNullDate32(t *testing.T) {
+       b := array.NewDate32Builder(memory.DefaultAllocator)
+       defer b.Release()
+       b.AppendNull()
+       arr := b.NewDate32Array()
+       defer arr.Release()
+
+       got, err := fromArrowType(arr, 0)
+       require.NoError(t, err)
+       require.Nil(t, got)
 }