This is an automated email from the ASF dual-hosted git repository.
kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 4ace6dd87e GH-50860: [Dev][R][Swift][GLib] Simplify pre-commit file
patterns for the r, swift, and c_glib directories (#50861)
4ace6dd87e is described below
commit 4ace6dd87e92d6e19e7a4afbd42f608466664996
Author: Hiroyuki Sato <[email protected]>
AuthorDate: Fri Aug 14 12:58:55 2026 +0900
GH-50860: [Dev][R][Swift][GLib] Simplify pre-commit file patterns for the
r, swift, and c_glib directories (#50861)
### Rationale for this change
This is the sub issue #44748.
* Now that all `r/*.sh` and `c_glib/*.sh` files pass ShellCheck, simplify
the pre-commit file pattern.
* Remove ShellCheck checks for swift since it was moved to a separate
repository.
### What changes are included in this PR?
* Remove ShellCheck checks for the `swift/gen-protobuffers.sh ` file.
* Use a wildcard for the `r` and `c_glib` directories check.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
* GitHub Issue: #50860
Authored-by: Hiroyuki Sato <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
---
.pre-commit-config.yaml | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 1277ad09f6..9a38aef88d 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -291,7 +291,7 @@ repos:
# TODO: Remove this when we fix all lint failures
files: >-
(
- ?^c_glib/test/run-test\.sh$|
+ ?^c_glib/.*\.sh$|
?^ci/.*\.sh$|
?^cpp/build-support/build-lz4-lib\.sh$|
?^cpp/build-support/build-zstd-lib\.sh$|
@@ -321,9 +321,7 @@ repos:
?^dev/release/setup-rhel-rebuilds\.sh$|
?^dev/release/utils-generate-checksum\.sh$|
?^dev/release/utils-watch-gh-workflow\.sh$|
- ?^r/tools/download_dependencies_R\.sh$|
- ?^r/inst/build_arrow_static\.sh$|
- ?^swift/gen-protobuffers\.sh$|
+ ?^r/.*\.sh$|
)
- repo: https://github.com/scop/pre-commit-shfmt
# v3.11.0-1 or later requires pre-commit 3.2.0 or later but Ubuntu