(arrow-adbc) branch main updated: chore(c/validation): remove quirk for float16 ingestion (#4779)

[lidavidm]

This is an automated email from the ASF dual-hosted git repository.

lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git


The following commit(s) were added to refs/heads/main by this push:
     new 32c67b092 chore(c/validation): remove quirk for float16 ingestion 
(#4779)
32c67b092 is described below

commit 32c67b092c0f7cabf2be75062f001a9e17a48cc1
Author: Fredrik Fornwall <fred...@fornwall.net>
AuthorDate: Tue Sep 15 09:45:22 2026 +0200

    chore(c/validation): remove quirk for float16 ingestion (#4779)
    
    Remove the quirk for float16 ingestion - it's better to override the
    test method and skip it, instead of adding a lot of quirks.
    
    Signed-off-by: Fredrik Fornwall <fred...@fornwall.net>
---
 c/validation/adbc_validation.h            | 3 ---
 c/validation/adbc_validation_statement.cc | 4 ----
 2 files changed, 7 deletions(-)

diff --git a/c/validation/adbc_validation.h b/c/validation/adbc_validation.h
index 5fcaa0ad8..2226704f3 100644
--- a/c/validation/adbc_validation.h
+++ b/c/validation/adbc_validation.h
@@ -258,9 +258,6 @@ class DriverQuirks {
   /// \brief Whether ingestion supports StringView/BinaryView types
   virtual bool supports_ingest_view_types() const { return true; }
 
-  /// \brief Whether ingestion supports Float16
-  virtual bool supports_ingest_float16() const { return true; }
-
   /// \brief Default catalog to use for tests
   virtual std::string catalog() const { return ""; }
 
diff --git a/c/validation/adbc_validation_statement.cc 
b/c/validation/adbc_validation_statement.cc
index e77ad0588..42421e97a 100644
--- a/c/validation/adbc_validation_statement.cc
+++ b/c/validation/adbc_validation_statement.cc
@@ -283,10 +283,6 @@ void StatementTest::TestSqlIngestInt64() {
 }
 
 void StatementTest::TestSqlIngestFloat16() {
-  if (!quirks()->supports_ingest_float16()) {
-    GTEST_SKIP();
-  }
-
   
ASSERT_NO_FATAL_FAILURE(TestSqlIngestNumericType<float>(NANOARROW_TYPE_HALF_FLOAT));
 }