This is an automated email from the ASF dual-hosted git repository.
zanmato1984 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 676dd43c5fe GH-51687: [C++] Skipt tests that require threads if
ARROW_ENABLE_THREADING=OFF (#51688)
676dd43c5fe is described below
commit 676dd43c5fef2dbb3c42e7b03b43ca6f952bd405
Author: Raúl Cumplido <[email protected]>
AuthorDate: Fri Oct 2 15:16:47 2026 +0200
GH-51687: [C++] Skipt tests that require threads if
ARROW_ENABLE_THREADING=OFF (#51688)
### Rationale for this change
The following PR introduced some tests that require threeading but those
are not skipped when ARROW_ENABLE_THREADING=OFF failing on jobs like emscripten.
- https://github.com/apache/arrow/pull/51498
### What changes are included in this PR?
Skip the tests if ARROW_ENABLE_THREADING=OFF
### Are these changes tested?
Yes via archer with the failing job.
### Are there any user-facing changes?
No
### Was AI used for this PR?
In accordance to the [AI generation
guidelines](https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code),
please disclose below whether and how AI was used in this PR.
**PR code and description written by:**
- [x] Human
- [ ] AI
**Reviewed before submission by:**
- [x] Human
- [ ] AI
- [ ] Not reviewed
* GitHub Issue: #51687
Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Rossi Sun <[email protected]>
---
cpp/src/arrow/util/async_generator_test.cc | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/cpp/src/arrow/util/async_generator_test.cc
b/cpp/src/arrow/util/async_generator_test.cc
index 9d965dbc4e5..e51410b73e8 100644
--- a/cpp/src/arrow/util/async_generator_test.cc
+++ b/cpp/src/arrow/util/async_generator_test.cc
@@ -976,6 +976,9 @@ TEST_F(MergedGeneratorErrorHookTest,
OuterErrorToWaiterNotOvertakenByLaterPull)
// receives the error has completed, even when it is requested while the
generator is
// already completing.
TEST_F(MergedGeneratorErrorHookTest,
InnerErrorToWaiterNotOvertakenDuringCompletion) {
+#ifndef ARROW_ENABLE_THREADING
+ GTEST_SKIP() << "Test requires threading support";
+#endif
auto failing = Future<TestInt>::Make();
AsyncGenerator<TestInt> failing_sub = [failing]() { return failing; };
std::vector<AsyncGenerator<TestInt>> subs = {failing_sub};
@@ -994,6 +997,9 @@ TEST_F(MergedGeneratorErrorHookTest,
InnerErrorToWaiterNotOvertakenDuringComplet
}
TEST_F(MergedGeneratorErrorHookTest,
OuterErrorToWaiterNotOvertakenDuringCompletion) {
+#ifndef ARROW_ENABLE_THREADING
+ GTEST_SKIP() << "Test requires threading support";
+#endif
auto failing = Future<AsyncGenerator<TestInt>>::Make();
AsyncGenerator<AsyncGenerator<TestInt>> source = [failing]() { return
failing; };
MergedGenerator<TestInt> gen(std::move(source), 1);
@@ -1011,6 +1017,9 @@ TEST_F(MergedGeneratorErrorHookTest,
OuterErrorToWaiterNotOvertakenDuringComplet
}
TEST_F(MergedGeneratorErrorHookTest, ClaimedErrorNotOvertakenDuringCompletion)
{
+#ifndef ARROW_ENABLE_THREADING
+ GTEST_SKIP() << "Test requires threading support";
+#endif
auto failing = Future<TestInt>::Make();
AsyncGenerator<TestInt> failing_sub = [failing]() { return failing; };
std::vector<AsyncGenerator<TestInt>> subs =
{MakeVectorGenerator<TestInt>({TestInt(1)}),
