This is an automated email from the ASF dual-hosted git repository. github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-11387-02accced63a992a20c91cbb5ac24261863531751 in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
commit 6e359083973ced84b77e04ac23c26433378cd91d Author: RIchard Baah <[email protected]> AuthorDate: Tue Oct 6 03:21:41 2026 +0000 Feat: allow users to untake (#11387) # Which issue does this PR close? <!-- It is not necessary to raise an issue, but it is encouraged if it is a non-trivial enhancement/bug. If this PR relates to an existing issue, but does not fully resolve it, please change the wording below from "Closes #NNN" to "Relates to #NNN" or "Part of #NNN" to avoid false closing an issue. --> - Closes #11347 # Rationale for this change see #11347 <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. Please try to explain the problem you are trying to solve in terms of the user-visible behavior, rather than the implementation. --> # What changes are included in this PR? add untake command for ci. <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are these changes tested? I think we need to merge to see if it works <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests, if so identify these tests)? If this PR claims a performance improvement, please include evidence such as benchmark results. DO NOT simply paste a list of commands ran to verify the code; this is what our CI is for and it pollutes the PR. ONLY explain if testing was included with this PR, or why it wasn't. --> # Are there any significant user-facing changes? yes, users can now untake issues if they dont plan on working on it. <!-- Significant user-facing changes include: - Breaking public API change - Significant change to existing functionality (e.g. function returns something different) These need to be explicitly called out to ensure we have proper documentation if required and to ensure we follow proper semantic versioning. DO NOT restate the changes of this PR; if a bug was fixed and already explained above, we don't need this to be restated as a user-facing change. --> --- .github/workflows/take.yml | 7 ++++--- CONTRIBUTING.md | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/.github/workflows/take.yml b/.github/workflows/take.yml index 5ae4fdb3f1..22ddd2524f 100644 --- a/.github/workflows/take.yml +++ b/.github/workflows/take.yml @@ -15,7 +15,7 @@ # specific language governing permissions and limitations # under the License. -name: Assign the issue via a `take` comment +name: Assign or unassign the issue via a `take`/`untake` comment on: issue_comment: types: created @@ -25,13 +25,14 @@ permissions: jobs: issue_assign: - if: (!github.event.issue.pull_request) && github.event.comment.body == 'take' + if: (!github.event.issue.pull_request) && (github.event.comment.body == 'take' || github.event.comment.body == 'untake') runs-on: ubuntu-slim steps: - uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0 with: script: | - github.rest.issues.addAssignees({ + const method = context.payload.comment.body === 'take' ? 'addAssignees' : 'removeAssignees'; + github.rest.issues[method]({ owner: context.repo.owner, repo: context.repo.repo, issue_number: context.issue.number, diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1edb8ed696..34fc582af2 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -49,9 +49,10 @@ If you want to work on an issue which is not already assigned to someone else and there are no comment indicating that someone is already working on that issue then you can assign the issue to yourself by submitting a single word comment `take`. This will assign the issue to yourself. However, if you are -unable to make progress you should unassign the issue by using the `unassign me` -link at the top of the issue page (and ask for help if are stuck) so that -someone else can get involved in the work. +unable to make progress you should unassign the issue so that someone else can +get involved in the work. You can do this either by using the `unassign me` +link at the top of the issue page or by leaving a single word comment `untake` +(and ask for help if you are stuck). If you plan to work on a new feature that doesn't have an existing ticket, it is a good idea to open a ticket to discuss the feature. Advanced discussion often
