This is an automated email from the ASF dual-hosted git repository. github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-11399-a1833f2bc4ec90117605b296bd0b9859b961b40f in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
commit e189ba8f9457ce7eb8d75d89c639c03b0228a55b Author: Jeffrey Vo <[email protected]> AuthorDate: Thu Oct 8 18:27:31 2026 +0000 chore: add `w NULLS` to names of filter benchmarks that have nulls (#11399) - related to https://github.com/apache/arrow-rs/pull/11257 i wanted to run all the benchmarks which exhibit affected `filter_nulls` path, but looks like there were some benchmarks that exhibited that path but didnt actually have `NULLS` in the name so its harder to ensure we get a comprehensive run fix generated by codex & reviewed by me --- arrow/benches/filter_kernels.rs | 36 +++++++++++++++++++----------------- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/arrow/benches/filter_kernels.rs b/arrow/benches/filter_kernels.rs index 8d7a973605..8d7403ae04 100644 --- a/arrow/benches/filter_kernels.rs +++ b/arrow/benches/filter_kernels.rs @@ -164,19 +164,20 @@ fn add_benchmark(c: &mut Criterion) { ); let data_array = create_primitive_array::<Float32Type>(size, 0.5); - c.bench_function("filter f32 (kept 1/2)", |b| { + c.bench_function("filter f32 w NULLs (kept 1/2)", |b| { b.iter(|| bench_filter(&data_array, &filter_array)) }); - c.bench_function("filter context f32 (kept 1/2)", |b| { + c.bench_function("filter context f32 w NULLs (kept 1/2)", |b| { b.iter(|| bench_built_filter(&data_array, &filter)) }); c.bench_function( - "filter context f32 high selectivity (kept 1023/1024)", + "filter context f32 w NULLs high selectivity (kept 1023/1024)", |b| b.iter(|| bench_built_filter(&data_array, &dense_filter)), ); - c.bench_function("filter context f32 low selectivity (kept 1/1024)", |b| { - b.iter(|| bench_built_filter(&data_array, &sparse_filter)) - }); + c.bench_function( + "filter context f32 w NULLs low selectivity (kept 1/1024)", + |b| b.iter(|| bench_built_filter(&data_array, &sparse_filter)), + ); let data_array = create_primitive_array::<Decimal128Type>(size, 0.0); c.bench_function("filter decimal128 (kept 1/2)", |b| { @@ -202,16 +203,17 @@ fn add_benchmark(c: &mut Criterion) { ); let data_array = create_string_array::<i32>(size, 0.5); - c.bench_function("filter context string (kept 1/2)", |b| { + c.bench_function("filter context string w NULLs (kept 1/2)", |b| { b.iter(|| bench_built_filter(&data_array, &filter)) }); c.bench_function( - "filter context string high selectivity (kept 1023/1024)", + "filter context string w NULLs high selectivity (kept 1023/1024)", |b| b.iter(|| bench_built_filter(&data_array, &dense_filter)), ); - c.bench_function("filter context string low selectivity (kept 1/1024)", |b| { - b.iter(|| bench_built_filter(&data_array, &sparse_filter)) - }); + c.bench_function( + "filter context string w NULLs low selectivity (kept 1/1024)", + |b| b.iter(|| bench_built_filter(&data_array, &sparse_filter)), + ); let data_array = create_string_dict_array::<Int32Type>(size, 0.0, 4); c.bench_function("filter context string dictionary (kept 1/2)", |b| { @@ -299,28 +301,28 @@ fn add_benchmark(c: &mut Criterion) { }); let data_array = create_string_view_array_with_len(size, 0.5, 4, false); - c.bench_function("filter context short string view (kept 1/2)", |b| { + c.bench_function("filter context short string view w NULLs (kept 1/2)", |b| { b.iter(|| bench_built_filter(&data_array, &filter)) }); c.bench_function( - "filter context short string view high selectivity (kept 1023/1024)", + "filter context short string view w NULLs high selectivity (kept 1023/1024)", |b| b.iter(|| bench_built_filter(&data_array, &dense_filter)), ); c.bench_function( - "filter context short string view low selectivity (kept 1/1024)", + "filter context short string view w NULLs low selectivity (kept 1/1024)", |b| b.iter(|| bench_built_filter(&data_array, &sparse_filter)), ); let data_array = create_string_view_array_with_len(size, 0.5, 4, true); - c.bench_function("filter context mixed string view (kept 1/2)", |b| { + c.bench_function("filter context mixed string view w NULLs (kept 1/2)", |b| { b.iter(|| bench_built_filter(&data_array, &filter)) }); c.bench_function( - "filter context mixed string view high selectivity (kept 1023/1024)", + "filter context mixed string view w NULLs high selectivity (kept 1023/1024)", |b| b.iter(|| bench_built_filter(&data_array, &dense_filter)), ); c.bench_function( - "filter context mixed string view low selectivity (kept 1/1024)", + "filter context mixed string view w NULLs low selectivity (kept 1/1024)", |b| b.iter(|| bench_built_filter(&data_array, &sparse_filter)), );
