(arrow-adbc) branch main updated: test(c): increase test coverage for driver manager (#4972)

[lidavidm]

This is an automated email from the ASF dual-hosted git repository.

lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git


The following commit(s) were added to refs/heads/main by this push:
     new 29d7b51620 test(c): increase test coverage for driver manager (#4972)
29d7b51620 is described below

commit 29d7b516202de77b3698d98618ddfcd01dc60dfd
Author: Bryce Mecum <petrid...@gmail.com>
AuthorDate: Tue Oct 27 20:39:01 2026 -0700

    test(c): increase test coverage for driver manager (#4972)
    
    Adds some basic test coverage for loading drivers by name/path. I found
    these gaps while working on
    https://github.com/apache/arrow-adbc/pull/4971.
---
 c/driver_manager/adbc_driver_manager_test.cc | 90 +++++++++++++++++++++++++---
 1 file changed, 83 insertions(+), 7 deletions(-)

diff --git a/c/driver_manager/adbc_driver_manager_test.cc 
b/c/driver_manager/adbc_driver_manager_test.cc
index 7cef29ab49..d81df1ff24 100644
--- a/c/driver_manager/adbc_driver_manager_test.cc
+++ b/c/driver_manager/adbc_driver_manager_test.cc
@@ -710,15 +710,15 @@ class DriverManifest : public ::testing::Test {
         {"publisher", "arrow-adbc"},
         {"version", "X.Y.Z"},
         {"ADBC",
-         toml::table{
-             {"version", "1.1.0"},
+         toml::table {
+           {"version", "1.1.0"},
          }},
         {"Driver",
-         toml::table{
-             {"shared",
-              toml::table{
-                  {InternalAdbcCurrentArch(), driver_path.string()},
-              }},
+         toml::table {
+           {"shared",
+            toml::table {
+              {InternalAdbcCurrentArch(), driver_path.string()},
+            }},
          }},
     };
 
@@ -1364,6 +1364,82 @@ TEST_F(DriverManifest, CondaPrefix) {
   }
 }
 
+// A driver that does not exist should be reported as NOT_FOUND no matter how
+// it was specified or which search locations are enabled.
+namespace {
+constexpr const char* kMissingDriverName =
+    "adbc_test_driver_manager_missing_driver_7c8f5482";
+
+void ExpectMissingDriverNotFound(const std::string& driver_name,
+                                 AdbcLoadFlags load_options,
+                                 const char* additional_search_path_list = 
nullptr) {
+  SCOPED_TRACE("driver=" + driver_name + " load_options=" + 
std::to_string(load_options));
+  struct AdbcDriver driver = {};
+  struct AdbcError error = {};
+  EXPECT_THAT(
+      AdbcFindLoadDriver(driver_name.c_str(), nullptr, ADBC_VERSION_1_1_0, 
load_options,
+                         additional_search_path_list, &driver, &error),
+      IsStatus(ADBC_STATUS_NOT_FOUND, &error));
+  if (error.release) {
+    error.release(&error);
+  }
+  if (driver.release) {
+    driver.release(&driver, nullptr);
+  }
+}
+
+std::string MissingDriverDir() {
+  return (std::filesystem::temp_directory_path() / 
"adbc_missing_driver_dir_7c8f5482")
+      .string();
+}
+
+std::string PlatformLibraryName(const std::string& name) {
+#if defined(_WIN32)
+  return name + ".dll";
+#elif defined(__APPLE__)
+  return "lib" + name + ".dylib";
+#else
+  return "lib" + name + ".so";
+#endif
+}
+}  // namespace
+
+TEST(DriverManagerNotFound, BareNameAllLoadFlags) {
+  constexpr AdbcLoadFlags kAllFlags =
+      ADBC_LOAD_FLAG_SEARCH_ENV | ADBC_LOAD_FLAG_SEARCH_USER |
+      ADBC_LOAD_FLAG_SEARCH_SYSTEM | ADBC_LOAD_FLAG_ALLOW_RELATIVE_PATHS;
+  for (AdbcLoadFlags flags = 0; flags <= kAllFlags; ++flags) {
+    ExpectMissingDriverNotFound(kMissingDriverName, flags);
+  }
+}
+
+TEST(DriverManagerNotFound, BareNameAdditionalSearchPath) {
+  std::string search_path = MissingDriverDir();
+  ExpectMissingDriverNotFound(kMissingDriverName, ADBC_LOAD_FLAG_DEFAULT,
+                              search_path.c_str());
+  ExpectMissingDriverNotFound(kMissingDriverName, 0, search_path.c_str());
+}
+
+TEST(DriverManagerNotFound, AbsolutePathWithoutExtension) {
+  std::string path =
+      (std::filesystem::path(MissingDriverDir()) / 
kMissingDriverName).string();
+  ExpectMissingDriverNotFound(path, ADBC_LOAD_FLAG_DEFAULT);
+  ExpectMissingDriverNotFound(path, 0);
+}
+
+TEST(DriverManagerNotFound, AbsolutePathWithLibraryExtension) {
+  std::string path = (std::filesystem::path(MissingDriverDir()) /
+                      PlatformLibraryName(kMissingDriverName))
+                         .string();
+  ExpectMissingDriverNotFound(path, ADBC_LOAD_FLAG_DEFAULT);
+  ExpectMissingDriverNotFound(path, 0);
+}
+
+TEST(DriverManagerNotFound, RelativePathWithLibraryExtension) {
+  ExpectMissingDriverNotFound(PlatformLibraryName(kMissingDriverName),
+                              ADBC_LOAD_FLAG_DEFAULT);
+}
+
 TEST_F(DriverManifest, ImplicitUri) {
   auto filepath = temp_dir / "postgresql.toml";
   std::ofstream test_manifest_file(filepath);