Repository: asterixdb Updated Branches: refs/heads/master dbe8ffc21 -> 8a7894f58
[ASTERIXDB-2166] Fix bulk load bloom filters for buddy btree - user model changes: no - storage format changes: no - interface changes: no Details: - Fix bulk loading bloom filters for buddy btrees. For these bloom filters, the deleted keys are added through the delete method, which shouldn't be ignored by the bloom filter bulk loader Change-Id: Icc7ca46c69c9102010f4b407ca0e9d96ba19289b Reviewed-on: https://asterix-gerrit.ics.uci.edu/2152 Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Contrib: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: abdullah alamoudi <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/asterixdb/repo Commit: http://git-wip-us.apache.org/repos/asf/asterixdb/commit/8a7894f5 Tree: http://git-wip-us.apache.org/repos/asf/asterixdb/tree/8a7894f5 Diff: http://git-wip-us.apache.org/repos/asf/asterixdb/diff/8a7894f5 Branch: refs/heads/master Commit: 8a7894f582d2441394ab574145df581ff5c0daeb Parents: dbe8ffc Author: luochen01 <[email protected]> Authored: Tue Nov 14 15:24:57 2017 -0800 Committer: Luo Chen <[email protected]> Committed: Tue Nov 14 19:29:35 2017 -0800 ---------------------------------------------------------------------- .../storage/am/lsm/common/impls/BloomFilterBulkLoader.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/asterixdb/blob/8a7894f5/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/BloomFilterBulkLoader.java ---------------------------------------------------------------------- diff --git a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/BloomFilterBulkLoader.java b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/BloomFilterBulkLoader.java index 0dcf349..29ca388 100644 --- a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/BloomFilterBulkLoader.java +++ b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/BloomFilterBulkLoader.java @@ -26,12 +26,12 @@ public class BloomFilterBulkLoader implements IChainedComponentBulkLoader { private final IIndexBulkLoader bulkLoader; + private boolean endedBloomFilterLoad = false; + public BloomFilterBulkLoader(IIndexBulkLoader bulkLoader) { this.bulkLoader = bulkLoader; } - private boolean endedBloomFilterLoad = false; - @Override public ITupleReference add(ITupleReference tuple) throws HyracksDataException { bulkLoader.add(tuple); @@ -40,7 +40,8 @@ public class BloomFilterBulkLoader implements IChainedComponentBulkLoader { @Override public ITupleReference delete(ITupleReference tuple) throws HyracksDataException { - //Noop + // this ensure deleted keys are also added to the bulkloader + bulkLoader.add(tuple); return tuple; }
